hpi-swa-lab / home-desktop-system Goto Github PK

Some drops are forwarded to the wrong morph (e.g. a drop on a badge is handled by the line). Also the drop event handling method includes cases that are no longer triggered by anyone.

DomainObject>>externalFileName uses a hardcoded path.

externalFileName

  ^ (self has: #file) 
    ifTrue: [ | fileName |	
      fileName := self file asString.
      (fileName includesSubstring: ':PDF')
        ifTrue: [fileName := 'C:\Users\patri\Desktop\literature\phd\' , (fileName copyWithoutFirst copyUpTo: $:)].
      fileName]

The current implementation includes too many assumptions about the location of the VM and the image.

The following features should work:

• Add a field to the object
• Editing widget for numbers
• Change order of collection items (if possible)

The method DomainObject class >> resolve:createBasedOn:automaticAccept: looks off to me. It sends the selector levenshteinDistanceTo: but there are no implementors for it.

HomeDataIntegrityRuleResult class>>newManuelInterventionResultFromResults:for:

The ObjectEditor wrapper should have both, the original selector as well as the label. Further, the fields should be based on selectors not instance variables.