hramenko / bauglir-websocket Goto Github PK

I tried to compile CustomDemo with Delphi 2007 but the compiler doesn't find 
blcksock.pas.

What steps will reproduce the problem?
1. download zipfile for 2.0.2
2. view Properties/AssemblyInfo.cs

What is the expected output? What do you see instead?
expect to see version as 2.0.2, instead see version is listed as 2.0.1 

What version of the product are you using? On what operating system?
not sure. Linux.

Please provide any additional information below.

Add events 
  * OnReceiveData to listen for receiving from outside of connection/server thread.
  * OnSendData to listen for sending from outside of connection/server thread.
  * OnHandshake to listen for successfull handshake from outside of connection/server thread.

For Pascal implementation

New version of protocol is comming that should be secured against transparent 
proxy attacks.

Create libraries for Windows and Linux

Since WS client connection and WS server connection object are inherited from 
different type of connections objects, there is too much thing duplicated.
In fact, there is no reason for 2 object types (each for different type of 
connection), there can be only one.

What steps will reproduce the problem?
1. Opened Delphi Server demo with Delphi XE - ok
2. Compiled server demo e server started - ok
3. Loaded ws.html with Firefox 7.0.1 - ok
4. Open websocket - ok
5. Send text - ko

Server raise this Exception in WebSocket2.pas:

if (result = 0) and (fRequireMasking) and (not mask) then
   begin
     // TODO some protocol error
     raise Exception.Create('mask');
   end;

There is no way to test whether WS handshake was successful. There should be 
connection property to keep this connection attribute.

Create native implementation

incorrect UTF-8 text splitting

1/ empty headers reading
2/ protocol header should not be sent if not set up

What steps will reproduce the problem?
1. Open the .NET demo project with the latest version of the Websocket classes.
2. Use Chrome (v.19) and test try to hit the local machine using 
ws://localhost:81/

What is the expected output? What do you see instead?
I expect the incoming data from the browser to print "WebSocket rocks".  
Instead the Websocket server class returns "OM�O�N-Q(�R�".

What version of the product are you using? On what operating system?
Websocket v2.0.4 (from 01/30/2012), .NET 4, VS.NET 2010, Windows XP 32Bit.

I've written the app using Chrome Version 18.0.1025.152. When coming back to 
the project (without changing anything) Chrome has updated to 19.0.1084.46. 
What LocalWebSocketServerConnection.RStream receives now isn't an UTF-8 text 
anymore. Is there anything I can do about this or did Google changed some specs?

Default client protocol version should be 13 according to RFC

TTestWebSocketClientConnection constructor default values shoud be the same as 
in TWebSocketClientConnection

Name is confusing

What steps will reproduce the problem?
1.I used BauglirWebSocket2_.net_demo.2.0.1, _.net_library.2.0.4 and 
_html.2.0.3. I replaced the WebSocketLib-folder from the demo with the one from 
library 2.0.4 and started the Demo-Server with the default settings.
2. Click on "Open" in ws.html.

What is the expected output? What do you see instead?
VS2010 breaks on line 1722 of WebSocketServer.cs:
System.TypeLoadException wurde nicht behandelt.
  Message=Eine abgeleitete Methode "SendData" im Typ "ServerDemo.TestWebSocketServerConnection" der Assembly "ServerDemo, Version=1.0.4470.15471, Culture=neutral, PublicKeyToken=null" kann den Zugriff nicht reduzieren.
  Source=ServerDemo
  TypeName=ServerDemo.TestWebSocketServerConnection
  StackTrace:
       bei ServerDemo.TestWebSocketServer.GetConnectionInstance(TcpClient aClient, WebSocketHeaders aHeaders, String aHost, String aPort, String aResourceName, String aOrigin, String aCookie, String aVersion, String& aProtocol, String& aExtension, Int32& aHttpCode)
       bei Bauglir.Ex.WebSocketServer.AddConnection(TcpClient aClient, Stream aStream) in E:\work\csharp\Projects\_Free\WebSocket2\WebSocketLib\WebSocketServer.cs:Zeile 1722.
       bei Bauglir.Ex.WebSocketServer.Execute() in E:\work\csharp\Projects\_Free\WebSocket2\WebSocketLib\WebSocketServer.cs:Zeile 1907.
       bei System.Threading.ThreadHelper.ThreadStart_Context(Object state)
       bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
       bei System.Threading.ThreadHelper.ThreadStart()

The error-message in English would be:
A derived method "SendData" in Type ... of the assembly ... cannot reduce 
access.

What version of the product are you using? On what operating system?
Windows 7 HomePremium 64bit SP1 German
Google Chrome 18 (latest beta)
Firefox 11.0

There should be no Host header checking against server binding settings, if 
client can connect, let application decide whether to accept such Host 

What steps will reproduce the problem?
1. use chrome 16.0.912.63 
2. use server & web client demo

What is the expected output? What do you see instead?

a connection to the server

What version of the product are you using? On what operating system?

chrome 16.0.912.63, windows 7

Please provide any additional information below.

error code 1006

What steps will reproduce the problem?
1. Write a client which uses the websocket client object
2. Multithread alot of sendTexts 
3. Watch it start to send garbage to server

What is the expected output? What do you see instead?
Server starts to complain the data coming through is not UTF-8

What version of the product are you using? On what operating system?
Latest, on windows

Please provide any additional information below.

Its simple to fix, just wrap the core of sendData in a lock(object) { } which 
will allow only 1 frame sent at a time.

Add abilility to automatically convert data to UTF8

Error when closing connection while reading data

Data are processed once they are complete in most applications. Framing must be 
reimplemented by connection descendant class to concanate incoming data and 
process those / fire event once final frame is received.

Mechanism for processing full data should be implemented.

Version 2.0.0

Only works in FIrefox browser, not in Chrome, IE and Safari.

Seems chrome using 

http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol-76

Have not changed this yet to test other browsers but on my way to test it.

Add support for extensions negotiation and data manipulation

In Delphi 2009, the latest version of the client demo fails to compile here:


  TTestWebSocketClientConnection = class(TWebSocketClientConnection)
    fFramedText: string;

The error is: [DCC Error] MainFormU.pas(12): E2217 Published field 
'fFramedText' not a class or interface type

Adding private or protected before this line allows it to compile, but then 
clicking "Start Client" fails with no error (i.e. the client does not appear to 
start, no communications to the server takes place, and the "Start" button is 
not disabled; but no error or exception occurs.

Using the pre-compiled version of the Client Demo works fine, and compiling the 
Server Demo works fine.

Ability to send generic frame should be public

Create libraries (dll, so) from Windows/Linux so WebSocket protocol 
implementation can be used frmo within other than Pascal program.

This method provides the best way to test whether connection can be used 
(thread exists, WS connection is not closing, socket exists, etc.)
It is useful outside of thread as well

Does this library handle extensions negotiation correctly?

See this recent issue: http://code.google.com/p/chromium/issues/detail?id=123231


Great work btw! 

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

Thread events synchronization issue on very frequent traffic

http://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-05

line 799

Event handler ConnectionReadFull is called, if its null, get Null ref Ex

Line should be

if (ConnectionReadFull != null) ConnectionReadFull(this, lastCode2, fms);

Due to change in string type (from ANSI to Unicode), Delphi XE does not work 
properly (framing) 

Closing connection can cause infinite sleeps and deadlocks

There is no way to pass connection/server parametert to library (ssl, autoutf8, 
etc.)

What steps will reproduce the problem?
1.
start tcpdump, or other TCP analyzer. 
2.
Send packet to server.
3.
Monitor the TCP traffic between client and server.

What is the expected output? What do you see instead?
Expect:
TCP data from client
Ack from server

Instead
TCP data from client
Ack from server
TCP data from client
Ack from server

What version of the product are you using? On what operating system?
V2.04 pascal version

Client: windows 7 
Server: Ubuntu 12.04 server

Please provide any additional information below.
See source code attachment for the simple fix.

Add CloseAllConnections method to server

Since fSocket is used for reading and writing from different thread, its 
properties (e.g. LastError) can be rewritten between threads. Use another 
TTCPBlockConnection for writing

Close codes have been updated

http://tools.ietf.org/html/rfc6455#section-7.4

Create native implementation

Hello i am new to code.google. i am unable to find any code example or doucment 
which could help me initiating webSocket a connection in C# with "wss"

and does this Solution support "wss"?

Please advise.

Best Regards,
Atif

add wss protocol support to Pascal library

Data sending is currently in main application thread. In case of a lot of 
connections (server) and/or large data to send this can cause application to be 
blocked and sequential sending (server) in stead of parallel

Create PHP client implementation