hsanson / asciidoctor-plantuml Goto Github PK

Hi!
I was wondering about a way of specifying a concrete plantuml.jar file for asciidoctor-pdf. The one coming with asciidoctor-pdf seems an older file than the version found in plantuml.com. Not being much of a ruby programmer I was looking through .rb for asciidoctor-pdf, and could not find any obvious parts...

Thanks!

Currently, the extension only works on listing blocks. Since Asciidoctor Diagram recognizes both literal and listing blocks I think it would be great to also enable this extension on literal blocks.
I also believe that a literal block is semantically more accurate than a listing block (but it might be subjective).

I think the main benefit would be that users won't have to update their document if they want to use Asciidoctor Diagram or this extension.

What do you think?

Based on this comment #25 (comment) is important to assess the risk of this functionality.

Many security issues in Nokogiri need update.

Rubygems lists 6 versions[0] for asciidoctor-plantuml whereas the git repo has only one tag. Please push the remaining tags to the repo.

[0] https://rubygems.org/gems/asciidoctor-plantuml/versions

Security advisor on nokogiri 1.13.4:

• [CRuby] Address CVE-2022-29181, improper handling of unexpected data types, related to untrusted inputs to the SAX parsers. See GHSA-xh29-r2w5-wx8m for more information.
• [CRuby] Vendored libxml2 is updated to address CVE-2022-29824. See GHSA-cgx6-hpwq-fhv5 for more information.

Note this gem uses nokogiri only for running the tests and it is never used in the gem itself. These security advisors should not pose a risk to users of the gem.

This Gem has a runtime dependency on Asciidoctor restricted to 1.5.x. In addition this Gem is used in GitLab and as a result it's not possible to upgrade to Asciidoctor 2.x.

Since Asciidoctor 2.x is mostly compatible with Asciidoctor 1.5.6+, we should loosen this restriction.

I've to write diagram in chinese, therefore, I need to set font for the diagram.

Currently, it's not possible to use this extension when the output is not an HTML document. Using Block and Image object would allow to use this extension with Asciidoctor PDF and non-HTML converters (manpage, docbook...)

Could you please create a new version tag including latest changes?

Project including your lib are still not up-to-date and won't have the updates until there is a new version

Thanks

Here's an example:

:action: hello

[plantuml,subs=+attributes]
----
alice -> bob : {action}
----

In the above example, {action} should be replaced/substituted by hello.
You can use the following code to do that:

subs = attrs['subs']
content = parent.apply_subs(content, parent.resolve_subs(subs)) if subs

Could you please also add support for the block macro syntax?
See: https://github.com/asciidoctor/asciidoctor-diagram/#diagram-block-macro

I am often using plantuml::file.puml[] as it is shorter than the literal block version.

Thank you

The official plantuml.com server changed to URL format. Gitlab (and probably some other webapps) use asciidoctor-plantuml to create an image URL. Since the URL was changed, plantuml images are broken on Gitlab.

broken example from your testsuite

I copied the URL from your testsuite and changed the host

https://www.plantuml.com/plantuml/png/U9npA2v9B2efpStX2YrEBLBGjLFG20Q9Q4Bv804WIw4a8rKXiQ0W9pCviIGpFqzJmKh19p4fDOVB8JKl1QWT05kd5wq0

This works

Just by adding ~1 it's fixed

https://www.plantuml.com/plantuml/png/~1U9npA2v9B2efpStX2YrEBLBGjLFG20Q9Q4Bv804WIw4a8rKXiQ0W9pCviIGpFqzJmKh19p4fDOVB8JKl1QWT05kd5wq0

Links

• Issue in Gitlab's issue tracker: https://gitlab.com/gitlab-org/gitlab/-/issues/216587
• Issue in PlantUMLs Forum: https://forum.plantuml.net/11432/the-plugin-you-are-using-seems-generate-private-gitlab-server?show=11433#a11433

Let my old email domain expire without updating the rubygems.org account with my new email and now I cannot update the this gem.

This issue is to prove that I own and maintain this repo and the asciidoctor-plantuml gem in it.