Comments (4)
With version 1.7.0, VIGRA changed the meaning from angles from counter-clockwise to clockwise, which was an incompatible change that might break end user applications. Before switsching to a newer version of VIGRA, we must thus first find all instances where angles are passed to VIGRA and invert their signs. Or we just ignore this and let and users scratch their heads.
from gamera-4.
I have to admit that I am neither familiar with Gamera nor VIGRA in enough detail to comment on which approach should be preferred here. In general I prefer not to bundle external sources wherever possible, as these usually are out-of-date.
Judging from your description, the easiest approach would be to perform the replacements from the upstream PR in our bundled copy? With this we avoid the hassle of dealing with the incompatible angle behaviour for now, leaving this for a possible upgrade later on.
from gamera-4.
Yes, merging these changes into the copy of VIGRA 1.6 and documenting this in a README of the bundled copy would be an option. OTOH, if it's only a wraning and no error, I do nt think that it is worth the trouble.
The reason for bundling some libraries with Gamera is to make it easier to compile on non-Linux platforms.
from gamera-4.
Fixing these warnings actually turned out to be rather straightforward, as this affects less than 10 lines. I will send a PR for this as soon as I have isolated the corresponding changes from my latest tests.
from gamera-4.
Related Issues (20)
- A forum needed? HOT 1
- to_pil/from_pil not reliable HOT 4
- A typo HOT 1
- Python 3.10 build fails: incompatible type for argument 1 of '_Py_HashDouble' HOT 1
- Re-enable CI HOT 3
- Uses deprecated PyObject_CheckReadBuffer and PyObject_AsReadBuffer HOT 2
- When I browse this new commit meaningful pictures are replaced by empty pictures? HOT 5
- test_rle.py::test_rle1 Fatal Python error: Segmentation fault HOT 3
- image.to_grey16() outputs fully black images HOT 2
- 🐞 cknn.group_and_update_list_automatic Assertion error when used for NonInteractive classifier HOT 7
- Deprecation of distutils HOT 5
- Python 3.11 compatibility HOT 8
- Description set to build hint? HOT 2
- Tests break with pytest 7.2.0
- SetuptoolsDeprecationWarning: Installing as data is deprecated HOT 2
- Publish on PyPI? HOT 6
- Unable to save glyphs into separate files HOT 4
- knnmodule.hpp: Type Error raised when id is a string HOT 5
- Harmonization of license statements HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gamera-4.