knnmodule.hpp: Type Error raised when id is a string about gamera-4

[cdalitz]

Thanks for pointing this out. In python2, the id was of type string which no longer exists in python3 and can be replaced with either Unicode or Bytes. Apparently during porting Gamera to python3, the decision was made to use Bytes for the id. I have just noted that this causes other problems, too, e.g. when calling id.startswith with a plain string.

Where did you add your workaround of converting the id to a Bytes object? In your copy of teh gamera code? In your application code?

If you can provide a simple test script and simple test data that causes the problem, this would be helpful.

[malajvan]

We did the fix on our own fork, gamera4-rodan on the branch fix_IC. The fix is in the file knnmodule.hpp under this commit.
The error came from our Interactive Classifier python app which calls classify_glyph_automatic in classify.py in gamera4. You can see more of the issue here
I'll try to write a simple test case.

[cdalitz]

Did you mange to create a small test case that reproduces the error? I think it would be best to change the id to be Unicode instead of Bytes, but I would need a test case that reproduces the bug and check whether it actually goes away when the changes are made.

[malajvan]

I have trouble building and testing gamera on my local environment so creating a test script is a bit difficult at the moment. We did experience some issue with another job that uses the same function image_get_id_name where it is in fact passing in a byte object (that's mean gamera is passing in bytes sometimes and string at other). We got around the issue with an if else to check if the passed in names are string or bytes then convert accordingly.

[FriedrichFroebel]

I have trouble building and testing gamera on my local environment so creating a test script is a bit difficult at the moment.

Are there any details on your issues? Maybe there is some guidance available on this.