hubblecommerce / hubble-frontend-pwa Goto Github PK

Describe the bug
Unused theme folder can be removed.

Versions
hubble: 1.1.7
nuxt: v2.14.6
node: 12.16.3

Steps to Reproduce
The folder can be found inside the module folder: /hubble/core/assets/scss/hubbleplus

Is your feature request related to a problem? Please describe.
Contains unused and commented out code.

Describe the solution you'd like
Deleted unused code.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display context via v-text instead of v-html and should not contain commented out code.

Describe the solution you'd like
Replace v-html with v-text in html tags and delete commented out code.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display content via v-text instead of v-html and should not contain commented out code. The 2 divs in the div with the class category-description are redundant since both would display the same content in any case.

Describe the solution you'd like
Replace v-html with v-text and delete commented out code.
Shortening the code by deleting the 2 divs under the div with the class category-description and moving their v-text into the parent.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should import components dynamically.

Describe the solution you'd like
Add dynamic imports.
Refactoring related .scss-files.

Is your feature request related to a problem? Please describe.
s declared in the hubble coding guidelines, a component should import components dynamically and should not contain redundant code.

Describe the solution you'd like
Added dynamic import and deleted unused classes in styles.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should import components dynamically.
Furthermore Add-to-wishlist-button was not shown in desktop-view.

Describe the solution you'd like
Added dynamic imports of components.

Added wishlist-button to desktop-view and adjusted position.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should import components dynamically, use selfclosing tags and display content with v-text.

Describe the solution you'd like
Added v-text and selfclosing tags and imported component dynamically.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, components should import other components dynamically and should use self closing tags when possible.

Describe the solution you'd like
Change Loader component to import dynamically and change span tag to self closing.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display images via img-lazy tag which should have width and height attributes when possible and import components dynamically.

Describe the solution you'd like
Changing all occurrences of img to img-lazy. Changing import of the Newsletter component to dynamic import.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display images via img-lazy tag, not with img tag.

Describe the solution you'd like
Changing all occurrences of img to img-lazy.

Is your feature request related to a problem? Please describe.
Incorrect position/display of qty-selector.

Describe the solution you'd like
Adjusting .scss-files for correct display.

Is your feature request related to a problem? Please describe.
Reset Wishlist called error due to an unknown action.
Vue components should also be imported dynamically if possible and display content via v-text.

Describe the solution you'd like
Adjusted path to missing action, deleted empty class and added v-text.

Describe the bug
Decreasing and increasing browser window/screensize cause display of multiple product-pictures.

Versions
hubble: 1.1.7
nuxt: 2.14.6
node: 10.20.0

Steps to Reproduce

1. Go to Product-Details (Click on any product)
2. Decrease browser window or change screensize via device tool to e.g. tablet-size (at least width: 1023px).
3. Increase screensize back to desktop-size.
4. See error in the form of two product-pictures.

Expected behavior
No change of the amount of pictures shown.

Current behavior
Each repetition of changing the screensize creates another product-picture.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display content via v-text, use selfclosing tags if possible. Should have it's own .scss-file.

Describe the solution you'd like
Added v-text and selfclosing tags and created .scss-file.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a component should use self closing tags when possible and should have its own scss file with the same name.

Describe the solution you'd like
Change tags to be self closing, create scss file with the same name.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should contain english code.

Describe the solution you'd like
Exchanged german text with english.

Is your feature request related to a problem? Please describe.
Button Icon (shopping-bag) jumps up and out of center after clicking.

Describe the solution you'd like
Hiding loader-ellipse in small button.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a component should display content via v-text.

Furthermore summary conainer is not displayed properly in mobile view.

Describe the solution you'd like
Added v-text.
Fixed container-display in mobile-view.

Is your feature request related to a problem? Please describe.
Under the aspects of the Vue.js coding guidelines:
As declared in the hubble coding guidelines, a Vue component should import other components / plugins / modules dynamically if possible, display context via v-text instead of v-html and use selfclosing tags if possible

Describe the solution you'd like
Therefore to standardize the CartItemList component exchange current imports with dynamic imports where possible, change v-html to v-text and add selfclosing tags.

Describe the bug
When accessing sites with pagination the terminal shows warnings that 'Previous' is not a string or function. The reason for that is the change to a translatable string in an previous issue and not changing 'Previous' to 'Previous Page' when refactoring the component.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should import components dynamically if possible.

Describe the solution you'd like
Imported components dynamically.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, components should not contain commented out code and should import components dynamically.

Describe the solution you'd like
Delete commented out code and import components dynamically.

Describe the bug
When opening an Off-Canvas-Element the main scrollbar disappears and the content resizes in width, so the content appears to jump.

Versions
hubble: 1.1.6
nuxt: 2.14.5
node: 12.12.0

Steps to Reproduce

1. Open OffCanvas (e.g.: Wishlist)
2. Content gets resized

Expected behavior
The width of the content should stay the same so that the content does not appear to resize for the user.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a component should display content via v-text and use selfclosing tags and display img using img-lazy.

Describe the solution you'd like
Added v-text, selfclosing tags and img-lazy-tag.

Is your feature request related to a problem? Please describe.
Missing "filled-heart"-icon in set causing empty remove-from-wishlist-button.

Describe the solution you'd like
Switched Icon-set files to add icon-heart-filled to icon-set.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, the site has to have a valid HTML Markup including alt tags on images, since 2 images have an alt-tag but not the alt-info tag that is required by the img-lazy component, the div that contains the image gets the alt tag and not the image itself.

Describe the solution you'd like
Changing of the alt tags to alt-info and add the title-info tag.

Describe the bug
Search without any result and failing API request.

API Type
sw

Versions
hubble: 1.1.7
nuxt: 2.14.6
node: 10.20.0

Steps to Reproduce

1. Click on Search input field
2. type in any product title
3. See not result after search
4. press enter
5. see error

Expected behavior
Searching, finding and listing products.

Current behavior
Finding no results and causing API request fail.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should import other components / plugins / modules dynamically if possible. Therefore to standardize the ViewCategory component exchange current imports with dynamic imports where possible.

Describe the solution you'd like
Add conditionally used components as dynamic imports similar to other conditional imports for

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display content via v-text instead of v-html, should not contain commented out code and should use nuxt-link for internal navigation.

Describe the solution you'd like
Replace v-html with v-text, delete commented out code and replace anchor tag with nuxt-link.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should use selfclosing tags and display content via v-text.

Describe the solution you'd like
Added v-text and selfclosing tags.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, images should be displayed with img-lazy whenever possible, should use v-text instead of v-html when displaying text and should have a scss file with the same name. Getting the link for the logo image source through a method called by the mounted lifecycle hook ist unnecessary and can be directly put in the src prop of img-lazy. The div surrounding img-lazy currently checks if the manufacturer_item exists which makes no sense since the else-if afterwards checks for the same thing, therefore the first v-if should instead check if an manufacturer image exists and displays it when it does.

Describe the solution you'd like
Change img tag to img-lazy , change v-html to v-text, create scss file with the same name, put dataProduct.manufacturer_item.logo directly in img-lazy src prop and change first v-if to check for dataProduct.manufacturer_item.logo.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a component should use self closing tags when possible and should have its own scss file with the same name.

Describe the solution you'd like
Change tags to be self closing, create scss file with the same name.

Is your feature request related to a problem? Please describe.
Tabs.vue contains redundant code, the methods selectTab and selectTabInitial are the same with only minor differences.

Describe the solution you'd like
Refactoring of selectTab so it can replace selectTabInitial on startup, so that selectTabInitial can be removed.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, static text should only be included translatable and tags should be self closing when possible.

Describe the solution you'd like
Change span tags to self closing and static text to translatable text by creating entries in locales for english and german.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display content via v-text instead of v-html.

Describe the solution you'd like
Replace v-html with v-text.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display content via v-text and import components dynamically.

Describe the solution you'd like
Added v-text and imported component dynamically.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, Vue components should display text via v-text.
Furthermore it should have it's own scss-file.

Describe the solution you'd like
Added v-text.
Refactoring scss-files: view-product.scss, product-detail-price.scss.

Additional context
Deleted deprecated version of vue-component.
Deleted unnecessary class.

Is your feature request related to a problem? Please describe.
LanguageSwitch is not implemented yet.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should use img-lazy-tag instead of img and v-text instead of v-html.
Furthermore it shouldn't contain commented out code.

Describe the solution you'd like
Changed v-html to v-text and img to img-lazy and adjusted alt-info/title-info.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display content via v-text instead of v-html. The 2 div under the "Add to cart" comment is displayed through v-if with mediaqueries, one for small and one for medium and large screens. Deleting the first div and the v-if on the second div does not change change appearance on mobile, therefore shortening the template code and avoiding repetition.

Describe the solution you'd like
Replace v-html with v-text and delete commented out code.
Shortening the code by deleting the media queries and the first div under the "Add to cart" comment.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display context via v-text and be selfclosing. Therefore to standardize the Cookienotice component the template need to change.

Describe the solution you'd like
Add selfclosing tag to template parts where necessary.

Is your feature request related to a problem? Please describe.
Under the aspects of the Vue.js coding guidelines:
As declared in the hubble coding guidelines, a Vue component should display context via v-text and use selfclosing tags if possible.

Describe the solution you'd like
Added context as v-text and selfclosing-tags.

hubble theme needs a rework for the sake of usability and new features.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a component should use self closing tags when possible and should have its own scss file with the same name.

Describe the solution you'd like
Change tags to be self closing, create scss file with the same name.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a component should use self closing tags when possible. since 2 img tags with v-if, that are displayed when the isSlider prop is either true or false, are essentially the same, except the first tag got an css class, it can be refactored to only one img tag with only the class being conditionally added when isSlider is false.

Describe the solution you'd like
Change tags to be self closing, delete the second img tag, remove v-if from the first tag and make the class change in dependecy with the isSlider prop.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a Vue component should display context via v-text and be selfclosing, should display static text only through locales. Since NewsletterForm.vue is used only once in another component it does not need its props since they don't provide any specific dynamic information, they only consist of headlines which could easily be static strings in the component itself. The prop slogan is never used and can be deleted with its corresponding h2 tag.

Describe the solution you'd like
Change tags to self closing whenever possible, change static text to be translatable and make corresponding changes in locales, delete props and change its uses to static text, delete h2 tag of unused prop slogan and change scss accordingly, change newsletter-form tag in wishlist to not include props.

Is your feature request related to a problem? Please describe.
As declared in the hubble coding guidelines, a component should display content via v-text, use selfclosing tags and import components dynamically.

Describe the solution you'd like
Added v-text and dynamic import.

Describe the bug
With a contributor setup as described in https://docs.hubblecommerce.io/pwa/contribution/contributionpwa.html, there are no changes applied when editing files in /modules.

Versions
hubble: 1.1.6
nuxt: 2.14.6
node: 10.20.1

Steps to Reproduce

1. Setup hubble via contribution guide
2. Start app in dev mode
3. Change file in /modules/hubble-frontend-pwa/@hubblecommerce/core
4. Nothing happened to file watcher

Expected behavior
The watcher should recognize a file change and copy the changed file to .hubble so nuxt can show the change in the frontend.

Current behavior
On file change, nothing happens.

Is your feature request related to a problem? Please describe.
Under the aspects of the Vue.js coding guidelines:
As declared in the hubble coding guidelines, a Vue component should display context via v-text and use selfclosing tags if possible.

Describe the solution you'd like
Added context as v-text and selfclosing tags.