hubject / opcp Goto Github PK

Hi there,
I think I've found a mistake in the document OPCP-1.0.0/docs/02_PnC_business-processes.md

Suggestion:

- The Provisioning Certificate with the regarding PCID must be sent by the MO to the PCP beforehand.
+ The MO can retrieve the Provisioning Certificate from the PCP with the supplied PCID. This Provisioning Certificate must've been sent by the OEM to the PCP beforehand.

Reason for change: From my understanding I would assume that the MO cannot send the Provisioning Certificate "beforehand". From the API as described in OPCP-1.0.0/docs/components/02_provisioning-certificate-pool.md the MO only "reads" data from the PCP and would use /v1/oem/provCerts/{pcid} (Get Provisioning Certificate).

If it is OK with you, I can create Pull Requests instead of issues to make these suggestions easier to implement on your side.
Nevermind, already created one.

Hi,

I think there's an issue on a json file ./OPCP-1.0.0/reference/ccp.v1.json
The schema reference "#/components/schemas/ContractCertificate" is not defined the json file.

"put": { "summary": "Add Signed Contract Data to CCP", "operationId": "addSignedContractData", "responses": { "201": { "description": "Created", "content": { "application/json": { "schema": { "$ref": "#/components/schemas/ContractCertificate" } } } },

The document https://github.com/hubject/opcp/blob/main/OPCP-1.0.0/docs/05_handling-of-ids.md describes the handling of Ids in the e-mobility space. Ids can have optional elements like - or *, but it is not specified how to compare two identifiers for equality, when they have different optional elements. E.g. is "DE*GEF" the same as "DEGEF"? I would say yes.

All this has an implication on the implementation of ids, as it would be better not to implement them just as a string, but as a complex data structure having special comparison methods.

Hello! I'm interested of OPCP.

Where I can found information about CertificateUpdate in ISO15118?

Accoding to ccp.v1, There is CertificateInstallation EXI Response API but CertificateUpdate EXI seems not.

Hey, You guys made some references like " models/signed-contract-data.v1.json"
Which are nowhere in the repo. Would you guys be able to provide a link to these?
Thank you,