hugobyte / aurras Goto Github PK

Description

The deploy script for the individual actions have code duplicates

Suggestion

Refactor the scripts to source out commonly used methods

Description

Deploy script forces the actions to be built even if it has been build before.

Suggestion

Add flag --build which defaults to name of the actions separated by commas, --skip which accepts the name of the actions separated by commas which would skip executing deploy script of the provided actions and prevent removing previous builds

Example

Scenario 1: Deploy all actions with previous builds
command: ./deploy.sh --build none

Scenario 2: Build only a certain action and rest actions to use previous builds
command: ./deploy.sh --build "balance-filter"

Scenario 3: Build only certain actions and rest actions to use previous builds
command: ./deploy.sh --build "balance-filter,push-notification"

Scenario 4: Skip building and deploying certain actions
command: ./deploy.sh --skip "balance-filter,push-notification"

Scenario 5: Build only certain actions and Skip certain actions to be build and deployed
command: ./deploy.sh --build "balance-filter,push-notification" --skip "event-registration"

Description

Information on how to get TEST_DEVICE_TOKEN missing hence not able to test using cargo test --all-features

Suggestion

Add instruction to point the user to the integration test document and screenshot where to get the token

In the Config YAML for the workflow, user can't give the custom datatype

Description

Derive macros to enable the tasks in a workflow to invoke OpenWhisk actions and triggers. The tasks are structs, based on a generic format that would include name, inputs and endpoints and macros add functionalities for the tasks

Description
Integration Document missing in repo

Suggestion
Convert Existing integration document to md and add to repo

Create rust runtime for wasm

Description

Create macro for workflow composer to handle three types of flows

• Init
• Pipe
• Term

Flow macro will handle three different types of flows to run the underlying tasks

Description

The missing tutorial create confusion on users how to use the Substrate Push Notification Example

Suggestion

Add a tutorial including screenshots for different stages

Description

On deploying actions using the deploy.sh, It is failing with:
error: Invalid argument(s). Unable to get action 'push-notification': The connection failed, or timed out. (HTTP status code 502)

Openwhisk Deployment Mode: Docker Compose

Description
Architecture Missing

Suggestion
Add Architecture Diagram and Add Aurras component description

Description

Docker file for running the workflow composer.
Users can utilise the docker image as a cli tool to generate workflow wasm from the provided yaml

Description
Avoid having compiled binaries in the source.

Suggestion
Remove Openwhisk CLI binary from the source and specify link to get the binary in documentation and make changes to deploy.sh to get the binary from path