hunterae / dumpable Goto Github PK

Summary

belongs_to asscociation does not work for me. I have redefined foreign_key.

Reproduce

rails ~> 5.2
pg ~> 0.21.0

# app/models/example_category.rb
class ExampleCategory < ApplicationRecord
  has_many :examples
end

# app/models/example.rb
class Example < ApplicationRecord
  belongs_to :category, class_name: 'ExampleCategory', foreign_key: :example_category_id
end

Example.reflect_on_association(:category).association_foreign_key # => 'category_id'
Example.reflect_on_association(:category).foreign_key # => example_category_id

This callout breaks getting of association data:

I tested this with Ruby 2.4.3 and Rails 5.2.0.

When running dumpable with the following command:
Dumpable.dump(Model, Model, ..., :file => "#{Rails.root.join('db', 'dump.sql')}")

A Datetime column is exported as follows:

2018-05-15 16:54:54 UTC

However the " UTC" is not allowed when importing back into Mysql.

Please consider the following fix within Dumpable::Dumper
Line 81:

      case value.class.to_s
      when "Time"
        "'#{value.strftime("%Y-%m-%d %H:%M:%S")}'"
      when 'ActiveSupport::TimeWithZone'
        "'#{value.strftime("%Y-%m-%d %H:%M:%S")}'"

And what's rarely an issue but still, quote the table name: table_name = ActiveRecord::Base.connection.quote_table_name(object.class.table_name)

This also increases support for other databases.