hypo-sh / emissary Goto Github PK

Write tests describing what happens whenever a get or post request fails in core.

See:

• https://openid.net/specs/openid-connect-core-1_0.html

• 3.1.2.1
• 3.1.2.5
• 3.1.2.6

Pay particular attention to make-handle-logout and make-handle-oidc.

• Make session read and write configurable (:emissary/session-id)
• Think about the relationship between db and session storage and how various users may want to configure that

https://openid.net/specs/openid-connect-core-1_0.html#TokenErrorResponse

Instead, use remote config to populate the parts of emissary config necessary for emissary to work. Perform validation after remote config has been fetched.

Currently the UI assumes that the name of the default remote is origin, but that isn't always the case. Think about how to make this configurable, etc.

The goal here being to make it harder to accidentally leak secret config information to the browser. Currently there is no sensitive data in the config map, but there may be in the future.

https://openid.net/specs/openid-connect-core-1_0.html#AuthResponseValidation
In particular, see https://datatracker.ietf.org/doc/html/rfc6749#section-10.12

We already do this for id-token.

• Update test 3.1.3.7.11

https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation

• https://openid.net/specs/openid-connect-core-1_0.html
• Update 3.1.3.7.12

https://openid.net/specs/openid-connect-core-1_0.html#AuthError

When auth errors occur, the error payload documented above will be passed to make-authentication-redirect-handler as part of req. This should take less than an hour to implement.

in core tests, we pass in a save-session! function. We should replace that function with a mock and assert that it is called with appropriate arguments every time it is invoked.

Context:
https://openid.net/specs/openid-connect-core-1_0.html#Security%Considerations

Where possible, write specs for considerations