ialexeyprokhorov / baroque.novaposhta.client

📦🚚Most full 'Nova Poshta' delivery service API client .NET Core Apps

Hi there 👋

I'm is Ukraininan .NET developer. My favorite stuff:

• SQL databases 😄;
• .NET Framework and .NET Core development 😁;
• JS and jQuery sometimes 😑;

⌨ Currently I working with some new K2 smartform controls and 'Nova Poshta' API client 😀.

🤔 I’m looking for help with bug detecting in all my software. Nobody writes me about issues, so I still think that I write best soft in the world😅 (no 🤨). So please feel free to write about founded bugs in my projects issues or discussions😉.

baroque.novaposhta.client's Issues

WarehousesGetRequest - missing field WarehouseId and Limit

Documentation.

Missing fields:

    [DataMember]
    public string? WarehouseId { get; set; }
    [DataMember]
    public int? Limit { get; set; }

Also field Page is missing [DataMember] attribute, so it is not being serialized.

CreateDocumentRequest missing fields

As per documentation creation of parcel on poshtomat is not possible (It requires OptionSeat field).

The following fields are missing from CreateDocumentRequest (I solved it by creating subclass):

    [DataContract]
    private class ExtendedCreateDocumentRequest : CreateDocumentRequest
    {
        [DataMember]
        public Guid CityRecipient { get; set; }

        [DataMember]
        public Guid Recipient { get; set; }

        [DataMember]
        public Guid ContactRecipient { get; set; }

        [DataMember]
        public Guid RecipientAddress { get; set; }

        [DataMember]
        public OptionsSeat[]? OptionsSeat { get; set; }
    }

[DataContract]
public class OptionsSeat
{
    [DataMember(Name = "volumetricVolume")]
    public decimal VolumetricVolume { get; set; }
    [DataMember(Name = "volumetricWidth")]
    public decimal VolumetricWidth { get; set; }
    [DataMember(Name = "volumetricLength")]
    public decimal VolumetricLength { get; set; }
    [DataMember(Name = "volumetricHeight")]
    public decimal VolumetricHeight { get; set; }
    [DataMember(Name = "weight")]
    public decimal Weight { get; set; }
}