Issues with pnpm about esmock

[PatrickHeneise]

Thanks for the support! I'll try to run it later or tomorrow again with experimental mode and the full path, see what works.

[iambumblehead]

@PatrickHeneise thanks and regards hoping everything is good for you this holiday season. Feel free to re-open or message any time

[iambumblehead]

Related PnP-compatibility changes were made for this issue #176

@koshic do you know of a solution for using esmock with PnP? It seems to still not be working. @koshic @PatrickHeneise esmock could be updated with changes you might recommend for resolving this issue

[koshic]

@iambumblehead pnpm and yarn PnP are very different things )

I can answer about PnP only:

1. yarn unplug esmock to place it somewhere inside .yarn/unplugged dir
2. yarn node --loader $(yarn node --input-type=module -e 'console.log((await import("module")).default.findPnpApi(".").resolveRequest("esmock", ${process.cwd()}/dummy.js, { conditions: new Set(["import"]) }))')

Sure, we can create simple wrapper for second step - do the same to get esmock path, dynamically import esmock and export load + resolve hooks (my reason why I requested changes in 'is esmock loaded?' fn).

[iambumblehead]

@koshic ah I see pnpm is a different thing!

@PatrickHeneise which moduleId is not found? Would you share the full message? If you use esmock with --experimental-import-meta-resolve do your tests run correctly?

[iambumblehead]

@PatrickHeneise would you try esmock using the full path to the module for which moduleId is not found? For example, if the '@google-cloud/secret-manager' moduleId is not found, try something like,

  const { fetchVariable } = await esmock('../lib/fetchVariable.js', {
-    '@google-cloud/secret-manager': {
+    '/full/path/to/node_modules/@google-cloud/secret-manager': {
       // ...
    }
  })

another way...

  const { fetchVariable } = await esmock('../lib/fetchVariable.js', {
-    '@google-cloud/secret-manager': {
+    [new URL('@google-cloud/secret-manager', import.meta.url)]: {
       // ...
    }
  })

[iambumblehead]

@PatrickHeneise also feel free to submit a failing test and I will merge and try to resolve per https://github.com/iambumblehead/esmock/blob/master/CONTRIBUTING.md

[PatrickHeneise]

tomorrow ... closing this as I don't have capacity at the moment. Will run the test when I get back to this project. Thanks though!