GithubHelp home page GithubHelp logo

haskell-spanish-conjugation's People

Contributors

iamfromspace avatar

Watchers

 avatar  avatar

haskell-spanish-conjugation's Issues

Parse H in Core/Nucleus

The core/nucleus can have 'h's between semi-vowels, that have absolutely no impact on the mechanics of the core/nucleus--just the spelling.

The only way to know if we should add a 'h' to the spelling, is of course to parse it and store it in the Core, which complicates an already complicated structure. Probably each semi-vowel needs to be a Maybe (HighVowel, Bool) where the Bool represents if an 'h' exists.

This also complicates the parser, as H will be valid in both the Core and a consonant cluster.

Unit testing was a must before this, and a bunch of other words should be added to verify this behavior.

Bug: Words starting with "ll" do not parse (ex. llevar)

This is troublesome, because it complicates rules for Onsets. Onset didn't allow a double "ll" to force the two 'l's to split between the Coda + Onset, which eliminated a bunch of illegal clusters with a bunch of random "ll"s all over the place. This will need some thinking on a good solve that doesn't shake everything up (like re-defining Onset would).

Update Deck instead of Build from Scratch

Each time a new deck is built, all previous data about usage is lost, which is a bummer. If instead cards were update and only insert if new, that would save usage data.

Improve Parser/Render Property Testing via Generation

Only a very small subset of strings are valid Spanish words, so very few will be worth our time to test. Instead, we should be generating strings that are likely to be parse-able, while still making sure that parse-able words are a subset of our generated words (every parse-able word could be generated).

Vowels can repeat indefinitely, including accents and ΓΌ (though the latter should often fail to parse). While consonant groups could never be longer than 4 characters in the middle of a word, and no longer than two at the beginning or the end. Something like /consonant{0,2}(vowel+consonant{1,4})*consonant{0,2}/ as a pseudo regex, should be a super set of parse-able words without too much waste.

Conjugate Imperative

The positive and negative Tu can be different, which is useful to learn. New images would be needed.

Handle Compound Tenses

These were less practically useful when implemented in the JS version, but should be done eventually none the less.

Improve Parser/Render Property Testing via Discard

By making random strings for the property testing, many will be invalid. Currently for those, they're just counted as passes, but that means that the property is considered a pass without probably every hitting any valid parses.

QuickCheck has the (==>) operator, which means discard the following property if the previous predicate is false. This would help QuickCheck ignore results that aren't actually meaningful.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.