GithubHelp home page GithubHelp logo

androidarchitecture's People

Contributors

christxph avatar iammert avatar johnjeremih avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

androidarchitecture's Issues

App Crash

Hello can help me with this error, i can't run it, my Android Studio version is 3.0.0 Canary 6

capture

FATAL EXCEPTION in MovieRepository

FATAL EXCEPTION: AsyncTask #1 Process: iammert.com.androidarchitecture, PID: 7318 java.lang.RuntimeException: An error occurred while executing doInBackground() at android.os.AsyncTask$3.done(AsyncTask.java:325) at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354) at java.util.concurrent.FutureTask.setException(FutureTask.java:223) at java.util.concurrent.FutureTask.run(FutureTask.java:242) at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607) at java.lang.Thread.run(Thread.java:761) Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.List iammert.com.androidarchitecture.data.remote.model.MoviesResponse.getResults()' on a null object reference at iammert.com.androidarchitecture.data.MovieRepository$1.saveCallResult(MovieRepository.java:36) at iammert.com.androidarchitecture.data.MovieRepository$1.saveCallResult(MovieRepository.java:32) at iammert.com.androidarchitecture.data.NetworkBoundResource$2.doInBackground(NetworkBoundResource.java:71) at iammert.com.androidarchitecture.data.NetworkBoundResource$2.doInBackground(NetworkBoundResource.java:67)

[QUESTION] Debugging Api response

Thanks for this repo, but I'm migrating from asynctask to this project and sincerely, is like start from 0.

My question is: How can I debug the Api response?

In my last project I can stop in the moment when the Api response, so I could see the header of the response if it was a 200 response or 404. Then I could see the json of the Api response, etc...

Using this repo I can't see anything of this, for example, I changed the url repo and also I changed the model, and I don't know if the data received is ok and if the model is filled with the response.

Anybody can help me solving my problem?

Thanks!

ViewModel injection

In MovieListFragment I see the following ViewModel injection, however I don't see where you're providing this dependency in any module. How are you injecting this?

@Inject
MovieListViewModel movieListViewModel;

Android authenticator API

First, thanks for such a good work!!

I've a question for you, i don't know whether it's a feature request, suggestion or else. The API you're querying is protected by Tokens. In your application, your Token is hardcoded. What happens if your application needs the user to log in?

The token issue complicates and is a real world use case. Some people try to store tokens within SharedPreferences, but I don't think it's a good idea. I'm tackling it by using Android Accounts and Authenticator API. This is a good practice to manage accounts and tokens, since it provides mechanisms to update tokens in different situations.

It'd be nice that you could provide any example, in this project or in another. I understand this one is solely aimed to explaining the usage of MVVM arch.

Thank you again!

App getting force closed

05-31 15:38:50.877 24942-25015/iammert.com.androidarchitecture E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #1
Process: iammert.com.androidarchitecture, PID: 24942
java.lang.RuntimeException: An error occured while executing doInBackground()
at android.os.AsyncTask$3.done(AsyncTask.java:304)
at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:355)
at java.util.concurrent.FutureTask.setException(FutureTask.java:222)
at java.util.concurrent.FutureTask.run(FutureTask.java:242)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.List iammert.com.androidarchitecture.data.remote.model.MoviesResponse.getResults()' on a null object reference
at iammert.com.androidarchitecture.data.MovieRepository$1.saveCallResult(MovieRepository.java:36)
at iammert.com.androidarchitecture.data.MovieRepository$1.saveCallResult(MovieRepository.java:32)
at iammert.com.androidarchitecture.data.NetworkBoundResource$2.doInBackground(NetworkBoundResource.java:71)
at iammert.com.androidarchitecture.data.NetworkBoundResource$2.doInBackground(NetworkBoundResource.java:67)
at android.os.AsyncTask$2.call(AsyncTask.java:292)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231) 
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) 
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) 
at java.lang.Thread.run(Thread.java:818) 

Where's ActivityMainBinding?

I reached a class it makes use of some ActivityMainBinding that is supposed to be located in the packate databinding, but I see nothing there...

some issues

theres some issues, one of them is theres no

drawable/ic_stars_green_24dp
drawable/ic_language_green_24dp

I had to get rid off it from mark up

Dependency Injetion issue

I have implement your app architecture model in my app ,

Building the app I got below issue in AppComponent class
@component.builder is missing setters for required modules or components:

I have compare all code , but didn't find to resolve the issue . help me to find the error . Thanks ..

hello, How do you pass an activity into a MovieRepository?

for example:
I need to use activity in MovieRepository ,so how can I inject activity to MovieRepository?

@Inject
public MovieRepository(MovieDetailActivity movieDetailActivity,MovieDao movieDao, MovieDBService movieDBService) {
this.movieDao = movieDao;
this.movieDBService = movieDBService;
}

can you write a example in the project ? thinks

Drawables are missing in the commit

In the layout activity_movie_detail.xml,
android:src="@drawable/ic_language_green_24dp" android:src="@drawable/ic_stars_green_24dp"

are missing

Getting Null Reponse If I Use Reponse Call

Hi mertsimsek. I am just following this example. i have create a app to get user detail from github service.
I have added everything that you added in di,data, packages. but i was getting null response from the retrofit. this is my repo link my-mvvm-sample check it and let me know where i was wrong.

Thanks in advance

Dependencies outdated

I have a pull request that will update all the dependencies and all the deprecated methods

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.