Some suggestions after review about phpserver

[ibazzi]

Just fixed the issue.

[ibazzi]

• for PHP executable and php.ini, i will let user to choose the location of executable and ini file.
• You can double click the added server to open the server overview editor to edit the default port and the server document root
• for serverTypes extension point, it seems we can only define one runtime type for one serverType.

[mniewrzal]

for PHP executable and php.ini, i will let user to choose the location of executable and ini file.

Thanks.

You can double click the added server to open the server overview editor to edit the default port and the server document root

Ah yes, great :)

for serverTypes extension point, it seems we can only define one runtime type for one serverType.

I understand.

[ibazzi]

Hi @mniewrzal

71f1264 provided a combo box to select the installed executables in PHP Executables preference page.

Please have a try.

[mniewrzal]

I was able to create server by choosing installed executable but most of the time I have such exception and it blocks launching server:

!ENTRY org.eclipse.php.server.core 4 0 2017-03-22 17:41:32.933
!MESSAGE Could not load the Tomcat server configuration at /Servers/PHP 5.5 Built-in Server at localhost-config. The configuration may be corrupt or incomplete.
!STACK 1
org.eclipse.core.internal.resources.ResourceException: Resource '/Servers/PHP 5.5 Built-in Server at localhost-config/server.xml' does not exist.
	at org.eclipse.core.internal.resources.Resource.checkExists(Resource.java:335)
	at org.eclipse.core.internal.resources.Resource.checkAccessible(Resource.java:209)
	at org.eclipse.core.internal.resources.File.getContents(File.java:275)
	at org.eclipse.core.internal.resources.File.getContents(File.java:268)
	at org.eclipse.php.builtin.server.core.internal.DefaultPHPServerConfiguration.load(DefaultPHPServerConfiguration.java:174)
	at org.eclipse.php.builtin.server.core.internal.PHPServer.getPHPServerConfiguration(PHPServer.java:251)
	at org.eclipse.php.builtin.server.core.internal.PHPServerBehaviour.getPHPServerConfiguration(PHPServerBehaviour.java:329)
	at org.eclipse.php.builtin.server.core.internal.PHPServerBehaviour.publishServer(PHPServerBehaviour.java:417)
	at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:975)
	at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:774)
	at org.eclipse.wst.server.core.internal.Server.publishImpl(Server.java:3172)
	at org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:345)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
!SUBENTRY 1 org.eclipse.core.resources 4 368 2017-03-22 17:41:32.936
!MESSAGE Resource '/Servers/PHP 5.5 Built-in Server at localhost-config/server.xml' does not exist.

[ibazzi]

Basically it was because you did not set the ini file path of the executable.
When adding a php server, it will copy the ini file to "/Servers/PHP 5.5 Built-in Server at localhost-config" for users to do some configuration, and then start the server with it.

[mniewrzal]

Works nice right now :) I think its good enough to make a gerrit patch for this when you will be ready.

[ibazzi]

Great, I will push a patch after code cleanup.Is it ok to be merged into org.eclipse.php.server.core and ui?Or a new plugin?2017年3月23日 17:24，Michal Niewrzal <[email protected]>写道：Works nice right now :) I think its good enough to make a gerrit patch for this when you will be ready. —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

[mniewrzal]

I think integrating this feature into server.core/ui will be even better. No need to create separate plugins.

Remember to add headers for all java files. Here you will find example https://github.com/eclipse/pdt/blob/43999cd19e6955ea89e7c3c62e49a3474fba2799/plugins/org.eclipse.php.core/src/org/eclipse/php/core/project/ProjectOptions.java#L1-L12

Good Luck! :)

[ibazzi]

Bad news.

"A cycle was detected in the build path" error occurred.

org.eclipse.php.debug.core and org.eclipse.php.server.core referencing each other.

I just set the Circular dependencies to warning for now. Any solutions?

[mniewrzal]

I will take a look at this. Can you push change to your github pdt fork?

[ibazzi]

Pushed.

https://github.com/ibazzi/pdt/tree/phpserver

[mniewrzal]

Thanks. Unfortunately I don't see an easy solution for this issue right now. I wasn't aware there is such strong cycle between debug and server source code. For now please contribute it as separate plugins. Meanwhile, we will try to do something with this. We can move code to server plugins later when it will be merged with PDT master.

[ibazzi]

OK, I will push the patch this week