GithubHelp home page GithubHelp logo

add has("edge") flag for Edge about decor HOT 3 CLOSED

ibm-js avatar ibm-js commented on May 17, 2024
add has("edge") flag for Edge

from decor.

Comments (3)

wkeese avatar wkeese commented on May 17, 2024

Yes, of course, has("ie") returns undefined on all browsers except for IE. This is expected behavior.

Although Edge is forked from the IE code base it's technically a separate browser, with a new name. So in the same way that has("safari") returns false on Chrome, has("ie") returns false on Edge. Do you think it should be different?

We should though add a has("edge") flag.

PS: Also, like in dojo V1, need to make sure that has("chrome"), has("safari"), and has("webkit") return undefined on Edge. See dojo/dojo@ac05a45 although that change is incomplete because it forgot has("webkit").

from decor.

kgibb avatar kgibb commented on May 17, 2024

No the has("edge") flag should suffice.

from decor.

wkeese avatar wkeese commented on May 17, 2024

OK, I'll add has("edge") and make sure other flags (has("chrome"), has("safari"), has("webkit"), has("mozilla")) are false.

from decor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.