idlesign / deflacue Goto Github PK

Let's say i have source folder structure like:

• [Artist]
  -- [Album]
  --- Original recording
  ---- Flac and Cue file
  --- Remastered version
  -- [Album]
  -- [Album]

Now, what it does is grabbing that Original recording folder name (also as Remastered version name) and create folders in destination with that names. Well, i would expect it will keep (at least) the default folder structure and split those flac files.

Anyway, for the better understanding, the path looks like:
.../[Original recording]/[Artist]/[Album]/[Songs]

I would be thankful if there wasn't the [Original recording] as parent folder.

Good work anyway!

Deflacue will fail to split FLAC files when Album/Band names contain illegal characters on Windows.

In my case, the album name is titled: What I Have to Hide...

The code in the process_cue method creates an additional folder structure on top of the target path using the artist name, album name, and date. In my case, it attempts to create the following: [base_directory]\\Night of Suicide\\2006 - What I Have to Hide.... However, _create_target_path method used to create this folder uses os.makedirs, which has the brilliant behavior of silently pruning the three dots at the end, creating [base_directory]\\Night of Suicide\\2006 - What I Have to Hide instead. Subsequently, the reference to the target path is now incorrect and SoX will fail as it attempts to write to the directory with the 3 dots, which does not exist.

There exists a sanitize function in process_cue, which can be extended to remove illegal characters. Additionally/alternatively, it would be nice to have an optional flag to disable the entire prepending system and simply have deflacue output to the exact directory the user passes.

I can make a PR for either or both, let me know.

Hi
Seems no track number is being written to the output flac files..

Dave

Hi and first of all - thank you for this tool. It was a lifesaver when i've found out that PLEX doesn't support flac + cue audio format. The tools works great and it's a great that it creates a subfolder inside original folders to keep structure. Would be really great if it'a possible to add an additional flag which will tell that original FLAC should be deleted.