ido-barnea / chess-but-better

Chess But Better is chess, but with a few extra layers of complexity. Try playing the game at https://chess-but-better.onrender.com.

Hi 👋, I'm Ido

chess-but-better's Issues

Add chess notations around the board

Add chess notations (the letters and numbers signifying a piece's position) UI around the board.

Fix friendly fire not working

Highlight possible movement squares for pieces

When a piece is dragged, highlight all squares it can legally move to.

Inventory System Implementation

• #109
• Create initial logic for the inventory system.
• #108

Change board tiles from DIV to SVG

SVG have better performance and are cleaner to use.

Shopping System Implementation

• #112
• #113

Add dark/light theme support

Make UI responsive

It's about time we make the UI responsive.

King can castle with nothing when in heaven

Steps to reproduce:

1. Kill the king before it and the rook have moved.
2. Try to castle in heaven.

The king will castle even if the rook is not in the heaven board.

Always use piece class for board movement

Currently, the board is initialized like this:

var board = [
'r', 'b', 'n', 'q', 'k', 'n', 'b', 'r',
'p', 'p', 'p', 'p', 'p', 'p', 'p', 'p',
'', '', '', '', '', '', '', '',
'', '', '', '', '', '', '', '',
'', '', '', '', '', '', '', '',
'', '', '', '', '', '', '', '',
'P', 'P', 'P', 'P', 'P', 'P', 'P', 'P',
'R', 'B', 'N', 'Q', 'K', 'N', 'B', 'R',
]

The lower letters signify the color black and the capital letters signify the color white.
This should change to use the appropriate class for each piece.

Knight is in the wrong square.

In the chess board the knight should start next to the rook.

See here:
https://www.thechesswebsite.com/chess-pieces/

Change the boards' buttons' backgrounds to look like their respective boards

Requested Features

• Have each of the board buttons look like their respective boards.

Fix friendly fire not working

Add highlight of the last move

Please highlight the square from which they moved and the square it is now in.
For example:

1. If the white pawn moved from e7 to e6; you should highlight e7 and e6.
2. If the black queen moved from f4 to b4; you should highlight f4 and b4.

Please highlight the square from which a piece arrived in a darker color than the piece's destination square.

Add commit message checker in Github actions

see commit message checker.

Logic and UI seperation

The code will be more understandable if all the logic would be self contained and would not depend on UI functions and variables.

Pieces are undraggable after moving a lot

The pieces will think they changed color and won't move.

Steps to reproduce:

1. Move a lot with any piece (preferably the knight) at a fast speed.

Add castling logic

see Castling if you need to.

Create Checkin action

Pieces are randomly undraggable

There are no specific steps to reproduce the issue. If you move a piece for enough turns, it becomes undraggable.

Implement En passant logic

See wikipedia.

Create UI for logs

Logs are currently written using console.log() spread throughout the code.
Please add a UI element where logs are actively printed.

Fix Friendly Fire Bug (feature no longer working)

pieces unable to eat any other piece on their team except for themselves, in addition, after eating themselves their turn doesn't change to the opposite team but they gain a bonus turn for some reason?

Write documentation

• Create developer documentation.
  • How to set up the project.
  • Information about the project itself.
  • The tools we use.
  • etc.
• Create user documentation.
  • How the game works.
  • How it differs from the average chess game.
  • The secret rules.
  • The new pieces.
  • The boards
  • The items.
  • The gold and XP systems.
  • etc.

Pawns can't kill pawns of the same color

Steps to reproduce:

1. Try to kill a Pawn with another Pawn of the same color.

Note that the bug only applies to Pawns, not other pieces of the same color and type.

Add UI for secret rules.

The UI should show a list of revealed rules. When a new rule is revealed, it should also be added to the UI.

Hit box getting bigger

Steps to reproduce:

1. Place any piece anywhere and see that the hit box of the square is augmenting a bit.

Reference picture:

Add unit testing

• Create an action that runs unit tests.
• Create unit tests.

Color code the logs

Give each log type a different color. For example, normal movement logs could be gray, Secret Rules logs could be purple, kill logs could be red, etc.

Fix not being able to eat pieces sometimes on Firefox

For some reason, sometimes, when trying to eat a piece, the following error occurs:

Uncaught TypeError: _targetCoordinates is null
isValidMove file:///home/omoor/Downloads/Chess-But-Better-main/app.js:232
onDragDrop file:///home/omoor/Downloads/Chess-But-Better-main/app.js:158

The error seems to only occur on Firefox.

To reproduce:

1. white P moved from (3,6) to (3,4).
2. black p moved from (4,1) to (4,3).
3. black p was killed by white P. -> error occurs here.

Add new rules

Requested Rules

• Coup: When a player is in debt for three turns in a row, a random amount of his pieces defect to the enemy side (except for the King).
• The Other Side: When a piece falls off the board, there is a 50% chance that after three turns, it will spawn on a random square in a random board.
• Bounty: If a piece kills three enemy pieces in the Overworld Board, it receives a bounty. When that piece is killed, the killing player receives five gold pieces.

Add multiplayer

The game should have a multiplayer option.

Add format checker action workflow

Probably best to use npx nx format:check

Fix some pieces being able to eat themselves

It looks like Rooks, Bishops, and Queens can eat themselves. For now, this is unwanted behavior.

Upgrades Tree Implementation

This issue depends on #9.

Requested Features

• #116
• #117

Add dark/light theme support.

Create new boards

• Create heaven and hell boards.
• Create a functionality that determines where a piece goes when it is killed. If a piece didn't kill another piece, it goes to heaven. If it did, it goes to hell.
• Create buttons that switch between board views.
• Reveal new boards buttons as new boards are revealed to the player (i.e. if a piece goes to heaven, reveal heaven board button).
• Make sure that if a piece spawns on another piece, it captures it.

Create singular notations container instead of one per board

Currently, we have three elements for notations containers - one for each board.

Organize file structure

Organize the repository file structure and make the code cleaner.

Make user-friendly layouts and aesthetically pleasing graphics

Requested Features

• #76
• #77
• #75
• #74

Create winning condition

Requested Features

• For a player to win, he must kill the other player's king in the hell board. Please write the logic for that.

Dragging pieces doesn't work sometimes

How to reproduce:

1. Position White Queen at a2.
2. Position White King at a1.

King can skip a turn.

Steps to reproduce:

1. Throw all the pieces that are to the right side of the king out of the board.
2. Try to castle with the king.

Add chat

depends on this issue.

Highlighting doesn't work when hovering over a piece

Steps to reproduce:

1. Hover your mouse over a piece.

Can drag any piece off the board despite the move being illegal

ISSUE DISCOVERED BY NAHUM WHO CAN FINALLY TEST
for example:
you can drag a chess pawn off the board by dragging him to the right/left no matter the distance from the edge of the board...

Add promotion logic

See Promotion if you need to.

• Write promotion logic.
• Create UI for picking which piece to promote to.

Fix some pieces being able to skip over other pieces

Create more pieces

Requested Pieces:

• #110
• #111

Generate randomly positioned coins on the board

Requested Features

• #114
• #115