idodod / protoc-gen-fieldmask Goto Github PK

I've built and installed the tool. Then using buf:

# buf.gen.yaml
# Generated by "buf config migrate-v1beta1". Edit as necessary, and
# remove this comment when you're finished.
version: v1
plugins:
  - name: go
    out: .
    opt: paths=source_relative
  - name: go-grpc
    out: .
    opt: paths=source_relative
  - name: fieldmask
    out: .

And running

✗ buf generate -o pkg/proto
Failure: plugin fieldmask: github.com/<repo>/../<filename>.pb.fieldmask.go: unparsable Go source: 296:1: expected '}', found 'type' (and 9 more errors)

I'm sorry I can't provide a narrower concrete example right now.

For example if you will try to generate field mask from such proto file:

syntax = "proto3";

option go_package = "unparsable";

package unparsable;

message Foo {
  string type = 1;
  string switch = 2;
}

You will get an error:
--fieldmask_out: t.pb.fieldmask.go: unparsable Go source: 41:64: expected selector or type assertion, found 'type' (and 4 more errors)

So the problem is that if you use as a field name reserved word in Goland - it will be an error.

Let's add generation full path generator, which will generate path from message name to field name.

Problem: for example in one proto file can be several duplicated field names:

syntax = "proto3";

package casesa;

option go_package = "cases/a;a";

message Foo {
  string bar = 1;
  int32 baz = 2;
}

message Bar {
  string bar = 1;
}

After generation we will receive smth like this:

f := Foo{}
f.FieldMaskPaths().Bar() // will return "bar"
b := Bar{}
b.FieldMaskPaths().Bar() // will also return "bar"

It is a problem due to one proto file can be like namespace. So it can be useful to have absolute path of each field in namespace.

f := Foo{}
f.FullFieldMaskPaths().Bar() // will return "foo.bar"
b := Bar{}
b.FullFieldMaskPaths().Bar() // will return "bar.bar"

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: .github/renovate.json5
Error type: Invalid JSON5 (parsing failed)
Message: JSON5.parse error: JSON5: invalid character '}' at 62:5

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update go modulesUpgrades (google.golang.org/genproto, google.golang.org/protobuf)
• Update dependency earthly/earthly to v0.8.15
• Update alpine Docker tag to v3.20
• Update dependency golangci/golangci-lint to v1.59.1
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository