GithubHelp home page GithubHelp logo

iiifc-theme's People

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

iiifc-theme's Issues

Spec layout and api-table css have changed?

The left-padding seems off when I run the latest version of the theme locally on the API site, and the API-table has lost cell borders:
Screen Shot 2021-08-05 at 10 39 28 AM

For comparison, here's what it looks like on current preview for API:
Screen Shot 2021-08-05 at 10 45 00 AM

Maybe something about the css refactor caused this?
I'm not skilled enough to fully diagnose, but testing iterations locally looks like it was introduced in this commit:
b70f5cf

scss pruning

after styling is stable:

  • clear out any redundant styling
  • rely on bulma vars where possible
  • remove unused bulma libraries
  • split styles into component files for easier maintenance
  • minify output file

Include button on tabs via front-matter?

Related to #14, I think you said we could include a button on the tab element that would then anchor down to "user" or "implementer" section, but I can't seem to figure out how to invoke the button on a tab via the front-matter.
Can you explain how it works when you have a sec?

Print layout style sheet?

This is a very low priority at this point, but would be good to understand what would be involved in making a style sheet that made printed versions of the specs a little bit cleaner...
And for what it's worth, this is mostly for the spec layout if that matters, other layouts are even lower priority on this front

Integration tests fail to pickup YAML error

Is there a way to get the integration tests to fail if there is a problem with the YAML? There was the following issue with the index page which meant the main page failed to load the CSS:

IIIF/website@d5363bc

There was the following warning when Jekyll was built but it passed the GitHub actions tasks:

YAML Exception reading /Users/gmr/development/iiif/website/source/index.md: (<unknown>): did not find expected key while parsing a block mapping at line 37 column 7

Need "post" layout?

Related to #12, need to figure out how to bring over the _posts contents from old site.
They refer to a post layout, which we can either globally find/replace, or figure something else out.

Also, potentially could just use a variation of the page layout, modified just enough to include a byline and dateline at the top?

Event JSON

Josh and I started discussing what the back end JSON should be to drive the events page:

https://preview.iiif.io/root/wireframe/news-and-events/

We currently have:

  • calendar.json - this is updated once a day and gets the data from the IIIF calendar. It contains the meetings within the next 7 days and also the time and date for the next meeting of each group like 3d or D4H
  • eventbrite.json - this is updated when eventbrite is edited. It contains all IIIF eventbrite events so training and annual conferences. Currently this is used on the training site to generate the link at the top to the latest training: https://training.iiif.io/iiif-online-workshop/index.html
  • Google Sheets: generated from the Newsletter google form

@mnyrop could you let me know what data you would need for the website and I can look at combining the difference data sources into a single JSON for your use.

Credit line for header image

In the category of nice to have, not necessary for launch:
Would be great to make a simple feature/functionality that reads from the front-matter and puts a credit line in the footer for the header image used on that page

Construct preview URLs dynamically from branch name

Follow up question: do branches need to be "paired" post-sprint?
e.g.,

root_url:       'https://preview.iiif.io/root/wireframe/'
api_url:        'https://preview.iiif.io/api/wireframe/api'

In other words, can we override api_url only on preview deploy for the api repo?

Editor request: example json should wrap if needed

As discussed, this conflicts with "copy" button.
Josh will discuss with Editors about relative merits of no horizontal scroll, versus utility of copy button.
Also, Marii helpfully points out that prevailing best practice on sites like Github and elsewhere that have copy functionality enabled is to have horizontal scrolling.

Sanity check for later: find way to check internal links for correct API variables

E.g., we will need to make sure all things that reference API versions as variables are working correctly, like this one:

{{ site.url }}{{ site.baseurl }}/api/presentation/3.{{ site.presentation_api.draft.minor }}/#language-of-property-values

needs to get converted to something like this:
{{ site.api_url }}/presentation/{{site.data.apis.presentation.latest.major}}.{{ site.data.apis.presentation.latest.minor }}/#language-of-property-values

Internal link checker in CI may already cover this, just documenting here to make sure before I forget.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.