GithubHelp home page GithubHelp logo

Comments (13)

ikaruswill avatar ikaruswill commented on June 25, 2024 1

Roger that. Let's roll with that fix for za5 temporarily until support is added.

I just poked upstream's upstream. Looks like the issue has been open for a while. ZA5 is using the new miotspec which is a whole new bag of worms and needs significant work. Likely we won't expect the fix to be here within the next month or so.

rytilahti/python-miio#788

from lovelace-fan-xiaomi.

ikaruswill avatar ikaruswill commented on June 25, 2024 1

@insajd It's working as expected, just tested with the ZA5. I'm able to cycle through all 3 speeds.

There are some weirdness that I observed however, due to the fan being not fully supported by xiaomi_miio yet.

  • Speeds cycle through 1%, 35%, 74% instead of 1%, 33%, 66%
  • use_standard_speeds will not work as raw_speed reports incorrect values.

For example, when speed is at high, or 74% (Read through Mi Home app):

raw_speed: 3

It appears that the raw_speed as of the current implementation, is reporting the speed level instead, and there's no attribute that reports the percentage speed correctly.

Nonetheless, I don't think we can or should implement any further hacks for ZA5. Thanks again!

from lovelace-fan-xiaomi.

Spegeli avatar Spegeli commented on June 25, 2024 1

Works thx ;-)

Now its time to wait until the Miio Fan Adapter Dev adds the rest of the fan futures ^^

from lovelace-fan-xiaomi.

ikaruswill avatar ikaruswill commented on June 25, 2024

I just upgraded my fan to the za5, and I'm seeing the same issue. The issue originates from xiaomi_miio_fan integration, where the za5 is only recently added and do not yet have stable features.

In the entity attributes, Level 4 is also missing from the speed list

speed_list:
  - 'off'
  - low
  - medium
  - high
  - 'off'
  - Level 1
  - Level 2
  - Level 3

Unfortunately it seems the issue doesn't lie with our code but rather upstream. We'll have to raise an MR with them.

from lovelace-fan-xiaomi.

insajd avatar insajd commented on June 25, 2024

We can quickly allow iteration through 3 speeds instead of 4. Or option "use_standard_speeds: true" can be used, then it will iterate through low/medium/high options.
I have made a 3 speed fix in branch https://github.com/ikaruswill/lovelace-fan-xiaomi/tree/insajd-za5_fan
@ikaruswill should we release 3 speed fix as 1.5.7-beta for za5 or wait for upstream fix?

from lovelace-fan-xiaomi.

ikaruswill avatar ikaruswill commented on June 25, 2024

Oh wow you're fast. @insajd thanks for your quick work as always. Let's release a beta, while I'll look into how I can solve that with a PR upstream.

To confirm it's a toggle-able option right?

from lovelace-fan-xiaomi.

insajd avatar insajd commented on June 25, 2024

Oh wow you're fast. @insajd thanks for your quick work as always. Let's release a beta, while I'll look into how I can solve that with a PR upstream.

To confirm it's a toggle-able option right?

  • use_standard_speeds is togge-able option, it's present in 1.5.6 already and we don't need to release beta to use low/mid/high speeds. I suppose thiw will have something like 33,66,100% speeds.
  • Speed 3 fix in branch is not togge-able. It's internal setup for za5 only, that makes za5 to support only 3 speeds. It will iterate back to 1 after speed 3. This will probably have 1,33,66% speeds.

First option can be used already, for second option we can release beta, which will influence only za5 fan. I'll go with it

from lovelace-fan-xiaomi.

ikaruswill avatar ikaruswill commented on June 25, 2024

@Spegeli Just so you know, there are some ongoing issues with upstream:

  • Unable to set fan speed above 3 (You reported that, we have a workaround)
  • Unable to send a turn left/turn right command to the fan
  • Oscillation angle does not report nor set correctly
  • Timer does not set correctly

from lovelace-fan-xiaomi.

ikaruswill avatar ikaruswill commented on June 25, 2024

@Spegeli Do update to 1.5.7-beta2 should work as expected after a full, uncached refresh.

from lovelace-fan-xiaomi.

insajd avatar insajd commented on June 25, 2024

@ikaruswill you can try getting this version, which ought to add support for the fan. rytilahti/python-miio#1087 and get ready the support of the fan card.

from lovelace-fan-xiaomi.

ikaruswill avatar ikaruswill commented on June 25, 2024

Nice spot. Will check that out.

from lovelace-fan-xiaomi.

tieppm avatar tieppm commented on June 25, 2024

@ikaruswill @insajd
please fit for zhimi.fan.za5
no change in speed and natural mode
thank you

from lovelace-fan-xiaomi.

ikaruswill avatar ikaruswill commented on June 25, 2024

Closing as za5 is now supported with native integration on 2.0.0

from lovelace-fan-xiaomi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.