ikeay / cs50 Goto Github PK

View Code? Open in Web Editor NEW

8.0 8.0 10.0 201 KB

study cs50

C 50.11% Python 33.58% CSS 1.06% HTML 15.26%

cs50's People

Contributors

Stargazers

Watchers

Forkers

azarashin melanieetm naoto29 adrmartins blehzorp cody51234 aadhilmoola adriantregoning manato066 ishafayshahid

cs50's Issues

Pluralityのバグを修正する

https://gist.github.com/ikeay/1e97ae53d469d1ae4afceaf3fdc11da4

上記の指摘を直す。

Any negative value except for -1 is incorrectly accepted as the key

cs50/caesar/caesar.c

Line 17 in 6176a97

if (key == -1)

If you specify a negative number but -1, the code returns an unexpected result. It should display an error message when a negative value is specified as the key.

Example:
$ ./caeser -10
plaintext: abcdefgABCDEFG
ciphertext:WXYZ[]789:;<=

テンプレートに従う

テンプレートが存在していることに気づいたので、テンプレートに沿っていないコードを修正する。

Should be rollback if failed

cs50/pset8/finance/application.py

Lines 105 to 110 in 2e1de93

 # TODO: Should be rollback if failed 

 db.execute("INSERT INTO histories(user_id, symbol, name, shares, price) VALUES (:user_id, :symbol, :name, :shares, :price)", 

 user_id=session["user_id"], symbol=info["symbol"], name=info["name"], shares=num, price=info["price"]) 

 owned_shares = db.execute("SELECT * FROM owned_shares WHERE symbol = :symbol AND user_id = :user_id", 

 symbol=info["symbol"], user_id=session["user_id"])

This issue was generated by todo based on a `TODO` comment in `2e1de93`. It's been assigned to @ikeay because they committed the code.

Consider better validation logic

cs50/caesar/caesar.c

Line 48 in 6176a97

if (atoi(&str[i]) == 0 && strcmp(&str[i], "0") != 0)

I am guessing you'd want to check if any non-digit character is contained in the specified string when atoi() returns a zero. I'd suggest to simply check if (str[i] < '0' || str[i] > '9') instead.

It will return -1 if a negative number is specified, but it should be ok since your code doesn't expect any negative number. Also the previous issue that I raised (#2) will be automatically resolved.

ikeay / cs50 Goto Github PK

cs50's People

Contributors

Stargazers

Watchers

Forkers

cs50's Issues

Pluralityのバグを修正する

Any negative value except for -1 is incorrectly accepted as the key

テンプレートに従う

Should be rollback if failed

This issue was generated by todo based on a `TODO` comment in `2e1de93`. It's been assigned to @ikeay because they committed the code.

Consider better validation logic

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs

	# TODO: Should be rollback if failed
	db.execute("INSERT INTO histories(user_id, symbol, name, shares, price) VALUES (:user_id, :symbol, :name, :shares, :price)",
	user_id=session["user_id"], symbol=info["symbol"], name=info["name"], shares=num, price=info["price"])

	owned_shares = db.execute("SELECT * FROM owned_shares WHERE symbol = :symbol AND user_id = :user_id",
	symbol=info["symbol"], user_id=session["user_id"])

ikeay / cs50 Goto Github PK

cs50's People

Contributors

Stargazers

Watchers

Forkers

cs50's Issues

This issue was generated by todo based on a TODO comment in 2e1de93. It's been assigned to @ikeay because they committed the code.

Recommend Projects

Recommend Topics

Recommend Org

Jobs

This issue was generated by todo based on a `TODO` comment in `2e1de93`. It's been assigned to @ikeay because they committed the code.