The ucits-ma from imadarchid

The current state of the search bar is not functioning optimally.

The search bar appears to be functioning incorrectly. After careful consideration, I believe that a potential solution could be implemented in one of two ways:

Implementing regular expression to check if the user's input matches the format "MA*******", and routing the user to the path "/MA*******" if it does. Alternatively, we could implement a full-text search in the TRPC route of the name, which would require a mutation and result in a list of possible outcomes for the user to choose from.
Introducing separate search bars for both the name and ID.
Additionally, the issue with "Random" not generating truly random results should also be addressed.

I plan to draft a solution and submit a merge request as soon as possible.

Overall, I find this project to be truly impressive.

PerformanceChart: is there a better solution than converting Decimal to Float in Prisma types?

Context

We're implementing a chart component called PerformanceChart in Resultbox.tsx.

ucits-ma/app/components/Resultbox.tsx

Lines 21 to 23 in a818fb9

 <div id="cardContent" className="px-4 py-2"> 

 <PerformanceChart dataset={fund.data?.performances} /> 

 </div>

The dataset prop has an interface PerformanceChartProps[] as follows:

ucits-ma/app/components/PerformanceChart.tsx

Lines 17 to 25 in a818fb9

 interface PerformanceType { 

 vl_value: number 

 an_value: number 

 date: string 

 } 

 interface PerformanceChartProps { 

 dataset?: PerformanceType[] 

 }

Data is mapped from the database through Prisma, with the Prisma schema as follows for performances:

ucits-ma/app/prisma/schema.prisma

Lines 38 to 45 in a818fb9

 model performances { 

  performance_id Int @id @default(autoincrement()) 

  isin_code String @db.VarChar 

  date DateTime @db.Date 

  an_value Decimal @db.Decimal 

  vl_value Decimal @db.Decimal 

  funds funds @relation(fields: [isin_code], references: [isin_code], onDelete: NoAction, onUpdate: NoAction, map: "ISIN constraint") 

 }

⚠️ Problem

tsc complains that the dataset prop cannot accept number values for string types for vl_value and an_value.

types of property 'vl_value' are incompatible.
        Type 'number' is not assignable to type 'string'.

The issue comes from the fact that Prisma relies on Decimal.js for the Decimal type, which for some reason ends up converting values into strings instead of numbers.

Proposed solutions

Use the Prisma.Decimal class as a type for values vl_value and an_value in PerformanceType
Does not work, and throws the same error as before.
Use inferRouterOutput to infer types from findByIsin
The whole output types are inferred. Can I access a nested object's performances types only? (Sorry my TS skills are.. well improving?)
Convert Decimal data types for vl_value and an_value in Prisma to Float
We maintain consistency and errors are not thrown both from the prop side and the Chart.js side (which requires the type number for the chart values).

Current fix
I opted for option 3, but I think it's a little messy. Is this the right path? TBD (I can't stay stuck on this issue any longer...)

imadarchid / ucits-ma Goto Github PK

ucits-ma's People

Contributors

Stargazers

Watchers

ucits-ma's Issues

The current state of the search bar is not functioning optimally.

PerformanceChart: is there a better solution than converting Decimal to Float in Prisma types?

Context

⚠️ Problem

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs

	<div id="cardContent" className="px-4 py-2">
	<PerformanceChart dataset={fund.data?.performances} />
	</div>

	interface PerformanceType {
	vl_value: number
	an_value: number
	date: string
	}

	interface PerformanceChartProps {
	dataset?: PerformanceType[]
	}

	model performances {
	performance_id Int @id @default(autoincrement())
	isin_code String @db.VarChar
	date DateTime @db.Date
	an_value Decimal @db.Decimal
	vl_value Decimal @db.Decimal
	funds funds @relation(fields: [isin_code], references: [isin_code], onDelete: NoAction, onUpdate: NoAction, map: "ISIN constraint")
	}