Comments (7)
Never mind! I was apparently still using the release version. The recent snapshot does actually fix this issue.
from immich.
Thanks for the report and example image. Could you double-check the permissions of that link? I can't access it.
from immich.
FWIW I locally opened the two example images for this camera from https://raw.pixls.us and the compressed one displays with the weird black border while the lossless one has some vignetting in the corners. The same occurs in immich.
However, there's a new option as of 1.102.0 to use the embedded preview for RAW images and I can confirm it works well for this camera. I recommend enabling this setting and re-running thumbnail generation for images from this camera.
from immich.
Thanks for the report and example image. Could you double-check the permissions of that link? I can't access it.
Fixed.
However, there's a new option as of 1.102.0 to use the embedded preview for RAW images and I can confirm it works well for this camera.
Sweet, looking forward to it.
from immich.
v1.102.0 using the new preview option produces even worse results. I mean.. technically the black border is gone, but at what cost? 😛
Left is RAW, right is JPG exported from RAW.
from immich.
It looks like there's an issue with how the preview image is produced to begin with - it has no metadata and the image looks like this locally as well. There's not much for an image converter to work with there. I checked the other example images and the same is true there as well; they just happened to produce a more normal looking image. The colors on them are still off upon closer inspection.
The issue with the RAW conversion seems to be that there are two different kinds of dimensions listed in the metadata: ImageHeight
and ExifImageHeight
(same for width and size as well). The former is what we use (and what the image processing libraries presumably use), while the latter is what has the correct dimensions for the image. Fixing it in our metadata extraction is easy, but the issue in image processing should be handled upstream. I think this is probably a libvips issue: libraw is only used for decoding the source image, while generating the converted image is handled in libvips.
Edit: It actually does look to be a libraw issue since I can reproduce it with their dcraw_emu
CLI.
from immich.
I tested with the latest snapshot of libraw and still had this issue. Are you okay with me using this link as an example image for the issue?
from immich.
Related Issues (20)
- People's thumbnails don't get regenerated from the job that is supposed to regenerate them HOT 22
- Video in cloud does not render on IOS HOT 7
- Navigating to/from non-album share breaks browser navigation
- Cannot extract the position
- How to merge a mobile album into an immich album
- Panoramas/photospheres in shared link display incorrectly when download is disabled
- Issue when load openvino for machine learning HOT 1
- Login/password not recognised on android app HOT 2
- Selecting on Android causes screen shift
- Android app unable to update asset list from server HOT 3
- Everything gets lost after shut down of NAS device (External Library only) HOT 1
- Get rid of ENV file, include in docker compose.
- Immich android app is uploading duplicates HOT 1
- Some HEIC photos have wrong orientation in web only HOT 1
- Live photo uploaded as jpeg when uploads in shared album HOT 1
- [BUG] docker/volume/immich_model-cache is 65GB HOT 4
- Exception : AuditDeletesResponseDto.fromJson HOT 1
- Upload layout on mobile broken HOT 1
- Change location dialog doesn't show result for latest value in search input HOT 2
- Server error caused by very poor performance when many images are stacked HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from immich.