impress-org / donation-block-for-stripe Goto Github PK

Details

Right now they are charging an incorrect amount.

Details

Right now there's no way to edit a donation after moving to the payment step. We should make this process easier than having the donor refresh the page (which many likely won't know how to do).

Details

This plugin should be able to create releases and pre-releases like our GiveWP and it's add-ons.

Additional Context

See: https://github.com/impress-org/givewp-github-actions

Acceptance Criteria

• Pre-releases can be created
• Releases deploy correctly to WP.org
• No releases to GiveWP.com (doy!)

Details

When running npm run build it complains about the size of several files:

We should see how we can optimize this to load more efficiently if possible.

Details

When you have more than one donation form on a page and the user starts a donation in one form and then moves to the next the payment element cannot be attached to the DOM due to duplicate selectors.

From Stripe:

The selector you specified (.donation-form-payment-intent) applies to 2 DOM elements that are currently on the page.
The Stripe Element will be mounted to the first one.

Details

This will prefix the SDK so that it doesn't conflict with other plugins using the SDK without autoloading, etc.

https://github.com/BrianHenryIE/strauss

Issue Description

Right now any editor can connect and disconnect from Stripe which isn't secure. We should lock it down to only admins.

Details

Stripe supports several zero decimal currencies, and with the plugin soon to support additional currencies in #15 we should also ensure our logic supports zero-decimal currencies.

Additional Context

https://stripe.com/docs/currencies

Details

Add ability to accept recurring donations with 2% fee for:

1. Monthly
2. Annually

Details

When first using the block, and not connected to Stripe, the frontend form or notice never displays. It's simply blank and can leave a new user confused. It's easy to miss the notice above the form in the backend.

Video describing the issue:

https://www.loom.com/share/41cdd2be2ade4c6faed0918060d940b3

Expected Behavior

First time users should be clear that the first step to accepting donations is to connect to Stripe. They can preview the form on the frontend and backend but not make it past step 1.

Details

There is now a native way to format numbers to currency and locale.

It appears pretty well supported now cross-browser.

See docs here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/format#browser_compatibility

Right now the amount buttons do not support currency formatting. This will be particularly useful.

This is related to #15

Details

Currently the US dollar is hard coded into the plugin code. We should provide admins the ability to change this currency to the one of their choosing.

Note: This is not a donor-facing currency switching capability.

Acceptance Criteria

• New currency option is added to Gutenberg listing Stripe supported currencies
• Currency displays on the frontend properly
• Currency is formatted correctly
• The donation is processed in the correct currency
• Multiple donation forms on a page respect the chosen currency for the particular form

Details

There is an extra space between the currency symbol and the amount that needs to be removed. I believe it got there due to a code reformatting (prettier).

Details

One of Gutenberg's key features is editing content directly in a block. Justin from WP-Tavern pointed that out in his review of the plugin and I think it's a valid criticism.

It wouldn't be too difficult to add the ability to adjust the content directly in the block using inner blocks rather than the sidebar.

Details

According to @JasonTheAdams, Stripe no longer a

We should refactor the Stripe code to no longer create the PaymentIntent until Step 2 (payment) is completed.

@jonwaldstein can you add context here or any relevant links?

Details

When you make a donation through the form and return from Stripe you will see the donation form's first step before it flashes to the receipt. The time varies depending on the server.

As well, the dollar amount changes from the default $25 to whatever the amount of the donation actually was.

This is hardly an ideal UX and can be improved.

Additional Context

The best way to improve this as I see now is to use a loading screen that displays before actually displaying the receipt.

Acceptance Criteria

• No flash happens
• Confetti cannon still blasts properly spreading joy throughout all of time
• Loading looks nice and isn't clumsy

Details

This is the perfect time to get started with end to end testing the block.

E2E w/ Gutenberg Info

It looks like Gutenberg is in the process of migrating from Puppeteer to Playwright: WordPress/gutenberg#38851

There's tons of resources above, but it's going to take a bit of digging to fully understand how we can utilize this correctly.

📑 Good Resources:

A few helpful resources I found while doing research...

Migrating WordPress e2e tests to Playwright

https://make.wordpress.org/core/2022/03/23/migrating-wordpress-e2e-tests-to-playwright/

@wordpress/e2e-test-utils: It is a utility package with basic tests that are reused by other E2E test packages and suites in Gutenberg, in WordPress Core and by third parties. This package is now deprecated and a new package @wordpress/e2e-test-utils-playwright was introduced internally for the migration process.

---

E2E Tests Utils Playwright Package:

https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils-playwright

---

Details

Stripe's payment element has nice focus effect that hast the primary color border with a little css transition effect. We should follow suite with the inputs we provide:

Details

Currently the plugin uses a few PHP 7.4 specific syntaxes that should be fixed to resolve any issue with PHP below 7.4 and above 7.2.

I'd like to be able to change the multi-level amount options and choose which one of them is the default. Currently, the default amount is always $25 regardless whether that's a button option or not.

Details

This plugin is free and requires no license, yet GiveWP wants one to be activated and shows a notice.

Expected Behavior

No notice displays.

Additional Context

I believe adding a Plugin URI in the header with a non-GiveWP link should prevent the notice from displaying. This is what our other WP.org add-ons do.

Acceptance Criteria

• No license notice displays when GiveWP is active

Issue

If you click on a color twice when customizing your donation form block it causes the block to break with a JS error.

User Story

When GiveWP is installed, we should create donors and donations when a payment is processed.

This will encourage folks to install the core plugin when they want this data on their site and to do more with it.

Details

I'm not sure what's needed to ensure this plugin can be easily translated but WordPress' block checker is complaining about:

This plugin was create using WP's create-block script here: https://developer.wordpress.org/block-editor/reference-guides/packages/packages-create-block/

I believe there are some out of the box toolage for i18n when using this package.

... more updates to come as I begin learning more.

When you install the block from within the block editor you get a fata error message and can't use the block.

Instead, when installing this way, the block should immediately be available.

Details

There are two PHP notices that display when installing the plugin for the first time:

[05-Apr-2022 21:20:41 UTC] PHP Notice: Trying to get property 'livePublishableKey' of non-object in /Users/devinwalker/Local Sites/frost/app/public/wp-content/plugins/donation-block-for-stripe-by-givewp/src/DonationBlock.php on line 54

[05-Apr-2022 21:20:41 UTC] PHP Notice: Trying to get property 'testPublishableKey' of non-object in /Users/devinwalker/Local Sites/frost/app/public/wp-content/plugins/donation-block-for-stripe-by-givewp/src/DonationBlock.php on line 56

User Story

As a [type of user], I want [some goal] so that [some reason].

Stripe has a new service called "Link" that allows people to enter their phone number and

Details

Since this is a newer API with Stripe there are a few unknowns. This is what I have gathered from Stripe:

Link documentation

Technical Documentation: https:/stripe.com/docs/payments/payment-methods/link {Note - these are gated, so please ensure you are logged into your Stripe account before accessing}

Demo: https://link-in-elements.glitch.me/checkout/ {Note - other users have found it helpful to click “Highlight the elements”}

Link fees - Link is priced as its own payment method (with default rates of 2.9% & $0.30).

Acceptance Criteria

• Link is enabled when toggling
• Link works hassle free

Details

Documentation here: https://givewp.com/documentation/resources/donation-form-block-for-stripe/

Additional Context

We need to find a good place to add it. It should also be a shortlink

Details

Oh, WordPress themes... why do you do such things?

There's issues with some themes adding padding, margin, line-heights, and other craziness to the next currency symbol.

Visuals

See this hot mess:

Details

When GiveWP Core and Stripe is installed (or a license activated) then the 2% fee should be removed.

Details

Stripe recommends we identify the plugin for them:

Details

Protect the innerwebs from destruction!

Additional Context

... and add a nonce.\

Additional Context

Currently the plugin violates the PHP maximum allowed when running it through the validator. There are also a few other recommendations that we should apply.

Block Plugin Checker: https://wordpress.org/plugins/developers/block-plugin-validator/

Block Directory Guidelines:

• GitHub Repo: https://github.com/WordPress/wporg-plugin-guidelines/blob/block-guidelines/blocks.md
• Make Post: https://make.wordpress.org/meta/2019/12/06/block-directory-plugin-guidelines/

Release 1.0.0 recommendations:

Acceptance Criteria

• PHP is reduced to guideline's recommendations
• Translation scripts work as expected
• "block" is added as a tag