Issue Overview

Since the addon is using give_insert_payment as the hook to work the magic on, if a donation isn't completed at Paypal, the user is still added to a convertkit list. This is problematic.

Expected Behavior

We should only add a donor to a list after the donation is marked as complete.

Current Behavior

Donations are pending and then abandoned (as they should be) but the donor email is still added to convertkit.

Possible Solution

Perhaps using the same hook that our donation confirmation/ admin notification emails are sent on would work.

Steps to Reproduce (for bugs)

1. Set up convertkit addon and a form with paypal standard
2. Submit a donation, but don't complete it at PayPal
3. Donation is pending, but the donor email has already been added to Paypal.

Todos

• Tests

Bug Report

User Story

As a user, I want to set admin settings for Convert Kit to utilize its functionality so that I can take benefit of ConvertKit.

Current Behavior

Currently, the admin settings page is broken when used with Give 2.5.0

Expected Behavior

I expect to make the admin settings page forward as well as backward compatible.

Bug Type

• This bug describes functionality that once worked as expected in version X.X.X.
• This bug describes functionality that never worked as expected.
• I am not sure whether this functionality ever worked as expected.

Visuals

Related

https://github.com/impress-org/give-paypal-pro/issues/81

Acceptance Criteria

• Research why the admin settings page is broken in Give 2.5.0, and not Give 2.4.7
• Fix the issue
• Test with Give 2.5.0 as well as Give 2.4.7 to ensure forward as well as backward compatibility.

Issue Overview

When Give is deactivated or is not updated to the minimum version requirement, we need to be sure that the plugin deactivates.

Expected Behavior

Plugin will deactivate with helpful message if requirements are not met to run plugin.

Current Behavior

The plugin stays activated with no message.

Possible Solution

Provide message and helpful links.

Steps to Reproduce

1. Have both Give+ add-on active
2. Deactivate Give
3. The add-ons will stay active

Todos

• Implement admin notice functionality
• Implement deactivation functionality
• Test min version requirement
• Test Give active requirement

Issue Overview

As a Give Admin, I want to use Give ConvertKit in a way that is consistent with Give 2.1, so that I don't have any PHP warnings from deprecated hooks in the plugin.

Deprecated hooks were announced here:
https://developers.givewp.com/2018/03/19/legacy-hooks-being-deprecated-within-2-0-7/

Expected Behavior

There should not be any deprecate hook.

Current Behavior

Without an update, Give-ConvertKit will have deprecated hooks as of Give 2.1.

Related Issues

• https://github.com/WordImpress/Give-Form-Field-Manager/issues/241
• https://github.com/WordImpress/Give-Tributes/issues/245