impress-org / give-double-the-donation Goto Github PK

Currently, if a form has guest donations disabled in the individual form settings, and either the "registration", "login" or "registration and login" option selected, the GiveWP Double The Donation add-on displays twice.

This happens on all three form templates.

Also, this happens only if you access the website while you are logged out OR using an incognito tab.

https://givewp.canny.io/admin/board/bug-reports/p/the-double-the-donation-add-on-should-only-display-their-form-field-once-on-gues

User Story

As a [type of user], I want [some goal] so that [some reason].

Details

It sometimes gets cut off depending on how tall the list of options is.

Expected Behavior

It shouldn't ever get cut off.

Steps to Reproduce

1. Select the word "German" for a longer list and see it's cut off like in the VIsual below

Visuals

Acceptance Criteria

• It's never cut off...

Details

The readme.txt displays on wordpress.org for all visitors to see and understand the power of this addon. It is primarily a marketing page. It needs to be filled out in detail with shortlinks and FAQs and screenshots.

As a GiveWP and Double the Donation user, I want to understand how using this addon will benefit me and my fundraising. I want to understand how it works and what it's core features are.

I want to be able to understand any caveats or general usage guidelines to using this plugin effectively.

I want to see that there are other well-supported and full-featured addons available with GiveWP.

Acceptance Criteria

• The readme is complete and passes the readme validation. WPReadMe.com is also useful for this purpose.

Details

The Double the Donation settings page should follow the standards set by existing GiveWP plugins so that it is more discoverable and maintainable.

Visuals

1. The Double the Donation tab is nested under General > Settings, but other add-ons have top-level tabs. It's unclear to me whether this is intentional or not.
2. This registration form link should probably use a short URL in case we need to update it in the future.
3. This docs URL does not exist

Acceptance Criteria

• The settings tab position is reviewed and moved if necessary.
• The registration form link uses a short URL.
• The docs URL in the bottom right corner of the settings page is fixed.

User Story

As a GiveWP form creator, I don't want to see "Company Matching" fields unless I've Enabled Company Matching on my form.

Details

Currently the "Default Label" field is shown whether the feature is enabled on the form or not.

Expected Behavior

The "Default Label" field should not appear on the form until the feature is enabled.

Steps to Reproduce

1. ACtivate the add-on
2. Add the test API keys
3. Go to edit an existing form and click on the "Company Matching" tab
4. You'll see the "Default Label" field appears though the feature is set to "Disabled"

Visuals

Acceptance Criteria

• The "Default Label" field is hidden by default when the default setting for the feature is set to "Disabled"
• Changing the setting from "Enabled" to "Disabled" shows/hides the field correctly
• After saving the form, the setting still is shown/hidden correctly based on whether the feature is enabled or not

User Story

As a GiveWP admin, when I disable the "Company Matching" feature from a form, I expect it to not show on the front-end form after saving my form.

Details

Currently, if you enable the feature on a form, save the form, view the form, it all works as intend.

But if you then disable the Company Matching feature after having saved it as enabled, the Company Matching option still appears on the form.

Expected Behavior

I expect that when the feature is disabled in the form, it doesn't appear on the front-end of the form.

Steps to Reproduce

1. Enable the feature on a form and save it. Confirm it shows on the form as intended.
2. Disable the feature on that same form and save.
3. View the form and confirm that the Company Matching field still appears on the form.

Acceptance Criteria

• When the feature is set to "Disabled" it does not appear in the form
• When it's Enabled it DOES appear on the form
• No matter how often a form is enabled or disabled and saved again, the feature only appears on the form when the setting is set to "Enabled"

User Story

As a GiveWP admin, I want to get emails of my donations and have an indication of whether the donation was company matched or not as well as what company was indicated for matching purposes.

Acceptance Criteria

• An email tag called {company_matching} is created
• The {company_matching} tag outputs "None" if no match was chosen; and the company name if a match was chosen. It additional provides a link to the company matching page for easy reference.

User Story

I expect when I click on the Double the Donation "Settings" link on the Plugin page, that it takes me to the correct settings tab.

Details

Currently, it takes me to a page that says "This settings page doesn't exist"

This is the url:
wp-admin/edit.php?post_type=give_forms&page=give-settings&tab=general&section=double-the-donation

Expected Behavior

Instead, I expect it to take me to this URL:
wp-admin/edit.php?post_type=give_forms&page=give-settings&tab=give-double-the-donation

Steps to Reproduce

1. Activate the addon and click on the "Settings" link
2. Verify that it goes to a blank Give Settings page with the error above

System Information

Not necessary for recreation

Acceptance Criteria

• The settings link goes to the right Give settings tab

User Story

As a GiveWP donor, I want to be able to select the company from the dropdown even if I change the payment gateway choice.

Expected Behavior

On legacy forms only, the donor should be able to choose from the dropdown list after changing from the default payment gateway.

It works correctly on multi-step forms already.

Steps to Reproduce

1. Enable a form with the DtD field
2. Set the form to the Legacy template
3. Ensure at minimum two payment gateways are enabled
4. Go to the form and confirm that you can choose a company while on the DEFAULT payment gateway
5. Now switch to a different gateway and confirm that the dropdown appears, but the donor cannot choose a company.

Visuals

Screencast:
http://somup.com/cYXh3cI3xf

Acceptance Criteria

• The company can be chosen after switching to a different gateway regardless of how many times the donor switches the gateway or which gateway is switch to.

User Story

As a GiveWP admin, I want to configure my form to have user registration, and I expect that the Company Matching field would appear only once within the form.

Details

Currently, if you enable User Registration on the form, then the Company Matching field will appear twice in the form. Once before the User Registration box, and once after. See visuals below.

Expected Behavior

I expect it would appear only once.

Steps to Reproduce

1. Enable and configure the DtD addon
2. Configure your form to have User Registration
3. View the form while logged OUT and confirm that the Company Matching field appears twice

Visuals

Acceptance Criteria

• The company matching field appears only once when User Registration is enabled while viewing the form while logged out
• Even if User Registration + Login is enabled, it still only appears once while logged out
• When User registration is NOT enabled, the Company Matching field still appears once while logged out.