GithubHelp home page GithubHelp logo

impress-org / give-payumoney Goto Github PK

View Code? Open in Web Editor NEW
3.0 11.0 1.0 933 KB

Integrate Give with the PayUmoney payment gateway.

Home Page: https://givewp.com/addons/payumoney-gateway/

JavaScript 0.74% PHP 99.26%

give-payumoney's Issues

Remove deprecated implementation of payment method label under gateway settings

User Story

As a user, I want to remove the payment method label setting under gateway settings so that it can be managed from the list of gateways.

Current Behavior

I can see that the payment method label setting under the gateway settings is no longer working.

Expected Behavior

I expect to remove the deprecated setting which is of no use.

Bug Type

  • This bug describes functionality which should be removed since Give Core release 2.0.0

Visuals

image

Acceptance Criteria

  • Remove the payment method label settings as shown in the above screenshot
  • Ensure the payment method label as per Give core 2.0.0 is working fine.

fix: support using Fee recovery.

Bug Report

User Story

As a user, I want for our fee recovery add-on to function with PayUmoney so that I can raise more money by including fees.

Current Behavior

When the donor is redirected to payUmoney, the fee is not added at all.

Expected Behavior

I expect it to add the fee.

Bug Type

  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

1.Enable Fee Recovery and PayUmoney
2. Attempt a donation with a fee added.
3. It will send only the base amount, not the fee, even though it records that it is adding the fee on the back end of GiveWP.

Related

https://secure.helpscout.net/conversation/1142110245/63138

Acceptance Criteria

  • The fee-included amount is sent to payUmoney.

Having issue with payment. After payment website get stopped at domin.org/file/?process_payu_payment=success [Broken functionality] should...

Having issue with payment. After payment website get stopped at domin.org/file/?process_payu_payment=success

User Story

As a [type of user], I want [some goal] so that [some reason].

Details

Expected Behavior

Steps to Reproduce

  1. Go to...
  2. Select...
  3. Scroll down to...
  4. View error

Visuals

Additional Context

System Information

Details

Acceptance Criteria

  • Something happens when an action is taken.
  • Something does not happen when an action is taken.
  • Fixing behavior in Component A does not affect existing behavior in Component B.

Payoumoney should complete the donation when using GiveWP

Details

When a donor tries to donate using Payoumoney, there is a spinning wheel after the user clicks on the Donate Button and a pending donation is created, but the spinning wheel never goes away.

Steps to Reproduce

  • Make sure your site is running using Indian Rupee (₹)
  • Install our Payoumoney add-on
  • Create a donation form and select multi-step donation form
  • Make a donation
  • The spinning wheel will be there after you click to donate

Acceptance Criteria

  • Donors can donate with a donation form with a legacy or multistep form template.

Confirm the user pointing out some high risk vulnerability (i.e. Amount Tampering) within our add-on.

User Story

We have a ticket in Helpscout, where the user is claiming that they had an audit from the HDFC Bank staff and they have pointed out to some high-risk vulnerability (i.e. Amount Tampering) within our add-on.

Dear Maruti,

I spoke with the tech team at the HDFC Bank payment gateway integration . They told me that the reverse hash sent from the payment gateway has to be checked before logging transaction as successful .

The information is available in detail in the integration document - page 19, 20 and 21. I am attaching the same here for your quick reference (available on GitHub as well)

Related link

HS link: https://secure.helpscout.net/conversation/656840067/24825?folderId=1457790

Attachment

Integration Document Version 2.6.pdf

fix: ensure testing credentials do not produce an error at the payment gateway

Bug Report

User Story

As a site admin, I want to test my site with the PayUmoney payment gateway so that I can know if it works before taking it live.

Current Behavior

I receive an error from the payment gateway saying that my testing credentials aren't correct. Even though I confirmed they work.

Expected Behavior

I expect to test the payment gateway successfully before taking it live.

Bug Type

  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Configure a site with PayUmoney testing credentials.
  2. Submit a donation with the PayUmoney gateway
  3. See there error page you're redirected to

Here is a link to a form on a live site with the testing credentials in place:
https://give.gsamsmith.com/donations/payumoney/

Visuals

screen shot 2018-12-03 at 10 45 32 am

Related

https://secure.helpscout.net/conversation/720727207/30229/
https://secure.helpscout.net/conversation/733861448/31234/

Acceptance Criteria

  • Investigate the issue
  • Review the integration document
  • I can submit a donation while using testing credentials with PayUmoney
  • Testing

Environment

Operating System
  • Platform: Mac OS X
Browser
  • Name: Chrome
WordPress System Info ### WordPress Environment ###

Home URL: https://give.gsamsmith.com
Site URL: https://give.gsamsmith.com
WP Version: 4.9.8
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: 4b8_
Table Prefix Length: 4
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: give.gsamsmith.com
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache
PHP Version: 7.0.32
PHP Post Max Size: 64 MB
PHP Time Limit: 30
PHP Max Input Vars: 1000
PHP Max Upload Size: 64 MB
cURL Version: 7.62.0, OpenSSL/1.0.2p
SUHOSIN Installed: –
MySQL Version: 5.6.41
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.3.0
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access✔Daily Email Report✔Weekly Email Report✔Monthly Email Report❌Renewal Receipt Email❌Subscription Cancelled Email❌Subscription Completed Email✔Subscription Reminder Email✔Subscriptions Email Access
Upgraded From: 2.2.4
Test Mode: Enabled
Currency Code: INR
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: https://give.gsamsmith.com/donation-confirmation/
Failure Page: https://give.gsamsmith.com/donation-failed/
Donation History Page: https://give.gsamsmith.com/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Stripe - Credit Card, Test Donation, PayUmoney
Default Payment Gateway: Test Donation
PayPal IPN Verification: Disabled
PayPal IPN Notifications: IPN received for #559 ( 06V14366UX708703B ) on 11/15/2018 at 09:38. Status N/A
Donor Email Access: Enabled

Active Give Add-ons

Give - Authorize.net Gateway: ❌ Unlicensed – by WordImpress – 1.4.3
Give - Currency Switcher: ❌ Unlicensed – by GiveWP – 1.3.0
Give - Donation Upsells for WooCommerce: ❌ Unlicensed – by WordImpress – 1.0.4
Give - Email Reports: ❌ Unlicensed – by WordImpress – 1.1.2
Give - Fee Recovery: ❌ Unlicensed – by GiveWP – 1.7.2
Give - Form Field Manager: ❌ Unlicensed – by GiveWP – 1.4.1
Give - Gift Aid: ✔ Licensed – by WordImpress – 1.1.6
Give - GoCardless Gateway: ✔ Licensed – by WordImpress – 1.2.1
Give - Google Analytics Donation Tracking: ❌ Unlicensed – by GiveWP – 1.2.1
Give - iATS Payment Solutions: ❌ Unlicensed – by GiveWP – 1.0.4
Give - MailChimp: ❌ Unlicensed – by WordImpress – 1.4.1
Give - Mollie Gateway: ❌ Unlicensed – by WordImpress – 1.1.2
Give - PayFast Payment Gateway: ❌ Unlicensed – by WordImpress – 1.0.2
Give - PayPal Pro Gateway: ❌ Unlicensed – by GiveWP – 1.2.0
Give - PayUmoney: ❌ Unlicensed – by GiveWP – 1.0.2
Give - PDF Receipts: ❌ Unlicensed – by WordImpress – 2.3
Give - Per Form Gateways: ❌ Unlicensed – by WordImpress – 1.0.1
Give - Recurring Donations: ❌ Unlicensed – by GiveWP – 1.8.2
Give - Stripe Gateway: ❌ Unlicensed – by GiveWP – 2.1.2
Give - Tributes: ✔ Licensed – by WordImpress – 1.5.0
Give - Zapier: ✔ Licensed – by WordImpress – 1.2.1
WP Rollback: ❌ Unlicensed – by WordImpress – 1.5.1

Other Active Plugins

All-in-One WP Migration: by ServMask – 6.78
Contact Form 7: by Takayuki Miyoshi – 5.0.4
Email Cop: by Ashfame – 0.1.1
Give - Sofort Payment Gateway: by WordImpress, CoachBirgit – 1.0
My Custom Functions: by Space X-Chimp – 4.31
Query Monitor: by John Blackbourn & contributors – 3.1.1
Transients Manager: by Pippin Williamson – 1.7.5

Inactive Plugins

Akismet Anti-Spam: by Automattic – 4.0.8
Debug Bar: by wordpressdotorg – 0.9
Give - 2Checkout Gateway: by WordImpress – 1.1.2
Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0
Give - AWeber: by WordImpress – 1.0.3
Give - Braintree Gateway: by WordImpress – 1.2.2
Give - CCAvenue Gateway: by WordImpress – 1.0.2
Give - Constant Contact: by WordImpress – 1.2.1
Give - ConvertKit: by WordImpress – 1.0.2
Give - CSV Toolbox: by WordImpress – 1.0
Give - Dwolla Gateway: by WordImpress – 1.1.2
Give - Manual Donations: by GiveWP – 1.4.2
Give - Paymill Gateway: by WordImpress – 1.0.2
Give - Paytm Gateway: by WordImpress – 1.0
Give - Razorpay: by WordImpress – 1.2.0
Gutenberg: by Gutenberg Team – 3.8.1
Head and Footer Scripts Inserter: by Space X-Chimp – 4.33
Invisible reCaptcha: by Mihai Chelaru – 1.2.1
WooCommerce: by Automattic – 3.5.1

Active MU Plugins

Endurance PHP Edge: by Mike Hansen – 0.2
SSO: by Garth Mortensen, Mike Hansen – 0.3

Theme

Name: Twenty Seventeen
Version: 1.7
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

fix(payumoney): ensure the payment gateway can be enabled from the settings

User Story

As a site admin, I want to activate the PayUmoney gateway from the Payment Gateways settings pageso thatmy donors can give through this payment gateway`.

Current Behavior

I currently can't activate PayUmoney from the Payment Gateways settings pages. It is also not showing up as an option in on the front-end of my site, making the payment gateway completely unusable.

Expected Behavior

I expect to activate the payment gateway and have my donors use it on the front of my site.

Steps to Reproduce

  1. Activate the PayUmoney addon
  2. Attempt to activate the payment gateway from the Payment Gateways settings page
  3. When you hit save it doesn't activate the gateway, and isn't visible from the form page.

Visuals

screen shot 2018-09-24 at 11 19 51 am

Screencast of the issue:
https://screencast-o-matic.com/watch/cFQZo3YczY

Related

https://secure.helpscout.net/conversation/670407007/26125

Environment

WordPress System Info ### WordPress Environment ###

Home URL: https://give.gsamsmith.com
Site URL: https://give.gsamsmith.com
WP Version: 4.9.8
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: 4b8_
Table Prefix Length: 4
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: give.gsamsmith.com
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache
PHP Version: 7.0.32
PHP Post Max Size: 64 MB
PHP Time Limit: 30
PHP Max Input Vars: 1000
PHP Max Upload Size: 64 MB
cURL Version: 7.61.0, OpenSSL/1.0.2p
SUHOSIN Installed: –
MySQL Version: 5.6.41
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.2.5
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access❌Renewal Receipt Email❌Subscription Cancelled Email❌Subscription Completed Email✔Subscription Reminder Email✔Subscriptions Email Access
Upgraded From: 2.2.4
Test Mode: Enabled
Currency Code: GBP
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: https://give.gsamsmith.com/donation-confirmation/
Failure Page: https://give.gsamsmith.com/donation-failed/
Donation History Page: https://give.gsamsmith.com/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: PayPal Standard, Offline Donation, Authorize.net
Default Payment Gateway: Offline Donation
PayPal IPN Verification: Disabled
PayPal IPN Notifications: IPN received for #303 ( 6JM78069A3740351G ) on 08/29/2018 at 06:17. Status N/A
Donor Email Access: Enabled

Active Give Add-ons

Give - 2Checkout Gateway: ❌ Unlicensed – by WordImpress – 1.1.2
Give - Authorize.net Gateway: ✔ Licensed – by WordImpress – 1.4.3
Give - Form Field Manager: ✔ Licensed – by WordImpress – 1.3
Give - Gift Aid: ✔ Licensed – by WordImpress – 1.1.6
Give - Manual Donations: ✔ Licensed – by WordImpress – 1.4.1
Give - PayFast Payment Gateway: ❌ Unlicensed – by WordImpress – 1.0.2
Give - PayUmoney: ❌ Unlicensed – by WordImpress – 1.0.1
Give - PDF Receipts: ❌ Unlicensed – by WordImpress – 2.3
Give - Recurring Donations: ✔ Licensed – by WordImpress – 1.8.0
Give - Tributes: ✔ Licensed – by WordImpress – 1.5.0
Give - Zapier: ✔ Licensed – by WordImpress – 1.2.1

Other Active Plugins

Email Cop: by Ashfame – 0.1.1
Give - Fee Recovery: by GiveWP – 1.7.2
Give - PayPal Pro Gateway: by GiveWP – 1.2.0
Give - Stripe Gateway: by GiveWP – 2.1.0
Query Monitor: by John Blackbourn & contributors – 3.1.1
Transients Manager: by Pippin Williamson – 1.7.5
WP Rollback: by WordImpress – 1.5.1

Inactive Plugins

Akismet Anti-Spam: by Automattic – 4.0.8
Debug Bar: by wordpressdotorg – 0.9
Give - 2Checkout Gateway: by WordImpress – 1.1.1
Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0
Give - AWeber: by WordImpress – 1.0.3
Give - Braintree Gateway: by WordImpress – 1.2.2
Give - CCAvenue Gateway: by WordImpress – 1.0.2
Give - Constant Contact: by WordImpress – 1.2.1
Give - ConvertKit: by WordImpress – 1.0.2
Give - CSV Toolbox: by WordImpress – 1.0
Give - Currency Switcher: by WordImpress – 1.2.2
Give - Dwolla Gateway: by WordImpress – 1.1.2
Give - Email Reports: by WordImpress – 1.1.2
Give - GoCardless Gateway: by WordImpress – 1.2
Give - Google Analytics Donation Tracking: by WordImpress – 1.1.4
Give - iATS Payment Solutions: by WordImpress – 1.0.3
Give - MailChimp: by WordImpress – 1.4.1
Give - Mollie Gateway: by WordImpress – 1.1.1
Give - Paymill Gateway: by WordImpress – 1.0.2
Give - Paytm Gateway: by WordImpress – 1.0
Give - Per Form Gateways: by WordImpress – 1.0.1
Give - Razorpay: by WordImpress – 1.2.0
Give - Sofort Payment Gateway: by WordImpress, CoachBirgit – 1.0
Gutenberg: by Gutenberg Team – 3.8.0

Active MU Plugins

Endurance PHP Edge: by Mike Hansen – 0.2
SSO: by Garth Mortensen, Mike Hansen – 0.3

Theme

Name: Twenty Seventeen
Version: 1.7
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

Operating System
  • Platform: Mac OS X
Browser
  • Name: Chrome

Returns "Invalid amount" for anything over 3 digits in the donation amount.

Steps to replicate

  1. Set up PayUMoney on Give. (I'm using test credentials)
  2. Initiate a payment of an amount less than 100 INR (it should go through)
  3. Initiate a payment of 1000 INR.

The PayUmoney Page will return this error:

screen shot 2017-05-03 at 2 25 26 pm

SORRY! We were unable to process your payment

Error Reason
Invalid amount

Corrective Action
Please ensure that you send all mandatory parameters in the transaction request to PayU.
Mandatory parameters which must be sent in the transaction are:
key, txnid, amount, productinfo, firstname, email, phone, surl, furl, hash
.
The parameters which you have actually sent in the transaction are:
key, txnid, amount, productinfo, surl, hash, firstname, email, phone.

Mandatory parameter missing from your transaction request are:
.

Please re-initiate the transaction with all the mandatory parameters.

I notice that the branding changes from PayUMoney to PayUBiz for these larger amounts, which may have something to do with it.

fix: unable to save payumoney as an active gateway

Bug Report

User Story

As a user, I want to enable a PayUMoney as payment gateway so that the new user's onboarding with Give can be better UX.

Note: This issue was noticed during the DoAction event Ahmedabad 2019.

Current Behavior

Check GIF: gif

Expected Behavior

I expect to enable PayUMoney payment gateway to start processing donations

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Install Give and Give - PayUMoney
  2. Try activating the PayUMoney gateways as shown in the GIF above.

Acceptance Criteria

  • Reproduce the issue
  • PayUMoney gateway should get active irrespective of the dependencies to avoid confusion for first-time users.
  • PayUMoney Gateway should enable when USD is set as the base currency and currency switcher is installed.
  • Display an error notice when USD is set as a base currency and currency switcher add-on is not installed.
  • After fixing the issue test the donations are processed properly or not. If not, then create another issue to solve that.
  • Remove unnecessary dependencies which are creating confusion

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.