impress-org / give-receipt-attachments Goto Github PK

version 1.1.1 currently messes up the license handler for the free GiveWP plugin, indicating a need for a license. This needs to be resolved by changing the plugin author, or the Plugin URI, or the Plugin Author URL (or some combination of all three).

This is being handled in GiveWP core as well, but still may need addressing here.

The Form edit sub-menu icon is currently broken:

The code structure of the plugin needs to be updated to the standards of our newer free add-ons. Better organization, more consistent use of GiveWP classes and structure.

Here's a quick list:

• Update the main file to the same structure as our free addons class
• Ensure we're using modern language support
• Ensure we're implementing a delayed admin notice correctly
• Ensure we're checking for minimum GiveWP version correctly
• Ensure we're extending the form meta settings correctly

This is deprecated, let's remove it:

Code here:
https://github.com/mathetos/give-receipt-attachments/blob/master/inc/givera-custom-form-fields.php#L61

Details

The email tag {attachmenturl} does not display a link to the attachment. It just shows the raw tag.

Steps to replicate:

have the aforementioned plugins installed
upload and save a file in a single form in Donation Form Options >> Receipt Attachments
make a test donation
check the email receipt and see that the raw tag is displayed.

Acceptance Criteria

• {attachmenturl} email tag decode to expected value.
• {attachmenturl} email tag appear in email tag list below email message wp editor in email settings.

There's a lot of font-icon styles and other miscellaneous admin styles that can probably be cleaned up quite a lot. There's also screenshots and whatnot within the plugin and there's no need for them in there.

Here's a quick list:

• Clean up admin CSS
• Remove plugin screenshots
• Verify the need for the admin.js file or remove it or make it work right
• Related to #4 ensure we actually need the attachment.svg file.

Remove this since it's long deprecated:

Code here:
https://github.com/mathetos/give-receipt-attachments/blob/master/inc/givera-metabox-1-8.php#L101

When the donation happens, we should capture exactly what the messaging and which file was downloaded to the donation meta as a historical record.

When we generate the download link, we should add link attributes to them that are unique to the donor/donor_id and if that URL is hit we can add a note to the donation record that the file was accessed.

• Add a url param to the donation receipt table download link
• Add a Donation Note if the donor downloads from the donation receipt download link
• Add a Donation Note if the donor download from the email receipt