improving-minnesota / react-redux-timesheet Goto Github PK

We could use something like Lerna or Yarn workspaces (which would be theoretically "better" but then require tooling which I don't like), but I think just a simple monorepo with a structure like

01-set-up/
02-your-first-component/
03-routing/
04-introduction-to-redux/
final-project/

etc. will work quite well. Each folder is a standalone create-react-app project. We'd have master effectively be the start branch and we could do one of two things for "finished" branches:

1. A "finished" branch where each project is finished so that if someone falls behind they can always see what the finished result was supposed to look like
2. A "finished-example" folder where all the labs are finished in master

I think I prefer 2 for ease-of-use, but I'm not particularly opinionated. Open to suggestions, as well!

Once improving-minnesota/react-redux-api#5 is done, remove the section from the first lab.

Note: this should not be done until the above is done.

Lab 3 start, and maybe others have debugger statements that can be removed

We forgot the App.css import, so let's fix that. From @tmartensen:

either add the import './App.css'; to the file or add it to the instructions

Let's just add it instead of adding it to the instructions.

Change validate script to require yarn (instead of NPM or Yarn)

We can create an "install-all" script that will just recursively run yarn or npm install in each folder, e.g. here

This will get set up working more easily, and will simplify set-up since we can do this at the beginning.

The tests still pass, but seems like things like prop-types and Bootstrap are throwing errors that make it seem like tests are failing when they shouldn't be.

Probably a matter of just wiring stuff up.

It was suggest in last workshop to change our components to use ES7 class level arrow functions to eliminate all the binding. To essentially autobind this for us.

Sounds like a good idea to me, even as an experimental ES7 proposal, it would help eliminate a bunch of cruft from our workshop lab files.

http://blog.andrewray.me/react-es6-autobinding-and-createclass/