indexdata / metaproxy

Z39.50/SRU router

Metaproxy - a universal Z39.50/SRU router.

Copyright (C) 2005-2023, Index Data. See the file LICENSE for details.

For more information about Metaproxy refer to the documentation in sub directory doc or online.

To get more information or assistance, send mail to [email protected]. Even better, sign on to the YAZ mailing list

metaproxy's Issues

the trang conversion of metaproxy.rnc fails with a missing include file

In metaproxy/xml/schema 'make' issues this error:
fatal: file not found: .../metaproxy-1.11.1/xml/schema/filter_present_chunk.rnc (No such file or directory)

The file is declared at metaproxy.rnc:39 but the file is not in source control.
Digging in history shows that the functionality was added in 8214f56

mp::filter::AuthSimple::config_targetRegister(), filter_auth_simple.cpp

Please add fclose(fp) upon exiting the method.

SRU query response's recordSchema element is not standards compliant

When querying an SRU server that runs Metaproxy using the searchRetrieve operation, the response's recordSchema element simply mirrors the string that is provided by the client. If the client does not provide the recordSchema parameter, the element is empty.

---

Example:

Request:

?version=1.1&operation=searchRetrieve&query=dinosaur

Response:

...
  <zs:record>
    <zs:recordSchema/>
    ...
  </zs:record>
...

---

But according to the SRU standard, the recordSchema element must contain the URI of the used XML schema. There is a webpage listing SRU Record Schemas, although their use of the info: URI scheme may be outdated.

This is what the SRU specification (same in 1.1, 1.2, and 2.0) states with respect to the allowed values of the recordSchema element in a server response:

Mandatory. The URI identifier of the XML schema in which the record is encoded. Although the request may use the server's assigned short name, the response must always be the full URI.

From my cursory search the following may be the line of code that is responsible for providing the recordSchema for the response, but I am not sure:

metaproxy/src/filter_sru_to_z3950.cpp

Line 885 in 5227147

sru_res->records[i + num].recordSchema = sr_req->recordSchema;

I tested this by accessing the Library of Congress SRU server that runs Metaproxy 1.15.0.

the Makefile assumes 'trang' is in /usr/bin

In xml/schema/Makefile.am:TRANG=/usr/bin/trang
Need to detect where 'trang' is installed.

Instrumentation

It would be cool to add some Graphite instrumentation to Metaproxy, so we could see how long different filters take, and such.