Portability to Windows clients about inductiva

[hpenedones]

Thanks for raising this issue @IvanPombo and for the initiative to find fixes for it!

Let's see what we can do to find a possible deeper issue...
These seem to be the references to inductiva_sph existing so far:

https://github.com/inductiva/inductiva/search?q=inductiva_sph

We need to see whether we want to have the scenarios defined in inductiva-sph or directly at inductiva...

One inconsistency that I see is the following:
At the moment we already have a low-level call to SplishSplash in the inductiva package

https://github.com/inductiva/inductiva/blob/880a7d437f9f67b46059abd9f384b30e23a65440/inductiva/sph/splishsplash.py

However, the DamBreak scenario is not using it. Instead it is using the inductiva-sph to invoke

inductiva/inductiva/fluids/scenarios/dam_break.py

Line 124 in 880a7d4

simulation = inductiva_sph.splishsplash.SPlisHSPlasHSimulation(

Maybe we can correct things at this level? Or am I missing something?

[IvanPombo]

Thanks for the deep dive @hpenedones!

This last invoke here is creating a class, which is used to write the input file that is sent into the low-level call of SplishSplash in the API. At the same time this class holds the function run which is the one needing the resources module.

Then, it also takes advantage of the FluidProperties class that describes the fluid properties, as the fluid suggests.

We could do is not import inductiva-sph at all and provide a way to write the files in inductiva. Split things for local development and API.

[IvanPombo]

The work is in progress to break the dependencies with inductiva-sph and therefore the portability to Windows clients is fixed with that! Due to this, I am closing this issue!