inferno8 / wesnoth-era_of_magic

add-on for Battle for Wesnoth

About

Era of Magic is an add-on for Battle for Wesnoth (BfW), providing a collection of units and associated artwork. For instructions on how to use, see the BfW documentation at:

http://www.wesnoth.org/

For a discussion of this add-on, visit:

https://forums.wesnoth.org/viewtopic.php?f=19&t=20039

License

The add-on's source code is provided under the terms of the GNU General Public License version 2, or (at your option) any later version, under the same terms as the main BfW project.

Installing

This add-on is best installed through the BfW add-on interface. Please see the BfW help for more information.

wesnoth-era_of_magic's Issues

Dimensional gate recovers all advancements when load a savegame

A Dimensional Gate recover all of its advancements and the ability to level up simply by loading a savegame.

I'm wondering if this is because the unit advances have been edited directly instead of using [object]

Maybe this is a better alternative:

[event]
    name=recruit,recall,unit placed
    id=eoma_soulcatcher_event4
    first_time_only=no
    [filter]
        ability=soul_catcher
    [/filter]

[modify_unit]
   [filter]
      x,y=$x1,$y1
   [/filter]
  [object]
    id=delete_advancements
    [effect]
       apply_to=remove_advancement
       types=EoMa_Rhami,EoMa_Fire_Elemental,EoMa_Water_Elemental,EoMa_Air_Elemental,EoMa_Earth_Elemental,EoMa_Jinn,EoMa_RhamiKai,EoMa_RhamiDatu,EoMa_Fire_Avatar,EoMa_Water_Avatar,EoMa_Air_Avatar,EoMa_Earth_Avatar,EoMa_Great_Jinn,EoMa_Efreet
    [/effect]
  [/object]
 [/modify_unit]

    [allow_undo]
    [/allow_undo]
[/event]

This need to change the code on other parts too (for example when kills a unit and advances, first delete the object then advances, and in the two last scenarios, when you pay 6 gold to a free advance), but from what i've seen in various parts of the code, the solution of using object is simpler than currently exists.

EDIT: Already tested and works

If you want, I can fix it in several parts and send a PR proposal @inferno8

This PR is related, because of it I discovered that neither my fix nor the original method works correctly:
inferno8/wesnoth-To_Lands_Unknown#17

EoMa_remember_indirectly_damaged_unit lua error

Got this when Omen attacked one of Rhamis with its all around attack (BfW 1.16.8, latest development version of EoMa, debug on):

My knowledge of lua is limited but it seems like the "T" variable is not assigned properly (?).
@ProditorMagnus any ideas on how to fix this?

Triple strike xp interaction with almost leveled unit

Aim of this task is to ensure https://forums.wesnoth.org/viewtopic.php?f=4&t=54731 does not happen with 1.15.15.

Unknown unit types in the final scenario

Hey.. I'm posting here cause there's no repo for To Lands Unknown. Sorry if it's the wrong place
Had an error for unknown unit types in the final scenario
I'm playing 1.14.0-2, To Lands unknown 3.0.0. Please find attached a screenshot

Animation error when a dimensional gate kills another dimensional gate

2023-02-20.05-16-57.mp4

This has a easy fix. Simply doesn't allow one dimensional gate consume another:

[event]
    name=die
    id=eoma_soulcatcher_event3
    first_time_only=no
    [filter]
        [not]
            race=mechanical,undead
			[or]
				type=EoMa_Dimensional_Gate_II,EoMa_Dimensional_Gate
			[/or]
        [/not]
    [/filter]

Or if you prefer, one dimensional gate can be allowed to consume another without this error, I can find a way and send a joint PR proposal with #36

Minor internal issues

When creating script to transform EoMa to version suitable for ageless, I found that

• eomaprecision does not have eoma_ like other abilities
• Grand Summoner is TLU_Grand_Summoner instead of EoMa_Grand_Summoner
• Races tharis, cyclops, roc, salamander, summoner have no prefix
• MAGENTA_IS_THE_TEAM_COLOR is still used
• Some faction ids are like darkblood_rpg, others like destroyers. There is also alkamija_rpg, but summoners
• 20180525 21:12:27 error general: Mismatched parenthesis:

./units/Kharos/Child_of_Light.cfg:            halo="halo/silverwarrior-teleport[3~7].png~GS()~CS(30,30,30:100"
./units/Kharos/Mistress_of_Light.cfg:            halo="halo/silverwarrior-teleport[3~7].png~GS()~CS(30,30,30:100"

Triple strike lua error on 1.17.22

When killing third party with triple strike, the following lua error appears on 1.17.22 (-d --log-debug=wml):

Context: Raging Hydra attacked one of two Bronze Warriors. The primary target's HP was initially full, while the other unit had only 1HP (debug). When the bystander was successfully killed, the lua error appeared. This also happens during defense and in TLU.

The error does not appear on 1.16.x.

On the other hand, the similar "All around" weapon special works fine.

I am not a lua expert but it looks like [harm_unit] tries to access a non-existing unit in an array at the given index.
@ProditorMagnus Any ideas on how to fix this?

Enable summon on mixed terrain Wwf

I would expect to be able to summon on ford https://i.vgy.me/CpVbVm.png

EoMa faction unit count table

Factions:	v4.6	Planned:	v.4.7	notes
Dark Blood Alliance	40	1	41	Corrupted Wyvern (lvl4)
Summoners	38	2	40	Master Banisher (lvl4), Dimensional Gate 3
Barbarians	38		38
Tharis	37	1	38	Chainlady (lvl3)
Kharos	37		37
Runemasters	38	(-2)	36	remove: Dwarvish Cadet, Dwarvish Commando
Destroyers	35		35
Sky Kingdom	35		35

{MACRO} inside a translatable string make this not translatable

This problem happens on a lot of translatable strings. What we should do with this @inferno8 ?

Unknown unit types

Tested on 1.13.14, log has
Unknown unit type : EoMa_Dwarvish_Arctic_Scout
Unknown unit type : EoMa_Dwarvish_Arctic_Commando

WMLUNITS warnings for Era of Magic

Warning: Weapon special chance_to_hit has no name for EoMa_Perfect_Drone.
Warning: Weapon special chance_to_hit has no name for EoMa_Goblin_Kamikaze.
Warning: Weapon special chance_to_hit has no name for EoMa_Chronomancer.
Warning: Weapon special chance_to_hit has no name for EoMa_Chronomancer_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Hidden_Face.
Warning: Weapon special chance_to_hit has no name for EoMa_Hidden_Face_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Mirrorshield.
Warning: Weapon special chance_to_hit has no name for EoMa_Mirrorshield_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Mystic_Warrior.
Warning: Weapon special chance_to_hit has no name for EoMa_Mystic_Warrior_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Sky_Guardian.
Warning: Weapon special chance_to_hit has no name for EoMa_Sky_Guardian_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Grand_Summoner.
Warning: Weapon special chance_to_hit has no name for EoMa_Grand_Summoner_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Mystical_Jinn.
Warning: Weapon special chance_to_hit has no name for EoMa_Mystical_Jinn_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Neutral_Summoner.
Warning: Weapon special chance_to_hit has no name for EoMa_Neutral_Summoner_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Summons_Master.
Warning: Weapon special chance_to_hit has no name for EoMa_Summons_Master_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Sworddancer.
Warning: Weapon special dummy has no name for EoMa_Chaos_Wyvern.
Warning: Weapon special dummy has no name for EoMa_Chaos_Rider.
Warning: Weapon special dummy has no name for EoMa_Chaos_Rider_rpg.
Warning: Weapon special dummy has no name for EoMa_Chaos_Wyvern_rpg.
Warning: Weapon special dummy has no name for EoMa_Great_Wyvern.
Warning: Weapon special dummy has no name for EoMa_Great_Wyvern_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Shadow_Salamander_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Swamp_Spirit.
Warning: Weapon special chance_to_hit has no name for EoMa_Temple_Guard.
Warning: Weapon special dummy has no name for EoMa_Wyvern.
Warning: Weapon special dummy has no name for EoMa_Wyvern_Tamer.
Warning: Weapon special dummy has no name for EoMa_Wyvern_Tamer_rpg.
Warning: Weapon special dummy has no name for EoMa_Wyvern_Rider.
Warning: Weapon special dummy has no name for EoMa_Wyvern_Rider_rpg.
Warning: Weapon special dummy has no name for EoMa_Wyvern_rpg.
Warning: Weapon special dummy has no name for EoMa_Apocalypse.
Warning: Weapon special dummy has no name for EoMa_Apocalypse_rpg.
Warning: Weapon special chance_to_hit has no name for EoMa_Atokpi_Charger.
Warning: Weapon special chance_to_hit has no name for EoMa_Atokpi_Charger_rpg.
Warning: Weapon special dummy has no name for EoMa_Black_Portal.
Warning: Weapon special dummy has no name for EoMa_DarkApostle.
Warning: Weapon special dummy has no name for EoMa_DarkApostle_rpg.
Warning: Weapon special dummy has no name for EoMa_Devourer.
Warning: Weapon special dummy has no name for EoMa_Pirania_Monstruosa.
Warning: Weapon special dummy has no name for EoMa_Titania.
Error: No attack icon 'attacks/dummy.png' found for 'eoma_wesnoth_bug_3827'.
Warning: Weapon special dummy has no name for eoma_wesnoth_bug_3827.
Warning: Weapon special chance_to_hit has no name for EoMa_Savage_Roc_Rider.

Unit type and base unit type events are merged

Too many unbalanced tags corrupts other abilities. I also don't think the {OPTIONS} trick even works.

For example, TLU's ability Meditation main event handler is garbled and never run.

Test leadership+awe interaction with 1.16 and 1.17

octalot — Today at 17:13
Leadership is only supposed to overwrite other leadership if the id fields match. That's broken in 1.16, but it was okay in 1.14 and it's fixed in 1.17 wesnoth/wesnoth#6466. I'd have to test, but I'd expect [damage] to behave the same way.

Fallen Cyclops King and Um description contains markup that breaks help

Span works when hovering unit type name on sidebar, but does not let you open help menu on that type.

Detected with https://github.com/ProditorMagnus/WML_tree_tools.

AE_mag_Fallen_Cyclops_King This unit is from The Era of Magic. Its coding and art were done by inferno8.

The following extract has been compiled by golem XTC1-3 from excavation site 3, property of cartographer Silos:
<span font-style='italic'>-(...) most unusual. The subservient dead flesh (...) animated using (...) (new?) (...) useful. Much (intelligence?) easier.
- New (...) (milestone?). Necromancy reigns (a supreme?) dark art. Artisans of living flesh will (bow to?) our thrulls (...).
-They destroyed them. But they don't (...). No (...) control. It (...) conscience. We (cannot?) (...).
- High warlocks have (barricade?) inside (...). Population (...) alone. (...) slaughter. (must?) flee. (King?) fled by the (...) gate. (...) collapse (...).
- Battle lost (...). They (are?) legion. They (not?) stop. They (only?) destroy. They all destroy. (...) prime command prevails (...). What have (we?) done. (...)failure (...).
- They share (...) mind. (...) not necromancy (...). Do not engage (...) it will grow (...) more intelligence. Do not repeat (....). If you (read?) flee. You (...) doomed.</span>

AE_mag_Um This unit is from The Era of Magic. Its coding and art were done by inferno8.

Ums (<italic>text='um'</italic> in single) are the Sky Kingdom's top secret weapon. They represent the pinnacle of Sky Kingdom's biological enhancement technology. Their creation is a result of long, hard studies and experiments, requiring many factors, including a fit Mu specimen, genetic modification, and extreme amounts of nutrition. Their name means 'mind' in the language of one of the nations the Sky Kingdom have observed. The power of the Ums is beyond that of any other artificial being the Sky Kingdom has created.

Improve swift strike code

+#define WEAPON_SPECIAL_AE_MAG_SWIFTSTRIKE VALUE
+    [attacks]
+        id=AE_mag_swiftstrike
+        name= _ "swift strike"+" +"+{VALUE}
+        description= _ "When this attack is used offensively, the attacker gets +1 bonus strike."
+        apply_to=self
+        active_on=offense
+        add=1
+    [/attacks]
+#enddef

If it takes {VALUE}, then value should affect function of the ability. I also dont see why this should be forbidden in rpg.

Also noticed FROZEN_REGENERATION looks like it does not work on mixed terrain like ice+forest.

Visualize kamikaze range differently from melee

I think Era_of_Magic_Resources\images\icons\profiles/kamikaze_attack.png should not look same as melee. Solution with my art skills would be to make it red.

Diff review notes

Possible mistake in the translators guide? Else could use a bit of clarification?

Here,

wesnoth-Era_of_Magic/translations/translators_readme.txt

Line 6 in e8a23c9

2. Open TLU_raw_translation_file.po (usually located in add-ons/Era_of_Magic/translations/

I can't find that doc, actually I don't know were TLU is hosted at, in the case it is open source already.

But there is this EoMa_raw_translation_file.po. Should translators_readme.txt refer to that doc instead?

WEAPON_SPECIAL_EOMA_STUN modifies chance to hit

#taken from EFM
#define WEAPON_SPECIAL_EOMA_STUN
    [chance_to_hit]
        id=eoma_stun
        name= _ "stun"
        description= _ "This attack puts enormous pressure on the enemy, disrupting his ZOC if a hit is landed. Not active on defense. Does not work on units that do not have a ZoC."
        apply_to=opponent
        active_on=offense
        value=60
        cumulative=yes
    [/chance_to_hit]

Description does not tell anything about change to hit. No in game impact, all attacks with it have another chance_to_hit special too.

Collector issues

1. {MODIFY_UNIT id=$second_unit.id max_hitpoints $maxhp} needs to add [object] instead to not lose added hp after unit rebuild
2. eoma_collector_offensive needs to be cleared after attack even if unit did not die

Review fight and kill experience in multitarget attacks

1. Decide and comment for each multitarget ability what should happen with experience
2. Test each ability and make sure it works that way

Re #29 (comment)

making better use of the help system

If you have three abilities which do the same, but differ slightly, let's say the hit and run ability, it will be listed thrice in the help. The general rule is, an entry in the help is created for each ability/trait id.

What the ability actually does has nothing to do with the help entry, abilities definitions are inserted with maros into the unit definition, and can thus be tailored for each unit.

I found a good way how to use this approach in WoL and EoC
In this example, all elementals have the same ability – they get on their terrain +5 hp:
https://github.com/ProditorMagnus/Ageless-for-1-14/blob/master/data/general_data/abilities/resurgence.cfg

One gives the abilities the same id, name and a description which suits all, but gives it depending on the used macro a different implementation.

In some way the mainline's leadership ability did sth. similar until 1.12, by giving different implementations in the macro, and filtering by level which one is active.

It would be good to crowd the help less.

Test WEAPON_SPECIAL_EOMA_NOCOUNTERATTACK implementation with [disable]

Maybe removes need to explicitly filter for berserk.

message to inferno8

the bfw forum seems to be unable to load for me at the moment (as well the entire bfw site, possibly due to overcrowrding), while other sites aren't. If this continues, we might have to resort to other methods of communication, like e-mail.

EDIT: nevermind, works now.

Awe immunity as undrainable

@inferno8 @ReynBolt what you think of additionally having undrainable status give immune to awe? Magical race is already immune so there should be little if any changes in EoMa units.

Magic absorber reduces 99% resist to 70%

Matriarch of emptiness has 99% resists, but with ability they act as 70%.

Issues revealed by schema validation

ProditorMagnus/Ageless-for-1-14#40 (comment)

Water elemental regen is described to not work on ford, but works

Solution is changing either text or filter.

Harbinger's chaotic vortex leads to a lua error

Minor issue, tested using the latest release with wesnoth 1.16.6

Use the chaotic vortex, everything looks ok, when the faction with the unit that was just hit gets its turn there's an error saying that set_variable_local expected a string but got a boolean
(screenshot at https://imgur.com/a/ZQJ2fT7, I don't know how to copy&paste that out of wesnoth)

heat aura reduces high cold resistance to 50%

should filter base value to not affect those over 50

Status of translations

Language	Verified	Fuzzy	Missing
German (de)	496	643	1362
Spanish (es)	2501	0	0
French (fr)	1725	395	381
Hungarian (hu)	237	416	1848
Italian (it)	243	416	1842
Polish (po)	2444	23	34
Russian (ru)	272	310	1919
Chinese (zh_CN)	310	483	1708

It can be seen that there is a large amount of missing strings in German, Hungarian, Italian, Russian, and Chinese. So I'd like to propose and step forward to handle these through machine translation (i.e. no guarantee about quality. See also Cunningham's Law).

French and/or fuzzy strings can be updated too, if so desired.