influxdata / changelog Goto Github PK

InfluxDB 2.0 branch uses lightweight tags, which are currently skipped by generate when looking for the next most recent tag.

Changelog looks at the most recent tag, instead of the most recent tag that is a parent of the current revision. The result is that an old patch release cannot be autogenerated.

Example workflow:

1. Given that tags v0.39.0 v0.38.0 exist
2. Checkout the older version on a new branch: git checkout -b release/v0.38.x v0.38.0
3. Run nextver: go run github.com/influxdata/changelog nextver the reported version is v0.39.1 instead of v0.38.1.

If a non-annotated tag is created (such as without -a or -s) and generate is used, the changelog generator cannot retrieve the object for the previous release and cannot generate the changelog.

Please add missing LICENSE file to the repository.

Recently, we tried to use changelog to generate a point release. At the time, v0.87.0 was the most recent release. We wanted to make a release the v0.83.x series, the result being v0.83.1. changelog nextver was returning v0.88.0 as the next version. Upon further investigation, it's because the cherry-picked change to v0.83.x was a feat change, so changelog was rightfully trying to say "This can't be a point release." However, it's still incorrect, because v0.88.0 would end up missing changes that were added between v0.83.0 and v0.87.0, so that release would be wrong.

DOD:

• When running changelog nextver for a point release, an error should be returned if a non-fix oriented change is detected.