infopark / scrivito_google_maps_widget Goto Github PK

When using the widget and having scrivito.js only included for logged in users, this line causes a "scrivito is not defined error":

https://github.com/Scrivito/scrivito_google_maps_widget/blob/master/app/assets/javascripts/scrivito_google_maps_widget/editing.js.coffee#L36

The readme states that one should include Google's JS:

Include the Google Maps Places JavaScript library in your application.html.erb:

but this is not necessary if the website is using the maps widget for specific page types only, for example. The motivation to exclude Google's JS would be improved loading speed or reduction of data usage.

Could we update the JS to check for presence of google before initializing? See https://github.com/Scrivito/scrivito_google_maps_widget/blob/master/app/assets/javascripts/scrivito_google_maps_widget/application.js.coffee#L57 for example. Other source location are affected as well.

I suggest to just skip the initialization if Google JS is not loaded.

http://rubygems.org/gems/scrivito_google_maps