[Header.replace] function is not working properly about httpaf

[seliopou]

Hello! From your description it sounds like the same bug that was fixed in #157, which is in the latest release (0.6.5). If you're on a previous release, I would suggest upgrading and seeing if that fixes your problem.

[lyrm]

Well, I have the right version. I looked at the function and it seems there is still an error in it: the internal function [loop] is recursively called with [name] instead of [needle] which is an issue in the case where these values are not equal...

So it should be :

let replace t name value =
  let rec loop t needle nv seen =
    match t with
    | [] ->
      if not seen then raise Local else []
    | (name,_ as nv')::t ->
      if CI.equal needle name
      then (
        if seen
        then loop t needle nv true
        else nv::loop t needle nv true)
      else nv'::loop t needle nv seen
  in
  try loop t name (name,value) false
  with Local -> t

Sorry, I am still not extremely familiar with git so I will not do a PR as it will take me sooo much time.

[lyrm]

(Note: I actually thought to check for current issues but not the resolved ones before writing here. Neither did I check if I was using the latest release. Not a problem here, but I will keep this is mind for next time !).

[seliopou]

I think that you may have mistyped something. The code block in your previous comment is exactly the implementation that is in master.

[seliopou]

I see the problem. I thought that fix was in 0.6.5 but it's not. However, the bug appears to be fixed in master.

[seliopou]

The fix will be in the next release.