inkandswitch / capstone Goto Github PK

🙃

Moving an item to the "bottom" of the board should not delete it, because the shelf is logically there.

We should perhaps also disable delete at the sides (because this currently conflicts with the gesture for creating a new board). But let's start with at least preventing deletion at the bottom.

ink-and-switch/capstone $ yarn clean
yarn run v1.10.1
$ rm -r dist .data
rm: .data: No such file or directory
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Should probably be -rf or remove the .data target.

Steps to reproduce:

1. Turn on Ink mode
2. Drag stylus from edge of the screen

What happens: a board is created and a line of ink is left.

What should happen: either create a board or make a line, but not both.

Currently if you "Send to capstone" but the Capstone app isn't running, the send action appears to open the Capstone app, but not receive the transfer.

Ideally it'd both open the app and receive the transfer.

If that's not possible it's less obvious what to do. But probably not say "OK" but then not actually complete the transfer.

Steps to reproduce: make a board inside another board, then zoom out to your root board. Weird icon appears in it:

Better would probably be to render the second layer board as a blank rectangle.

It's possible to get runtime errors for empty/missing/not-yet-loaded arrays.

martin just saw this on setup when he loaded his desktop workspace on his pixelbook. i didn't, so it must be a bit racy

I see this error in my console: "Unchecked runtime.lastError while running tabs.executeScript: Could not load file 'content.js' for content script. It isn't UTF-8 encoded."

ERROR in /Users/matt/Workspace/ink_and_switch/capstone/src/components/HTML.tsx
ERROR in /Users/matt/Workspace/ink_and_switch/capstone/src/components/HTML.tsx(91,3):
TS1117: An object literal cannot have multiple properties with the same name in strict mode.

ERROR in /Users/matt/Workspace/ink_and_switch/capstone/src/components/HTML.tsx
ERROR in /Users/matt/Workspace/ink_and_switch/capstone/src/components/HTML.tsx(91,3):
TS2300: Duplicate identifier 'Fullscreen'.

Child

Fullscreen defined twice in style: https://github.com/inkandswitch/capstone/blob/master/src/components/HTML.tsx#L91

When dragging a card it disappears under the shelf until you release it and then it pops back over the top.

Would expect stationary cards on a board go under the shelf, but moving cards float above.

I pressed the "Clip to Capstone" button on this URL: http://www.vldb.org/2019/?important-dates on Chrome on desktop, and saw the scaled-down webpage correctly show up in Capstone on that computer. However, on the Pixelbook (having previously been connected to the same workspace URL), the shelf displays only a white rectangle containing the text "Loading...". I have tried this with a few different webpages, and it doesn't always happen, but does seem to happen reasonably frequently. It seems to be accompanied by the following exception in the console:

ClientPeer.ts:58 protocol.onerror ED-Hr Error: Remote timed out
    at d._ontimeout (index.js:453)
    at d.i (events.js:165)
    at d.r.emit (events.js:78)
    at d._kick (index.js:196)
    at index.js:96
a.on.e @ ClientPeer.ts:58

protocol.onerror %s
a.on.e | @ | worker.js:8

Reported by Martin:

index.ts:202 Uncaught Error: change.seq (5) != feed.length (8) for 647C4XLAc4YKUt1JczmbRjGZZ66ZBQYPeVqXtpjVtkTq
    at Array.t.append.n (index.ts:202)
    at index.js:59
    at o (index.js:12)
    at a (index.js:40)
    at d.i [as _callback] (index.js:1218)
    at d.callback (index.js:161)
    at d.onwrite (index.js:156)
    at FileWriter.t.onwriteend (index.js:127)

Same animation &c.

STR:

• import card
• drag to board
• notice that resizing the shelf makes the cards move up and down
• check DOM tree in inspector
• see that the cards are still on the shelf!

I see this:

(node:3676) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead

Let's discuss what's the best approach for this.

I had the Sidecar open on my Mac. Capstone tablet went to sleep and woke back up. Tried to drag an image in and:

Quitting Sidecar didn't help, but restarting Chrome brought me back to a functioning state.

• Boards should be paper colored
• Filter for nested boards should be different
• Stuff outside the board you're zooming in to should fade as it progresses (and visa versa) in the other direction

@GokcenK has all the canonical details for this.

Saw lots of this on Matt's Austin demo.

https://cl.ly/dfe40307bd06

Steps to reproduce:

1. Make five or so blank boards
2. Zoom in on one or two of them and add drawings, images, or clipped webpages
3. Now zooming in and out gives a noticeable flicker of "Loading.." on everything, including blank boards

Try clipping e.g. the page https://medium.freecodecamp.org/ux-best-practices-how-to-design-scannable-app-screenshots-89e370bf433e. The images inline in the post won't show up in the clipped version.

It's unclear what it means to resize the shelf in the desktop app, especially since it doesn't have scroll bars in any configuration nor does it enforce aspect ratio.

My suggestion until we have something designed to handle resizing is: force a fixed size of the window that yields a content space with aspect ratio equal to the full shelf (and show the full shelf in that content space).

We need a more complete design here, but to start it should either:

• Not be possible to zoom out at all
• Limit you to a small amount of zoom, perhaps leaving a 1cm border of blank space around the board at it's greatest extent (in this case, it should also animate zooming back in that small amount on release)

cc @GokcenK

if we don't keep the board it just vanishes instead of animating out

• The black border and the corner radius on the web clip preview cards is thicker than it's supposed to be. The border stroke is 1px and the radius is 6px (these are 2x values). Here's a side by side comparison (the one on left is from the app, the right one is from the design doc)

• The url on the zoomed-in view is also bigger than the design. Here's the values from the design doc:
  • Roboto medium 24 (2x value)
  • Bar height is 60px (also 2x)

Repro steps are straightforward.

1. Uninstall the capstone extension
2. Install the extension
3. Right-shift to see debug menu
4. Paste a workspace URL into the debug panel from a fresh capstone on your desktop
5. Put something on the shelf from your desktop machine (it should appear visible on the pixelbook)
6. Try moving that card onto the board you're looking at. (It won't work but it will appear to.

Result:
See that the card hasn't actually been relocated -- if you resize the shelf the card moves up and down with it!

Not actually visible right now, but we should probably fix this at some point.

The board zoom out animation should look just like the zoom in animation, in reverse.

Currently the board that's being zoomed away from is handled correctly, but the enclosing board doesn't move during the animation, which is the part that's incorrect.

If an outer board has a non-trivial number of images (say, 10) and you zoom out towards it from an inner board, when the zoom is complete all the cards on the outer board will flash "Loading..." and be blank for a bit before filling in.

This breaks the zooming illusion and slows down the user.

We have a non-pink pen UI designed which we hope to have in time for the demo.

If i long-press a card with my stylus to make the “inspect” context menu show up, then move the card with stylus, i get a mirrored card (without ever having had my finger on the screen)

Can't zoom into sub-boards :( Pinching in animates but we never transition to the new board.

Currently, if you start to zoom into a board just a tiny bit and then let go, it snaps into the inner board.

Instead, it should go back to the outer board. (In either direction, it should be animated.)

We can set the threshold at 50% of the way zoomed in for now (more zoomed in than this = go to inner board, less zoomed in = go to outer board) and then play with it from there.

Cards from the clipper are all placed on the the exact same position on the shelf.

This makes it hard to see what you've clipped and to pick something other than the most recently clipped item up.

We suggest laying them out as you might papers on a desk - most overlapping but with enough peeking out from under successive card that you can know everything you've clipped at a glance and select any one directly. See screenshot below.

If you drag an item from the board to the shelf, it flashes briefly but noticeably on release.

The same thing happens in the other direction.

This board:

Renders a zoomed-out preview like this:

Images and web clippings are missing.

We don't have a good reproduction case, but that's what was blocking Martin's app and preventing navigation.

If you start a stroke on an element which isn't wrapped in a StrokeRecognizer the strokes aren't drawn. Two examples are:

• Pinch to go fullscreen on a text card, try to draw with pen. No stroke
• Open archive, draw a stroke which doesn't begin on a card. No stroke. (For now, the archive will soon have a StrokeRecognizer to create boards)

We might decide to do nothing about this. Just calling it out.

They currently get a blinking cursor when tapping (though the keyboard isn't summoned)

Not sure how it got so big...

STR:

• copy content
• click in capstone
• Press Ctrl-V

Result:
Nada.
Expected:
Content appears on shelf.