inpsyde / multilingualpress-yoast-seo-sync Goto Github PK

Hi,

this plugin simply does nothing, obviously it is outdated?
No YOAST settings are copied from one post/page to those of the linked language.

YOAST 7.1 free
WP 4.9.4 multisite
PHP 7.0.25
MultilingualPress 2.11.0

Steps to reproduce

1. Install latest versions of MLP Yoast (2.1.1) and MLP (3.3.0)
2. Connect one site
3. Create a new post category term

What should happen
I should see the Yoast tab correctly in translation metabox.

What happened instead
A fatal error is displayed:
Fatal error: Uncaught DomainException: Empty Term. in .../wp-content/plugins/MultilingualPress-Yoast-SEO-Sync/src/TranslationUi/Term/Repository.php on line 41

File:

Release says 2.1.3.
https://github.com/inpsyde/MultilingualPress-Yoast-SEO-Sync/releases/tag/2.1.3

Best regards.

Steps to reproduce

1. Install latest versions of MLP Yoast(2.1.2) and MLP (3.3.0)
2. Connect one site
3. Create a category and fill the description using the WYSIWYG editor (and add some markup)
4. Go to the linked category in the other language
5. Save the linked category in the other language
6. The HTML markup in the original language is removed

What should happen
The HTML markup should be kept.

What happened instead
The HTML markup is removed.

Notes

• The WYSIWYG editor is added to term descriptions by the Yoast plugin
• MLP loads meta boxes for all terms on every term page
• The save action used by MLP removes all html tags from the description

We need exactly this plugin for Multilingual Press 3.x with WP 5.x.
Support told us, the development for this plugin already started.

Is there any scheduled release date?

WP: 5.2.1
MLP: 3.2.0
MLPYSS: 2.0.0

The "Yoast SEO" sync-tab does not appear on (custom) taxonomies. All tested taxonomies were checked as translatable.

Description
Yoast plugin adds advanced editor to term description, in MLP metabox, the term description field value is sanitized using sanitize_textarea_field resulting in HTML tags removed in remote term descriptions when term is saved.

Steps to reproduce the issue

• Create a post category and in the description create an H1 tag title.
• Connect it to another site through MLP translation Metabox.
• Once connected, edit category in the remote site, click update button.
• Go back to source site edit category.

What should happen?
H1 tag in description should exist.

What happened instead?
H1 tag in description does not exist.

Proposed solution
In order to prevent the above, we can use wp_kses_post which also sanitizes but allows basic HTML tags. In order to do so, in src/multilingualpress/TranslationUi/Term/MetaboxFields.php in FIELD_DESCRIPTION metabox field, replace sanitize_textarea_field to wp_kses_post.

Hi there,

with the SEO-Sync plugin activated saving a post sometimes leads to There has been a critical error on your website. Please check your site admin email inbox for instructions.

WP: 5.3
Editor: Classic Editor

WP_DEBUG_LOG:

[01-Apr-2020 08:40:29 UTC] PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Inpsyde\MultilingualPress\YoastSeoSync\TranslationUi\Post\Field\Title::sanitize() must be of the type string, null given, called in /wordpress/wp-content/plugins/multilingualpress/src/multilingualpress/TranslationUi/Post/MetaboxField.php on line 99 and defined in /wordpress/wp-content/plugins/multilingualpress-yoast-seo-sync/src/TranslationUi/Post/Field/Title.php:53
Stack trace:
#0 /wordpress/wp-content/plugins/multilingualpress/src/multilingualpress/TranslationUi/Post/MetaboxField.php(99): Inpsyde\MultilingualPress\YoastSeoSync\TranslationUi\Post\Field\Title::sanitize(NULL)
#1 /wordpress/wp-content/plugins/multilingualpress-yoast-seo-sync/src/TranslationUi/Post/MetaboxAction.php(209): Inpsyde\MultilingualPress\TranslationUi\Post\MetaboxField->requestValue(Object(Inpsyde\MultilingualPress\Framework\Http\PhpServerRequest), Object(Inpsyde\MultilingualPress\TranslationUi\MetaboxFieldsHelpe in /wordpress/wp-content/plugins/multilingualpress-yoast-seo-sync/src/TranslationUi/Post/Field/Title.php on line 53
[01-Apr-2020 08:40:35 UTC] PHP Warning:  Illegal string offset 'plugin_name' in /wordpress/wp-admin/includes/class-wp-privacy-policy-content.php on line 96
[01-Apr-2020 08:40:35 UTC] PHP Warning:  Illegal string offset 'policy_text' in /wordpress/wp-admin/includes/class-wp-privacy-policy-content.php on line 97

Also there are some non-unique-id warnings on my console which can be tracked down to MLP metabox using the same IDs for the taxonomy inputs as the core-sidebar.

Let me know if you need any further information