input-output-hk / lace

The Lace Wallet.

Lace

The Lace monorepo.

Yarn Workflows

Structure

Apps

• browser-extension-wallet

Packages

• common
• core
• cardano
• staking
• ui

Dev commands

yarn [app] [command]

Available [app] options:

• browser (./apps/browser-extension-wallet)
• staking (./packages/staking)

Available [command] options:

• build
• build-deps - build only dependencies of a given app
• watch - build and watch
• watch-deps - build and watch only dependencies of a given app

You can mix them together.

Examples:

• yarn browser watch runs the watch command for all dependent workspaces of the browser-extension-wallet package and for the browser-extension-wallet app itself.
• yarn staking build-deps builds all dependent workspaces of the staking package except the staking package itself.

Audit

Lace has been independently audited and manually verified by external auditor, FYEO, so the Lace team can improve code quality and security – giving you greater peace of mind. You can view the full report at lace.io/lace-audit-report

lace's Issues

Wrong Tooltip Currency

In lace (Current version 1.5.0) after changing the currency in preference to a value different from USD, for example EUR. The tooltip in the staking part (Total Staking, Total Rewards) is using the correct conversion rate for EUR (the numeric value) but it's still displaying "USD Value $".

Token mint and burn transactions get their type swaped

I'm the author of the transaction editor webapp https://arsmagna.xyz/apps/web-tx-editor/

I want to add support for lace, yet I noticed that when minting Mary Era tokens the transaction type swaps mint and burn.

For example the mint transaction (of 1 newtoken) shows up as Burn

84a4008182582088df85acd79717ba93219a63ec40ac1ce8f3f5759fbb7a92ff25c6bb962132c302018182583900f8db8aa62c4fc043068470ac0207aaccdb202a952b95ef779c89a4deac11d398c516dfdb03159365674087e1f5a716bdb8db4569b469ecf6821a0095fc97a1581c96580c78a23b7191949338c3586ef3eb654c8d66880504ef45eb8759a1486e6577746f6b656e01021a000299e909a1581c96580c78a23b7191949338c3586ef3eb654c8d66880504ef45eb8759a1486e6577746f6b656e01a101818200581cf8db8aa62c4fc043068470ac0207aaccdb202a952b95ef779c89a4def5f6

Conversely the Burn transaction (of 2 newtoken) shows up as Mint
84a40081825820fa510f9fe5586958d3224e4b0ff6e72363c29cf9e92602814d7441dbf706584600018182583900f8db8aa62c4fc043068470ac0207aaccdb202a952b95ef779c89a4deac11d398c516dfdb03159365674087e1f5a716bdb8db4569b469ecf61a0049b8bb021a0002928509a1581c96580c78a23b7191949338c3586ef3eb654c8d66880504ef45eb8759a1486e6577746f6b656e21a101818200581cf8db8aa62c4fc043068470ac0207aaccdb202a952b95ef779c89a4def5f6

This is confusing for the user. Especially since the user can't really inspect the transaction.
Although the more pressing issue for me is #60, since when the user cancels I can't catch the exception.

`signData` function from CIP30 api doesn't throw error when user cancel signing

When user cancel signing the dApp connector prompt, signData function needs to throw error to notify the app that user declined the transaction.

Specified at https://cips.cardano.org/cips/cip30/#errortypes TxSignError type

Currently, Lace doesn't throw error, and thus application fails to recognize that user declined to sign.

Incorrect balance

I'm investigating an incorrect balance. The wallet has only one address in it:
addr1q9v93qpsty4f5vs97ck6q3ges5uq63vhwy0yyagqhfkks9pl07wn3w4lhyys6ansn35hq5qjzkpk8ntjrf004w2j9yaqh8lkcd

That address has 6 UTXOs that amounts to 33,682,447 Lovelace.
https://cexplorer.io/address/addr1q9v93qpsty4f5vs97ck6q3ges5uq63vhwy0yyagqhfkks9pl07wn3w4lhyys6ansn35hq5qjzkpk8ntjrf004w2j9yaqh8lkcd/utxo#data

Cexplorer is showing 33.68 ADA:

Cardano scan is showing 33.68 ADA:

as well as other explorers.

Nami mention how much is "locked with asset" although amount to 33.68 as well:

But Lace 1.8.0 is display 34.39 ADA:

Feature: add U2F support via WebAuthn

Description: I would like to add WebAuthn support so hardware authenticators like YubiKey's can be used when making transactions along with a setting to enable and register/remove keys.

Acceptance criteria: It works. No weird noises.

Tests: I leave this to the team.

Incorrect insufficent funds error on dApp connector.

https://github.com/input-output-hk/lace/blob/35bfd44b1351e41d68fad6886915354ecee4cdc2/apps/browser-extension-wallet/src/features/dapp/components/ConfirmTransaction.tsx#LL192C1-L198C8

Here, it makes an assertion:

      if (totalCoins >= availableBalance?.coins) {
        setInsufficientFunds(true);
      }

which is incorrect as it doesn't consider transaction inputs from scripts.

It should be

      if (totalCoins >= availableBalance?.coins + <TxInputs>) {
        setInsufficientFunds(true);
      }

Scaling width of nft using calc() not proportional

In the Lace NFT UI elements, the use of width calc(100% + 2px) after doing the same in height results in disproportionate dimensions which make the nft look dithered.

Introducing a Firefox add-on

Sorry but Lace is v1.5 and still no Firefox add-on?

I mean, I will never use Chrome.. Never.

Two feature-requests which would enable decentralized tx-chaining

tl;dr:

1. signing multiple txes at once
2. spending utxos which are not yet in the ledger (maybe with a warning)

More details here:
input-output-hk/nami#857
input-output-hk/nami#856
blockfrost/blockfrost-backend-ryo#120

Lace sometimes looses wallet details

i had the issue twice now that when opening lace it shows the create wallet screen instead of my existing wallet.

closing the wallet and reopening it does not fix the issue but restarting chrome fixed the issue.

BitBox02 support for lace wallet

Hello.

There currently appears to be no Wallet UI for Cardano that is compatible with BitBox02 to use for dApps.

There is adalite that allows to transact and stake Ada with the BitBox02, but it cannot be used to interact with dApps.

I would like to kick off a discussion to explore BitBox02 support for lace. It would allow for a new user base to enter the Cardano ecosystem.

BitBox02

The BitBox02 refers to https://bitbox.swiss/bitbox02/

I was unable to find numbers for amount of sold units. If such a number is needed to evaluate the priority of BitBox02 support, then I can try to inquire with the manufacturer. I do expect that the BitBox02 is less popular than Trezor and Ledger, especially in the big US market, because it is of Swiss origin, so is more likely to be used by European users in the first place.

bitbox-bridge, bitbox-api

The bitbox-bridge allows to interface with the USB device. It is unclear to me if the bridge is capable to serve the whole set of requirements for Cardano dApps. On this page it does say:

With the BitBox02, you can connect to any DeFi Dapp

So perhaps technically it is possible.

BitBox does provide its api for 3 languages:

bitbox-api-rs
bitbox02-api-go
bitbox02-api-js

I expect that the bitbox02-api-js is of relevance in the case of lace.

How Adalite uses bitbox

Adalite does already interface with the bitbox-api in its TypeScript:
shelley-bitbox02-crypto-provider.ts
bitbox02-api.d.ts

This is probably a good reference point, along with the api itself - to get an overview.

Next steps

I do wonder how easy or difficult it will be to add BitBox02 compatibility to lace? Is this something we can explore? How can we get started? I do own the BitBox02, so perhaps I can be of service for this task. And I am a programmer too, albeit not experienced with TypeScript and the like.

Activity tab shows incorrect ammount

this tx shows as 600K ada tx in my activity tab.

https://cexplorer.io/tx/85101faf0babb24201204c595d7d207c10ee8cb5a6f1114a36f77f96849c5a15#data

I think its because its a smart contract tx. but I think the wallet should just show just the amounts that go to / from my wallet address.

memo incorrectly encoded in metadata

The memo is incorrectly encoded as a single string in the meta data (msg).
However, per specification in CIP-20: "The message content has the key "msg": and consists of an array of individual message-strings. "
Reference: https://github.com/cardano-foundation/CIPs/blob/master/CIP-0020/README.md

Expected result:

{
  "674":
         {
           "msg":
                  [
                    "memo"
                  ]
         }
}

Actual result:

{
  "674":
         {
           "msg": "memo"
         }
}

Implementing a (subscription) payment solution on wallets as a standard.

I am curious about how a 'subscription' based pull payment model could ever work on the Cardano network.

I am wondering if anyone has any thoughts about how this could be implemented. I would like to see a world where common SAAS payment solutions can be paid with ADA or other tokens.

Stake Pool not found

Looking for some more information on the bug where a stakepool isn't found on the staking page. Lace seems to be the only one not listing our pool. Our pool might be a bit unique as it was originally registered under another ticker and name and then rebranded. I'd be happy to provide any information needed to get this resolved.

Ticker: BDRK
Pool Name: Bedrock Staking

`signTx` probably leaks an async exception on cancelation (instead of rejection)

Hi,

Thanks for building Lace!

When I'm testing signTx and I cancel the operation from Lace I'm getting (probably leaking js-sdk error):

Uncaught (in promise) Error {code: 2, info: 'user declined signing tx', name: 'eo', message: '', stack: 'eo\n    at Object.signTx (chrome-extension://gafhhk…jkeiendhlofajokpaflmk/js/background.js:104:450366'}

And similarly to #34 I'm not able to catch proper TxSignErrorCode rejection.

getUnusedAddresses() function from Dapp Connector is returning empty array

After connecting to the dapp api and calling getUnusedAddresses() I always get an empty array but as the protocol described it should return the hex addresses

api.getUnusedAddresses(): Promise\
Errors: APIError
Returns a list of unused addresses controlled by the wallet. 

remove all non versioned live-* services

Cannot sign message to get signature

I used signMessage in useCardano function to get the wallet's signature. but it reported missing password error

Sending multi bundle assets using HW Wallet does not work

Hi,

With an account connected with Ledger Nano, I tried to send a few ADA to 15 different addresses, using the UI to construct a multi bundle TX.

The operation went well but the transaction was never submitted to the blockchain. The Ledger device signed the TX correctly, showing all the 15 output addresses with the respective ADA value, but once the TX was signed it was never published on-chain and the UI did not report anything

Incorrect tx validation

Recently I test Lace wallet with minting encoins and came across a bug in Lace.
In wallet mode I mint Encoins and lock an amount of ada in Encoins. My wallet send Ada to Encoins smart contract and I get Encoins tokens.
Lace wallet requires that my wallet has balance that is equal to total amount of all locked Ada in Encoins smart contract. For example. If I lock 41 ADA in Encoins and total amount of locked Ada in smart contract is 1200 then Lace allows me to make tx if balance of my Lace wallet is more then 1241 Ada.