insalan / insalan.fr Goto Github PK

Kind of unimportant, but

• GET requests should not modify stuff - table selection should be done via POST (TournamentBundle\Controller\UserController::placementAction)
• Query parameters should be used in very specific cases like filtering

As the team name is used in the password hashing as follows :

$container = $this->getConfigurationPool()->getContainer();
$factory = $container->get('security.encoder_factory');
$encoder = $factory->getEncoder(new User());
$e->setPassword($encoder->encodePassword($e->getPlainPassword(), sha1('pleaseHashPasswords'.$e->getName())));

it is currently impossible to change the team name without changing the associated password !

The team master can cancel the team creation if :

1. None of the registered members actually paid
2. The team is not validated (inherited from 1)

This can be done with a button displayed on the team registering page.

File reglement.PDF:

• Title is InsaLan X, should be InsaLan 11.
• Dates are 4 au 7 février 2015, should be 4 au 7 février 2016.

Should add some ajax to avoid reloading the entire page each time you validate one player.

Paypal is causing us too much trouble.

During tournament registration, replace Pseudo section with "Login with Steam/Battle.net" buttons (when applicable).

See :
https://steamcommunity.com/dev
https://dev.battle.net/docs/read/log_in_with_bnet

When a tournament is closed

• Remaining unfinished team should be erased
• On the tournament registration page, registration should be properly displayed as closed or not displayed at all for those who participates in the tournament
• Tournament public page should be updated as well to display results

Tested on the lastest Debian 9 (9.5) and Ubuntu 16 LTS (16.04).

Before proceding for contributing, the following packages must be installed :

Should it be added to CONTRIBUTING.md or README.md ?

Almost identical as the cash (or check) method for players.
This need a backend for the partner so slots can be marked as paid and thus reserved.

There is no value to test the archive part of the website.

• Refunding
• Browse history
• Better implementation
• Add other 3rd party services (currently using only Paypal)

Add section with media (photos,videos,streams), links to tournaments and sponsors of previous editions.

Should be tested against composer requirements.

As a user
I want to be able to ask for a refund
So that I don't have to find a contact address, send a mail, and pray for a quick answer (or send a Facebook message, or smoke signals or something).

As a treasurer
I want to be able to see the list of user-asked refunds and confirm them
So that I don't have to do it manually through mails and the database interface.

As a treasurer
I want to be able to manually register a payment
So that I don't have to do it manually through the database interface (especially useful for "Amicaliste" fares).

We should use a CSS framework.

Candidates are :

• Bootstrap
• Primer

Customisable ?

Needs some brainstorming

If a captain removes players from a team that has already been validated, the team can end up in a state ineligible for validation (i.e. less than the required number of players, or less than the required number of paid players), but currently it is not invalidated.

Example: https://www.insalan.fr/tournament/9/public/team

Improve clarity when reading old tournament report

When there is no tournament in an <article>, it should be hidden.

As a team captain
I want to change the team name
So that the admins don't have to do it for me.

As a team captain
I want to appoint a manager
So that the manager doesn't have to pay full price.

This bug has been encountered during the live event.
The user was not able to see his matches.

I just investigated the problem. You can find the user inside the insalan.fr database.
I will use its internal id instead of his username to preserve his privacy.

So, the User ID is: 3416
This user has 2 identical players name:

• One for Hearthstone, with ID: 3531, validated, and indeed was part of this tournament (the correct player in our investigation)
• One for Overwatch, with ID: 3532, not validated, doesn't participate to this tournament (the incorrect player in our investigation)

Now, we will get a look at the tournament administration page, which show the Player ids in its source code. You can access the hearthstone page at this URL:
https://www.insalan.fr/tournament/27/admin

If you inspect the row in the table corresponding to the username, you will see:

<span class="arrived_status_3531">
    <button class="arrived" data-url="/tournament/27/admin/player/3531/toogleArrived/0" data-id="3531" onclick="changeArrivedStatus(this)">OUI</button>
    <button class="not_arrived" data-url="/tournament/27/admin/player/3531/toogleArrived/1" data-id="3531" onclick="changeArrivedStatus(this)" style="display:none">NON</button>
</span>

So we clearly see that the correct Player is displayed (with the id 3531) in the tournament admin page.

Now, we will get a look to generated matches in Sonata Admin for both Player IDs.
So, we will have 4 URLs to test:

1. part1.value=3531 -> returns nothing
2. part2.value=3531 -> returns nothing
3. part1.value=3532 -> returns 3 matches
4. part2.value=3532 -> returns nothing

We expect that the 1st or 2nd link returns the player's matches (corresponding to the ID of the Hearthstone Player).
Instead, the only one that returns something is the third one, so when we filter with the ID of the Overwatch Player.

So, the correct Player is linked to the tournament, but not the Group Phase.

• It should be impossible to link an Overwatch Player to an Hearthstone Group Phase.
• It should also be impossible to put a Player in a Group Phase of a Tournament, if the player is not already registered in this tournament.

• Pictures
• Center text
• WYSIWYG
• Pagination

The following values must be changed from 'null' to 'xxxx' to keep consistency (raise fatal error during install) :

• paypal_express_checkout_username
• paypal_express_checkout_password
• paypal_express_checkout_signature

The following values should be changed from 'insalan.fr' to 'insalan' to keep consistency with mariadb naming best pratices :

• database_name
• database_user

Implement in Controllers a mean to log every action.
This should speed up debugging in production.

The tournament entity got a shortName parameter. This parameter is used:

• for displaying proper background on /tournament/{tournamentId}/public
• as tag on the event map to allow the players to pick a seat

22dd507 use the tournament short name to determine what background to use by capitalizing it and picking the correct file, but I'll change it to use the type instead.

As the shortName is basically tournamentType+tournamentYear should we replace it by a virtual attribute ?

Create an installer and handle settings (change template, website name...)

LOT of reworks to do here :

• Crfs forms provider

The Symfony\Component\Form\Extension\Csrf\CsrfProvider\CsrfProviderAdapter
class is deprecated since version 2.4 and will be removed in version 3.0.
Use the Symfony\Component\Security \Csrf\CsrfTokenManager class instead.

• Check bundles compatibility

Currently, we use Sonata. We should implement our own solution.

Everything is in the title

Old forum need to be accessible for everyone !

When running php app/console doctrine:schema:create during install, the process never exit.

(Just need to tweak the "We still need some information..." form)