instadapp / dsa-sdk Goto Github PK

If https://github.com/Instadapp/dsa-connect is indeed the latest "The official DSA SDK for JavaScript"

please freeze/archive this repository, and say so in this repository GitHub metadata and give correct link to newer SDK

ref #108 (comment)

I find the current Spell API a little bit awkward and I would prefer a more object-oriented interface. As JavaScript is an object-oriented language, I think that would feel more "natural".

I'm thinking something like this:

spell = new dsa.Spell();       // create spell
spell.add({ ... });            // add connectors
await spell.estimateCastGas(); // estimate gas
await spell.cast();            // cast spell

What do you think?

It seems that it would be possible to offer this API without breaking backwards compatibility, simply by extracting the ad-hoc spell class from src/index.js into a standalone class and binding the existing methods to it.

I can try working this out and submit a PR if interested.

https://docs.instadapp.io/setup/ shows example as

dsa.build().then(console.log);

and says that build has
>an optional Object parameter

However running build() without parameters causes

(node:22117) UnhandledPromiseRejectionWarning: Error: gasPrice is not defined.
at f.exports.getTxObj (/Users/user/Workspaces/Ethereum/Instadapp/instadapp-get-started/node_modules/dsa-sdk/build/dsa.min.js:12:395221)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async /Users/user/Workspaces/Ethereum/Instadapp/instadapp-get-started/node_modules/dsa-sdk/build/dsa.min.js:12:41342
(

So either docs or current version of sdk are wrong.