instantiations / ci-examples-vast Goto Github PK

We created the UNIX.txt file by executing EmImageManager class>>#writePassiveImagePropertiesFor:

However, the InstalledFeatures list in the UNIX.txt is currently ignored. EmImageManager class>>#createNewImageWithPropertiesFrom: reads the lines from this file, but does not do anything with it. I cannot tell why. It looks like the code was removed at some point, or was forgotten to be added. So if you need to load features, you need to use the xdImage installFeatures: system. If you fixed EmImageManager class>>#createNewImageWithPropertiesFrom: to actually do the load from the UNIX.txt file, then there would be no need for the xdImage installFeatures: call in the abt.cnf.

We've not yet added in the running of the SUnit tests as part of this. Right now we run this sort of testing prior to versioning the config map for release. We'll be looking at adding a build job stage to run the tests in the near future. This first 'cut'

We need to fix this in VA so that below code is not necessary:

	" Turn off prompting for a library password as currently there is no way to externally supply the password (EtTools class>>verifyUser always prompts)"
	replacementMethod :=
	    EmLibrary
	        basicCompile: 'isPasswordCheckingEnabled
	            ^false'
	        notifying: System errorLog
	        ifFail: [
	            System logError: 'Cannot turn off password checking'.
	            System exit: 9001 withObject: nil].
	EmLibrary methodDictionary at: #isPasswordCheckingEnabled put: replacementMethod.

I've not found a way to intercept the XD transcript so that it appears in the jenkins job output. There appears to be lots of code inside the XD system that assumes the XD transcript is a CwShell style window. So right now, you cannot see progress of the XD portion of the build. If anyone has a tip or trick to fix this, I'd be interested in it.

Yeah...because we use the interactive debug and that prompts for an IP...

I've not found a way to guarantee that the process 'exits' on failure. Any walkback inducing error will launch the interactive debugger. I've tried to intercept most prompts and errors such that Jenkins is told of the error, but definitely not all. If nodialog.exe does not 'exit' then Jenkins waits forever for it to finish. The only way to 'fix' this is to login to the desktop running the jenkins slave and answer whatever prompt is being displayed in the VA Smalltalk UI.

As discussing internally, if apps only define packaging rules through the hooks mentioned here then loading apps on the dev wouldn't be necessary and loading on runtime should be enough.

But...if you have apps that implement app level #packagingRulesFor: with complex rules, then apps need to be loaded on the dev.

For the moment, we always load the XD map on the dev, but in the future it would be nice to make this optional for projects that don't need it (like Seaside Traffic Light)