interactivethings / eslint-config-interactivethings Goto Github PK

It's kinda hard to keep up with all eslint features, so maybe we should just extend eslint:recommended? Then it also becomes more clear which are our overrides.

Cf. https://github.com/rackt/eslint-config-rackt

https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb/rules/react-a11y.js

Currently, it's not possible to use this config with ES5 (e.g. Node) code because it complains about too many things.

• eslint v2
• eslint-plugin-react v4
• babel-eslint v6
• React v15

Make sure they all work nicely together.

Mostly lints fine with Flow annotations, but for some reason this doesn't:

/* @flow */

export default class Foo {
  bar(): object {
    return {};
  }
}

ESLint complains:

error  "object" used outside of binding context  block-scoped-var
error  "object" is not defined                   no-undef

Other types (e.g. string) lint fine.

Seems a bit over-pedantic but maybe it's useful. I've just included the sort order like it's defined in the AirBnB config. Should we keep it?

{
    // ...
    'react/sort-comp': [2, {
      'order': [
        'displayName',
        'mixins',
        'statics',
        'propTypes',
        'getDefaultProps',
        'getInitialState',
        'componentWillMount',
        'componentDidMount',
        'componentWillReceiveProps',
        'shouldComponentUpdate',
        'componentWillUpdate',
        'componentWillUnmount',
        '/^on.+$/',
        '/^get.+$/',
        '/^render.+$/',
        'render'
      ]
}

Version 3.3.0 of ESLint supports warning on setState.

jsx-eslint/eslint-plugin-react#197

For v3, we'll just use ['lifecycle', 'everything-else', 'render'].

• Bump eslint to v2
• Bump eslint-plugin-react to v4
• Bump babel-eslint to v6 (once it works with eslint v2)
• Add eslint-plugin-immutable (see #7)

At least the no-mutation rule looks quite useful.

https://github.com/jhusain/eslint-plugin-immutable