internetee / registry Goto Github PK

• Check if it supports keyword arguments in jobs
• Use Rails adapter (ActiveJob)

que gem's drawbacks:

• SQL (with table name) is hardcoded (https://github.com/chanks/que/blob/master/lib/que/sql.rb)
• Active Job is not supported (que-rb/que#127)
• Lack of documentation

• Move "[email protected]" from app/mailers/application_mailer.rb:3 to application.yml
• Remove "[email protected]" from specs
• Set defaults in application.rb

config.action_mailer.default_options = {
  from: "[email protected]"
}

• https://mailcatcher.me
• Change SMTP in config/environments/staging.rb
• Remove whie-list https://github.com/internetee/registry/search?utf8=%E2%9C%93&q=whitelist

NB! "Please don't put mailcatcher into your Gemfile. It will conflict with your applications gems at some point."

successful domain:delete query leaves outzone_at blank. The delete_at field is filled and onHold status is set.

System has to fill the outzone_At with time and date the onHold status was set.

Admin - http://prnt.sc/ckxire

Setting and removing force delete status on a domain must produce poll message for the responsible registrar

rfc on poll message:
https://tools.ietf.org/html/rfc5730#section-2.9.2.3

ForceDelete prevents any updates to a domain object.

ForceDelete is not a status on its own - it's a group label for list of statuses:

• serverRenewProhibited
• serverTransferProhibited
• serverUpdateProhibited
• pendingDelete
• serverManualInzone

So by default any updates are prohibited. To enable updates admin has to remove serverUpdateProhibited. Removing this results in new error on domain update

Object status prohibits operation - pendingDelete [code: 2304]

pending delete cannot prevent any other requests except domain:delete. Removing this results

Object status prohibits operation [code: 2304]

To update domain data one has to remove serverForceDelete.

• Fix/remove failing specs
• Improve rspec config
• Remove Faker gem

Also fixes failed build in #203

we need to set up Continuous Integration solution. GitHub integration is something to keep in mind so that autotest are run on merge/commit to staging for example.

https://github.com/integrations/feature/continuous-integration

deployment guide must also be updated with install and config instructions.

Solutions:

• Travis (https://travis-ci.com/plans, Free for open-source)
• Jenkins

@teadur Here is the latest config for staging (config/environments/staging.rb)
https://gist.github.com/artur-beljajev/236a4c8c07a6575832b30fcf1a23a3b7

I removed in this branch: https://github.com/internetee/registry/commits/remove-staging-config.

Please reassign this ticket to me once you're done with config.

https://codeclimate.com/github/internetee/registry/builds/1

db/structure.sql

COMMENT ON TABLE que_jobs IS '3';

bin/rails c staging
reload!

Reloading...
LoadError: Unable to autoload constant Repp::API, expected app/api/repp/api.rb to define it

1. Make common layout, so that all emails look the same (cur
2. Consider increasing font size for better accessibility.
3. Unify subject: some are in English, some are in Estonian, some are in both.

When domain goes to expire status, reminder email should be sent out according to the configured
Setting.expiration_reminder_mail parameter (defaults to 2)
So by default configuration expire reminder email should be sent out once to domain owner and all administrative contacts 2 days after domain has expired.
#188

Check expire_time (domain.valid_to = domain.valid_from.utc.beginning_of_day + convert_period_to_time(domain.period, domain.period_unit) + 1.day)

Nov 9 10:51:06 reg-l-rar REGISTRAR[4016]: [registrar] [855b0a24-4bf6-4fa6-b14b-a58327d7165f] [195.43.86.5] #012NoMethodError (undefined method level=' for Syslog::Logger:Class):#012 app/controllers/registrar/sessions_controller.rb:112:in mid'#12 config/initializers/eis_custom_flash.rb:9:in `call'

• https://github.com/internetee/registry/blob/master/config/locales/et.yml is outdated
• There is no language selector in UI

#207

domain is set as expired when timpestamp now > valid to
domain is set on hold (removed from zone) when timestamp now > outzone at
domain is set as delete candidate and random delete time is calculated when timestamp now > delete at
domain is deleted if domain has delete candidate status set

extracted from #235

STDOUT << "#{Time.zone.now.utc} DomainCron.start_expire_period: ##{domain.id} (#{domain.name}) #{domain.changes}\n" unless Rails.env.test?

The automatic email notifying the registrant about confirmed domain deletion is not sent

https://github.com/internetee/registry/blob/master/app/views/mailers/domain_mailer/delete_confirmation.text.erb

message is sent when the request is declined.

WHOIS server cannot handle invalid input correctly

/home/whois/whois/releases/12/vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.5.2/lib/active_record/connection_adapters/postgresql_adapter.rb:602:inexec_prepared': PG::CharacterNotInRepertoire: ERROR: invalid byte sequence for encoding "UTF8": 0xf6 0xf6 0x72 0x69 (ActiveRecord::StatementInvalid)`

server should validate the input so only correclty formated and valid queries reach the db

https://google.github.io/styleguide/htmlcssguide.xml
https://google.github.io/styleguide/javascriptguide.xml
https://google.github.io/styleguide/xmlstyle.html
https://github.com/bbatsov/ruby-style-guide
https://github.com/bbatsov/rails-style-guide

artur@registry:~/registry$ bundle exec rake db:migrate
== 20161004101419 AdduuidIndexToEppLogs: migrating ============================
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

PG::UndefinedColumn: ERROR: column "uuid" does not exist
: CREATE INDEX CONCURRENTLY epp_logs_uuid ON epp_logs USING btree (uuid);/media/sf_registry/db/migrate/20161004101419_adduuid_index_to_epp_logs.rb:3:in change' /home/artur/.rbenv/versions/2.2.2/bin/bundle:23:inload'
/home/artur/.rbenv/versions/2.2.2/bin/bundle:23:in <main>' ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "uuid" does not exist : CREATE INDEX CONCURRENTLY epp_logs_uuid ON epp_logs USING btree (uuid); /media/sf_registry/db/migrate/20161004101419_adduuid_index_to_epp_logs.rb:3:inchange'
/home/artur/.rbenv/versions/2.2.2/bin/bundle:23:in load' /home/artur/.rbenv/versions/2.2.2/bin/bundle:23:in

Updating contact with missing ident data generates unhandled error condition

<result code="1">
  <msg lang="en">handle_errors was executed when there were actually no errors</msg>
</result>

sample contact_info ident

    <extension>
      <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
        <eis:ident type="" cc=""/>
      </eis:extdata>
    </extension>

failure on update of such contact is OK, and the only solution for the registrar here is to create a new contact object, but correct error handling is necessary. An expected error message

`2306 "Parameter value policy error. Update of ident data not allowed [ident]"

domain expiration process has bugs on saving timestamps in db in correct timezone, using these values correctly according to timezone of the server/application and calculating the values of valid to, outzone and delete dates.

valid to calculated and saved in local timezone instead of utc

valid_from: "2016-10-21 11:08:18.872509"
valid_to: "2017-10-22 00:00:00"

outzone_at and delete_at dates are saved in db in local timezone instead of utc:

valid_to: "2016-11-03 22:00:00"
outzone_at: "2016-11-18 00:00:00"
delete_at: "2016-12-18 00:00:00"

due to this registrant looses 22hrs of expire warning period

logic:

• all timestamps in db must be in UTC timezone
• application must convert this to the timezone of the application/server (incl cron and Que jobs)
• expire date (valid to) of a domain is set to the beginning of next day of registration according local time (ie. reg date 2016-11-04 13:15:00.000+02.00 = exp date 2016-11-05 00:00:00.00+02.00 (in db 2016-11-04 22:00:00.00+00.00)
• outzone_at and delete_at are calculated on domain expiry
  • outzone at = valid to + expire warning period
  • delete at = valid to + expire warning period + redemption grace period
• domain is set as expired when timpestamp now > valid to
• domain is set on hold (removed from zone) when timestamp now > outzone at
• domain is set as delete candidate and random delete time is calculated when timestamp now > delete at
• domain is deleted if domain has delete candidate status set

Test case 1:

• domain registered @ 2016-11-04 13:15 (GMT +2)
• create/registration date saved in db 2016-11-04 11:15:00+00.00
• expiration date saved in db 2017-11-04 22:00:00+00.00 - registration for 1 year
• outzone date saved in db on domain expiry 2017-11-19 22:00:00+00.00
• delete date save in db on domain expiry 2017-12-19 22.00.00+00.00
• domain deleted at random time between 2017-12-19 22.00.00+00.00 and 2017-12-20 21:59:59+00.00

Test case 2:

• domain registere @ 2016-11-05 01:34 (GMT +2)
• registration date saved in db 2016-11-04 22:34:00+00.00
• expiration date saved in db 2017-11-05 22:00:00+00.00 - registration for 1 year
• outzone date saved in db on domain expiry 2017-11-20 22:00:00+00.00
• delete date save in db on domain expiry 2017-12-20 22.00.00+00.00
• domain deleted at random time between 2017-12-20 22.00.00+00.00 and 2017-12-21 21:59:59+00.00

http://prntscr.com/d023lr

I think b-tree index makes most sense, and it shold be added concurrently.
Should help with issue #181

config/initializers/settings.rb
app/mailers/application_mailer.rb

Once #188 is done.

The following mailers seem to be broken:

• pending_update_rejected_notification_for_new_registrant
• pending_update_expired_notification_for_new_registrant
• pending_update_notification_for_new_registrant

DomainMailer.pending_update_rejected_notification_for_new_registrant(Domain.find(86902)).deliver!

ArgumentError: An SMTP To address is required to send a message
#200

Add multilingual support for monthly invoices sent from Directo. There is a language parameter in the invoice XML sent to Directo (https://github.com/internetee/registry/blob/6eef658a992710d354859a32d43e1c2a0ccd497e/app/models/directo.rb)

The language parameter is currently left empty.

We need a rule that specifies language parameter as ENG in case registrar country_code value is not EE

There is a reference to the registrar holding the registration to a domain in automatic email notices sent by the registry (https://github.com/internetee/registry/tree/master/app/views/mailers), but no registrar contact data. The e-mail messages should have registrar's phone number, email address and web address as well (if exists in registry db).

@teadur @ratM1n Is there anything that prevents this change?

• https://github.com/errbit/errbit
• https://github.com/airbrake/airbrake
• Remove newrelic

Example:

config/database-example.yml should use underscore

domain and contact object history opens very slowly (up to even 5 or 6 minutes) in case the object has upates for it and related subobjects.

/admin/domains/1234/domain_versions

PRD

https://github.com/errbit/errbit

Please get back to me once it is installed. I will update config with the host of errbit (https://github.com/internetee/registry/blob/registry-207/config/initializers/errbit.rb) and merge it with staging so we can test it.
#207

config/initializers/eis_custom_active_model.rb
config/initializers/eis_custom_active_record.rb
config/initializers/eis_custom_flash.rb

№ 1: https://github.com/internetee/registry/blob/master/doc/whois.rm

• Outdated and serves no purpose

№ 2: https://github.com/internetee/registry/blob/master/doc/testing.md

• "Testing" section states obvious thing
• "Testing EPP" is not valid anymore

№ 3:
https://github.com/internetee/registry/blob/master/doc/controllers_brief.svg
https://github.com/internetee/registry/blob/master/doc/controllers_complete.svg
https://github.com/internetee/registry/blob/master/doc/models_brief.svg
https://github.com/internetee/registry/blob/master/doc/models_complete.svg

• Outdated

№ 4:
https://github.com/internetee/registry/blob/master/README.md
The following sections are not valid anymore along with № 2.

• "Updating documentation"
• "Autotesting"

There has inconsistency in WHOIS plain text body. All WHOIS response section headers are ending with colon except the "Administrative contact".

https://github.com/internetee/registry/blob/322d7e64e729cbd761fe9b583831f23863639e90/app/views/for_models/whois.erb

Consider installing production env error tracking/notification + performance monitor