intuit / cfn-deploy Goto Github PK

The timeout value for the stack create/update should be cutomizable.
This should be a non mandatory parameter

It would be easy for developers if we could support Makefile based targets while deploying CFN templates

Sample Makefile:

deploy-ec2-bastion:
aws cloudformation create-stack --template bastion.yml

While deploying we can simply call the make target

make deploy-ec2-bastion

I can provide more context over a call

The current version supports only yaml based templates. Weneed to support json templates as well.

Ideal to to have a ENV variable which determines what type of file you are passing.
The default can be YAML

Good to have Docker linting for the Dockerfile

https://github.com/hadolint/hadolint

Good to have a slack notification trigger after the completion of the job.

This has to be a non mandatory paramter as an env variable.

Webhook based integration would be ideal

Hi

What outputs come out of this nice integration?

We need some of the created resource values.

For example - I have a CloudFormation stack that spins up a VM, attaches an RDS instance, and associates an Elastic IP to it (so the IP is persistent).

In this case, I need the output of the Elastic IP that's assigned - I wouldn't know this ahead of time - to be able to pass that to configuring an external DNS provider.

Can this integration help?

Thank you,

== John ==

The installation is stuck on configuring tzdata and asking for user input to select region.

The hacktoberfest github topic https://github.com/topics/hacktoberfest should be added to the repository so it can officially participate in Hacktoberfest 🙂

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/classifying-your-repository-with-topics#adding-topics-to-your-repository

Ideal to have a support for nested stack creations.

Good to have a cloudformation syntax checker before deploying

The default cloudformation syntax checker is sufficient
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-cfn-validate-template.html

Need a small write up and a short video on how to test the github actions while development

have found that if for some reason (errors) the stack goes into ROLLBACK_COMPLETE mode in AWS, then updates are not allowed for it, so any subsequent deployment on the same stack are denied. Can we create a to-do to delete a stack if it got errored during deployment?

Good to have shell linting for the entrypoint.sh script

https://github.com/koalaman/shellcheck

Should be a very short video (voice not needed) , which is a short walkthrough on how cfn-deploy can be invoked as a github action in a github repository

Good to have a feature which enables you to delete the stacks as well. The trigger can be a ENV variable

Hello,
We can use the official amazon/aws-cli image.
This is will significant improve the docker build stage:

FROM  amazon/aws-cli

LABEL version="1.0.0"

LABEL "maintainer"="Mridhul Pax <[email protected]>"
LABEL "repository"="https://github.com/intuit/cfn-deploy"

LABEL com.github.actions.name="Cloudformation Github Deploy"
LABEL com.github.actions.description="Cloudformation Github Deploy"
LABEL com.github.actions.icon="upload-cloud"
LABEL com.github.actions.color="orange"

ENV DEBIAN_FRONTEND noninteractive

COPY entrypoint.sh /entrypoint.sh
ENTRYPOINT ["/entrypoint.sh"]

Good to have a Email Notification after the stack creation.

This has to be a non mandatory parameter