inventivetalentdev / mapmanager

MapManager

mapmanager's Issues

MapManager ArrayIndexOfBoundException

What steps will reproduce the problem?

1. ?
2. ?
3. ?

What Spigot version are you using? Type /version

1.12.1

[13:47:19 WARN]: [MapManager] Task #1583 for MapManager v1.4.0-SNAPSHOT generated an exception java.lang.ArrayIndexOutOfBoundsException: null at java.util.ArrayList.remove(Unknown Source) ~[?:1.8.0_144] at org.inventivetalent.mapmanager.MapSender$1.run(MapSender.java:62) ~[?:?] at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:71) ~[Spigot.jar:git-Spigot-0d820fa-5717601] at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:353) [Spigot.jar:git-Spigot-0d820fa-5717601] at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:739) [Spigot.jar:git-Spigot-0d820fa-5717601] at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:406) [Spigot.jar:git-Spigot-0d820fa-5717601] at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) [Spigot.jar:git-Spigot-0d820fa-5717601] at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) [Spigot.jar:git-Spigot-0d820fa-5717601] at java.lang.Thread.run(Unknown Source) [?:1.8.0_144]

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

yes, i`m using bungeecord. Only 1.12.1 clients

entityIdMatrix is accessed incorrectly.

See line 118 (MultiMapWrapper.java)

  @Override
  public void showInFrames(Player player, int[][] entityIdMatrix) {
  	for (int x = 0; x < entityIdMatrix.length; x++) {
  		for (int y = 0; y < entityIdMatrix[x].length; y++) {
  			wrapperMatrix[y][x].getController().showInFrame(player, entityIdMatrix**[x][wrapperMatrix.length - 1 - y]**);
  		}
  	}

}

You forgot to invert the axis here, nor do you mention it in the javadocs (The entityIdMatrix is accessing in a wrong manner.)

error on torchspigot

ss

logs

[14:14:08] [Server thread/INFO]: QiiQii issued server command: /afremove one
[14:14:11] [Server thread/INFO]: QiiQii issued server command: /afcreate one https://media.giphy.com/media/jG186kNLKs6TS/giphy.gif
[14:14:14] [pool-11-thread-1/INFO]: [AnimatedFrames] Downloaded 'https://media.giphy.com/media/jG186kNLKs6TS/giphy.gif' to 'plugins\AnimatedFrames\images\aHR0cHM6Ly9tZWRpYS5naXBoeS5jb20vbWVkaWEvakcxODZrTkxLczZUUy9naXBoeS5naWY='.
[14:14:14] [pool-11-thread-1/INFO]: [AnimatedFrames] Animation length for 'one' is zero. Creating non-animated image.
[14:14:14] [pool-11-thread-1/WARN]: Exception in thread "pool-11-thread-1" 
[14:14:14] [pool-11-thread-1/WARN]: java.lang.NullPointerException
[14:14:14] [pool-11-thread-1/WARN]: 	at org.inventivetalent.animatedframes.AnimatedFrame.scaleImage(AnimatedFrame.java:240)
[14:14:14] [pool-11-thread-1/WARN]: 	at org.inventivetalent.animatedframes.AnimatedFrame.run(AnimatedFrame.java:137)
[14:14:14] [pool-11-thread-1/WARN]: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[14:14:14] [pool-11-thread-1/WARN]: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[14:14:14] [pool-11-thread-1/WARN]: 	at java.lang.Thread.run(Thread.java:748)

timings
https://timings.aikar.co/?id=4e97a3f9a4d3405b81298fc0e18f4c67

config

# If vanilla maps should be allowed to be sent to the players (less efficient, since we need to check the id of every sent map)
allowVanilla: true

# If the plugin checks for duplicate images before creating a new one (Less efficient when first creating a image, but more efficient overall)
checkDuplicates: true

# Cache the packet data in the image object (less CPU intensive for a lot of players, but probably a bit more memory intensive depending on the image size)
cacheData: true

sender:
  # Delay between map packets (ticks)
  delay: 2

  # Maximum amount of map packets sent at once
  amount: 10

  # Allow immediate sending of map data
  allowQueueBypass: true

# Enable this if you are using PaperSpigot (and/or you get this error: http://paste.inventivetalent.org/damuhonebu)
paperSpigot: true

torchspigot
https://github.com/TorchSpigot/Torch

build 115
https://115-61716775-gh.circle-artifacts.com/0/tmp/circle-artifacts.mzB8ew0/Torchpowered-1.11.2.jar

java.lang.NoSuchFieldError: v1_13_R1

What steps will reproduce the problem?

It is thrown only one time after the server started. I can't reproduce it but I use Sentry to automatically log all exceptions.

What were you expecting to happen? What happened instead?

I can't reproduce the exception... I would think my Maps in the item frames would not load for a specific player but I can't check that...

What version of the plugin are you using? Type /version <Plugin Name>

1.5.2-SNAPSHOT

What Spigot version are you using? Type /version

CraftBukkit version git-Spigot-21fe707-e1ebe52 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)

What plugins ae you using? Type /plugins

Plugins (24): AAC, AdvancedDevUtils-CBN, AdvancedDevUtils-Spigot, AnimatedFrames, AntiLaby, BetterChairs, BossBarAPI, CherryEssentials, CommandSync, EmptyWorldGenerator, ErrorSink, LobbySystem, LuckPerms, MapManager, NoteBlockAPI, OnlyProxyJoin, PacketListenerApi, Plan, ProtocolLib, ServerHolograms, ServerSigns, TeleportAreas, ViaVersion, WorldBorder

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

https://pastebin.com/zsh1FSHa

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

I am using BungeeCord. I did not get the exception in previous versions but it happens irregularly.

Not enabling

What steps will reproduce the problem?

What were you expecting to happen? What happened instead?

To get it enabled, they are both disabled (animatedframes and mapmanager)

What version of the plugin are you using? Type /version <Plugin Name>

Mapmanager: 1.3.2-SNAPSHOT
Animated frames: 4.4.1-SNAPSHOT

What Spigot version are you using? Type /version

http://imgur.com/a/3ZFsO

What plugins ae you using? Type /plugins

http://imgur.com/a/S0Pm7

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

http://imgur.com/a/cseQ1

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

No

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

Not using bungeecord

player crashing on 1.14 on entity interact and block picking

What steps will reproduce the problem?

1. hit an entity on my version of spigot with the plugin installed

What were you expecting to happen? What happened instead?

not crashing

What version of the plugin are you using? Type /version <Plugin Name>

https://i.imgur.com/WTm33lW.png

What Spigot version are you using? Type /version

https://i.imgur.com/WTm33lW.png

What plugins are you using? Type /plugins

https://i.imgur.com/FfEI0bN.png

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

2019-09-03-7.log

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

On entity interact
https://i.imgur.com/m87enmi.png
On block pick in creative
https://i.imgur.com/v6FQW1M.png

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

MapManager is not loading 1.11

What steps will reproduce the problem?

1. Just updated server to 1.11
2. Restart the server

What were you expecting to happen? What happened instead?

That MapManager is loading but there is only an error.

What version of the plugin are you using? Type /version <Plugin Name>

1.3.4-SNAPSHOT

What Spigot version are you using? Type /version

1.11.2-R0.1-SNAPSHOT

What plugins ae you using? Type /plugins

Plugins (57): RisingWarps, PlaceholderAPI, MythicLib, RisingOPvP, RisingBot, VoxelSniper, RisingSmaragd, RisingGilde, dynmap, WorldEdit, RisingSudo, HealthBar, AWD, PacketListenerApi, AutoMessage, MapManager, UniLib, ProtocolLib, Multiverse-Core, AntiWDL, LibsDisguises, ArchiSystem, RisingKekse, MysteryBoxes, PermissionsEx, EffectLib, RisingPartikel, mcMMO, RisingEnchants2, RisingRegionTitle, Vault, TokenManager, AnimatedFrames, LWC, WorldGuard, Multiverse-Inventories, WeatherMan, RisingRPG, MagicSpells, BungeeTabListPlus, AreaShop, Essentials, TreasureChest, Citizens, CustomGUI, WGRegionEvents, AncientGates, CraftBook, ChestShop, MythicMobs, MyPet, Denizen, Jobs, MyPet-NPC, Signs, Quests, DenizenClicker

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

https://pastebin.com/JGy2M7Ep

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

Nope

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

And it worked in previous versions, but not on 1.11

java.lang.IllegalStateException: MapInteractEvent may only be triggered synchronously.

What steps will reproduce the problem?

1. Interact a map create by AnimatedFrames

What were you expecting to happen? What happened instead?

Console throw exceptions

What version of the plugin are you using? Type /version <Plugin Name>

MapManager version 1.7.4-SNAPSHOT

What Spigot version are you using? Type /version

This server is running Paper version git-Paper-35 (MC: 1.15.1) (Implementing API version 1.15.1-R0.1-SNAPSHOT)

What plugins ae you using? Type /plugins

Plugins (109): AdvancedReplay*, AFKTitle*, AkkariinTerminal*, AlertMineWorld, AncientGates, AnimatedFrames*, AntiEnderPortalBreaker, BBSToper*, BeehiveInfo, BeeHivesTrees, BorderProtect, BossShopPro, CaulCrafting*, Chair, ChatReplay, ChineseCommand*, Citizens, CitizensCMD, CmdConfirm*, ColorAnvil*, ColoredBooks*, CommandNotifier, Confiscate, ConsoleSpamFix, CoreProtect, CoreProtectTNT, CraftBook, CustomJukeBox, EndPortalBreakFix*, EntityDetection, EntityTrackerFixer, Essentials, EssentialsAntiBuild, EssentialsChat, EssentialsGeoIP, EssentialsProtect, EssentialsSpawn, ExtendViewDistance*, F3Name, FakeSeed, FixMyData*, ForceResourcepacks, GCore, GreenFingers, HamsterEcoHelper, HeadDropsSS, HolographicDisplays, HopperFilter, HorseArmor, HorseArmorEnchants, IllegalStack, InventoryRollback, JetsMinions*, KickIdlePlayer, LangUtils, Lift, LimitPillagers, LiteBans, LockettePro, Lores*, LuckPerms, MapManager*, MaxRepairCost, mcMMO, MineCalendar, MineSecure*, MineSync*, MobFarmManager, MoreCompost, Multiverse-Core, MyPet, MyWarp, NewbieProtection, NMSCatAPI, NyaaCore, NyaaUtils, OpenInv, ourtown, PacketEventCatAPI*, PacketListenerApi*, PetMaster, PlaceholderAPI, Plan, PlayerReport*, PlayTimeTracker, PlugMan*, ProtocolLib, PublicCrafters, QuestCreator, QuickShop, ravager-anti-grief, RideMe-Plus*, RPGItems, RuleQuizzer, SafetyReboot*, Shopkeepers, SmoothSleep, spark, StarGate, SuperVanish, TitleManager*, TouchscreenHolograms, Vault, VillagerOptimiser, WebFrames*, WorldEdit, WorldEditSelectionVisualizer, WorldGuard, YouAreNotLostConnection*

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

https://paste.ubuntu.com/p/xvwCStR9M5/

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

no

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

It happend on AnimateFrames before, i forked it and fix it by myself, and now, MapManager starting throwing....
This changes is spigot changes on 1.15, async event only can call on offmain therad, and sync is same.

Creating a Map using already set Map IDs

Short description
I already wrote it in AnimatedFrames github they told me it's a bug of MapManager
So when I create a Map the created map (filled_map) using an ID that is already used by a AnimatedFrame picture map so we can't create a new map because it uses already existing pictures.

To Reproduce
Steps to reproduce the behavior:

1. Create a Map (or get it from the Creative Inv)
2. Right Click it, to create a filledmap
3. If AnimatedFrames uses the ID the map getting a frame of the Picture used in AnimatedFrames

Expected behavior
New Map should be created and not using the Same ID's that are already used.

Thanks for Reading

MapManager bug with Spigot 11.1

What steps will reproduce the problem?

1. Generate a new frame /afg
2. Create a new animated frame /afcreate name https://media2.giphy.com/media/l2R0aKwejYr8ycKAg/200_s.gif
3. Move around it\wait

What were you expecting to happen? What happened instead?

Game should work, instead the game crashes.

What version of the plugin are you using? Type /version <Plugin Name>

1.2.0

What Spigot version are you using? Type /version

1.11

What plugins ae you using? Type /plugins

Animated Frames 4.3.3
MapManager 1.2.0
PacketListenerAPI 3.4.4

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

http://pastebin.com/sN9mY4kv

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

http://pastebin.com/fL59KJNE

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

I have debugged MapManager and Spigot 11.1, I have also tried to update the dependencies. It seems that there is a problem with PacketPlayOutEntityMetadata although I might be wrong.

Any ideas? I would be happy to help fixing it but kinda stuck.

Thank you
Shaked

Offhand support

Offhand slot is currently not supported since the check at https://github.com/InventivetalentDev/MapManager/blob/master/src/org/inventivetalent/mapmanager/DefaultMapWrapper.java#L141 prevents slot 40 from being used.

Images are not loaded when moving the world.

What steps will reproduce the problem?

1. Loaded normally the first time I run the server.
2. The following error occurs when the player teleports to another world.
3. Since then, images have not been loaded normally and remain in the form below.

What were you expecting to happen? What happened instead?

What version of the plugin are you using? Type /version <Plugin Name>

-> MapManager version 1.8.0-SNAPSHOT

What Spigot version are you using? Type /version

-> PaperSpigot, Spigot 1.16.5

What plugins ae you using? Type /plugins

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

Paper : https://pastebin.com/ZmPX1X4e

Spigot : https://pastebin.com/Yg89maPm

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

From when a player moves to another world, we see a problem where all players' animated frames are not loaded.
I replaced it with Spigot today because I thought it was a problem with Paper Bukkit, but the same symptoms appear.

Java 11 version is in use, and after the crash, the image will not load even after creating a new Animated Frame.

Please add to the documentation

When using MapManager#wrapImage or MapManager#wrapMultiImage your code would "join" two identical pieces, if you for example want to create a fully white thing and draw on it afterwards you wouldn't be able to since all canvases would be linking to the same one.

Treasure maps show maps setup by AnimatedFrames (Issue with this API, or the other plugin?)

What steps will reproduce the problem?

1. Add an image to item frames via AnimatedFrames (one JPG setup across 2 item frames
2. Random Treasure Maps found in the world are the item frame pictures

What were you expecting to happen? What happened instead?

Was expecting normal treasure maps to be normal treasure maps

What version of the plugin are you using? Type /version <Plugin Name>

4.11.5-snapshot

What Spigot version are you using? Type /version

Paper build 184

What plugins are you using? Type /plugins

AnimatedFrames4.II.5-SNAPSHOTjar
BKCommonLibjar
chunkmasterjar
ConsoleSpamFix-I.8.2jar
Coreprotect-2.18.I jar
DeathCoordinatesjar
DiscordSRV-8uild-1.19D-SNAPSHOT-1...
DKLibjar
Dynmap-3D-beta- ID-spigotjar
EssentialsX-2.17.2.5gjar
EssentialsXChat-2.17.2.5gjar
EssentialsXGeoIP-2.17.2.5gjar
LuckPerms-8ukkit-5.O.104jar
MapManager_v1.78-SNAPSHOTjar
Multiverse-Core-4.I.Ojar
Multiverse-PotaIs-4.I .O.jar
NoteBlockAPI-I .4Ajar
NoteBlockPIayerjar
Openlnv.jar
PacketListenerAPI_v3.7.6-SNAPSHOTjar
Plan-5.I-buiId-497.jar
Play Time-I .14jar
PlugManjar
RandomTeIeportjar
Signportalsjar
SpigotPing_v2.5jar
TAB v2.73.jar
Tree* Feller+ I .103jar
Vaultjar
worldedit-bukkit-7.I.O (I)jar
WorldEditSeIectionVisuaIizer-2.OAjar
worldguard-bukkit-7.O.2jar

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

N/A

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

N/A

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

Is this an issue with this API, or is it a problem solely with AnimatedFrames?

MapManager + AnimatedFrames ---> Vanilla maps break every restart

What steps will reproduce the problem?

1. Fresh install MapManager + AnimatedFrames
2. Create some non-animated banners, in my case at our /spawn
3. Craft a normal (player) map
4. Right click the map, it will create a map with the image of the spawn banners.
   I have to cycle through all of the images of all the banners at /spawn before regular maps start working again.

What were you expecting to happen? What happened instead?

Well the idea would be that it would skip the map-ids that are occupied by AnimatedFrames, so that when a player creates a normal, AKA vanilla map, he gets an actual map and not a part of the banners that are on display at spawn.

It would also be fine if I only had to create the occupied map-ids once and it then working forever afterwards, but currently I have to do this every time we restart the server (so once every 24 hours).

What version of the plugin are you using? Type /version <Plugin Name>

MapManager 1.3.4-SNAPSHOT
AnimatedFrames 4.4.2-SNAPSHOT

What Spigot version are you using? Type /version

Spigot 1.10.2-R0.1
git-spigot-de459a2-51263e9

What plugins are you using? Type /plugins

A whole load, but none of the other plugins affects map behavior.
I am happy to provide a list of plugins through a private means but do not wish to publicly post them.

This also happens when these two plugins are the only ones installed.

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

Not Applicable

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

Not Applicable

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

I am using BungeeCord but these plugins are installed on only one of the two playable servers, and not through the cord.

Issue Running on Paper 1.16.2

What steps will reproduce the problem?

1. Installing plugin on Paper 1.16.2
2. Trying to run it

What were you expecting to happen? What happened instead?

I was expecting it to work of course. Instead, it done did an oof on me.

What version of the plugin are you using? Type /version <Plugin Name>

What Spigot version are you using? Type /version

What plugins are you using? Type /plugins

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

pastebin.com

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

No

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

Running Paper. My server is running on Ubuntu. This is not a Bungeecord server.

Reset maps

When a map image is set, newly generated maps might be changed to that image, due to that I'd like to reset the maps back to the original image once I'm done with using them, is that possible with the current API?

NoSuchFieldError (Resolved at the time of writing issue)

What steps will reproduce the problem?

1. Downlaod JAR
2. Use it in your plugin
3. Get some troubles Just don't get anything

What were you expecting to happen? What happened instead?

I just wanted to check this API, but it doesn't work

MapManager Version

1.7.2-SNAPSHOT

Core version

PaperClip 1.13.2 (530b)

Plugins

Put on a clean build...

Error Log

java.lang.NoSuchFieldError: SEM_VER_SNAPSHOT
        at org.inventivetalent.mapmanager.MapManagerPlugin.onEnable(MapManagerPlugin.java:101) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:254) ~[patched_1.13.2.jar:git-Paper-530]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:326) ~[patched_1.13.2.jar:git-Paper-530]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:406) ~[patched_1.13.2.jar:git-Paper-530]
        at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugin(CraftServer.java:443) ~[patched_1.13.2.jar:git-Paper-530]
        at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugins(CraftServer.java:357) ~[patched_1.13.2.jar:git-Paper-530]
        at net.minecraft.server.v1_13_R2.MinecraftServer.l(MinecraftServer.java:608) ~[patched_1.13.2.jar:git-Paper-530]        at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:570) ~[patched_1.13.2.jar:git-Paper-530]        at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:431) ~[patched_1.13.2.jar:git-Paper-530]        at net.minecraft.server.v1_13_R2.DedicatedServer.init(DedicatedServer.java:316) ~[patched_1.13.2.jar:git-Paper-530]
        at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:786) ~[patched_1.13.2.jar:git-Paper-530]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_181]

As I understand it, there is a problem with the plugin update module.
I do not know why there was an error about the absence of the field, if it is defined.

NoSuchFieldError:

Normally, this error is caught by the compiler; this error can only occur at run time if the definition of a class has incompatibly changed.

Are there incompatible versions of additional APIs?

Yep! Please, update this to the latest version from GitHub.
Because the link in the main post leads to an outdated API (3.7.1)

Needs updating for 1.16

What steps will reproduce the problem?

1. Loading Paper will give a lot of errors in the log file. Nothing seems to be broke in the game.

[21:32:46] [Server thread/ERROR]: Error loading saved data: map_1025
java.lang.IllegalArgumentException: Invalid map dimension: 12
at net.minecraft.server.v1_16_R1.WorldMap.lambda$a$0(WorldMap.java:98) ~[patched_1.16.1.jar:git-Paper-18]
at java.util.Optional.orElseGet(Unknown Source) ~[?:1.8.0_251]
at net.minecraft.server.v1_16_R1.WorldMap.a(WorldMap.java:81) ~[patched_1.16.1.jar:git-Paper-18]
at net.minecraft.server.v1_16_R1.WorldPersistentData.c(WorldPersistentData.java:68) ~[patched_1.16.1.jar:git-Paper-18]
at net.minecraft.server.v1_16_R1.WorldPersistentData.b(WorldPersistentData.java:52) ~[patched_1.16.1.jar:git-Paper-18]
at net.minecraft.server.v1_16_R1.WorldServer.a(WorldServer.java:1700) ~[patched_1.16.1.jar:git-Paper-18]
at org.bukkit.craftbukkit.v1_16_R1.CraftServer.getMap(CraftServer.java:1452) ~[patched_1.16.1.jar:git-Paper-18]
at org.bukkit.craftbukkit.v1_16_R1.CraftServer.getMap(CraftServer.java:231) ~[patched_1.16.1.jar:git-Paper-18]
at org.bukkit.Bukkit.getMap(Bukkit.java:627) ~[patched_1.16.1.jar:git-Paper-18]
at org.inventivetalent.mapmanager.MapManagerPlugin.onEnable(MapManagerPlugin.java:88) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.16.1.jar:git-Paper-18]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380) ~[patched_1.16.1.jar:git-Paper-18]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[patched_1.16.1.jar:git-Paper-18]
at org.bukkit.craftbukkit.v1_16_R1.CraftServer.enablePlugin(CraftServer.java:498) ~[patched_1.16.1.jar:git-Paper-18]
at org.bukkit.craftbukkit.v1_16_R1.CraftServer.enablePlugins(CraftServer.java:412) ~[patched_1.16.1.jar:git-Paper-18]
at net.minecraft.server.v1_16_R1.MinecraftServer.loadWorld(MinecraftServer.java:471) ~[patched_1.16.1.jar:git-Paper-18]
at net.minecraft.server.v1_16_R1.DedicatedServer.init(DedicatedServer.java:241) ~[patched_1.16.1.jar:git-Paper-18]
at net.minecraft.server.v1_16_R1.MinecraftServer.v(MinecraftServer.java:940) ~[patched_1.16.1.jar:git-Paper-18]
at net.minecraft.server.v1_16_R1.MinecraftServer.lambda$a$0(MinecraftServer.java:177) ~[patched_1.16.1.jar:git-Paper-18]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_251] 

What were you expecting to happen? What happened instead?

What version of the plugin are you using? Type /version <Plugin Name>

What Spigot version are you using? Type /version

Paper 24

What plugins ae you using? Type /plugins

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

Can't get it working

I'm trying to get an image on a ItemFrame with this API, but the image isn't shown.

My code:

//location is the itemframe location and image is the image
public static void makeArt(Location location, BufferedImage image) {
    MapWrapper wrapper = Main.getMapManager().wrapImage(image);
    MapController controller = wrapper.getController();
    for (Player p : Bukkit.getOnlinePlayers()) {
        controller.addViewer(p);
        controller.sendContent(p);
    }

    getSafeFrame(location).thenAccept(frame -> {
        if (frame == null) return;
        for (Player p : Bukkit.getOnlinePlayers()) {
            controller.showInFrame(p, frame);
        }
    });
}

private static ItemFrame getFrame(@NotNull Location loc) {
    ItemFrame frame = null;
    if (loc.getChunk().getEntities().length != 0) {
        for (Entity e: loc.getChunk().getEntities()) {
            if (MainUtil.locationEquals(e.getLocation(), loc)) {
                if (e instanceof ItemFrame) {
                    frame = (ItemFrame) e;
                    break;
                }
            }
        }
    }
    return frame;
}

//Using a CompletableFuture becuase it's runned async
@NotNull
private static CompletableFuture <ItemFrame> getSafeFrame(@NotNull Location location) {
    CompletableFuture <ItemFrame> cf = new CompletableFuture < > ();

    Bukkit.getScheduler().runTask(Main.getInstance(), () -> cf.complete(getFrame(location)));

    return cf;
}

What steps will reproduce the problem?

1. Trying to use the API
2. Can't get a BufferedImage onto a frame

What were you expecting to happen? What happened instead?

The image that gets displayed on the ItemFrame.

What version of the plugin are you using? Type /version <Plugin Name>

MapManager v1.7.4-SNAPSHOT
PacketListenerApi v3.7.5-SNAPSHOT

What Spigot version are you using? Type /version

git-Spigot-dcd1643-e60fc34 (MC: 1.12.2) -> Latest build

What plugins are you using? Type /plugins

Request for slight performance optimization

MapManager/src/org/inventivetalent/mapmanager/MapManagerPlugin.java

Line 86 in 3b8bec1

for (short s = 0; s < Short.MAX_VALUE; s++) {

When searching through all the possible map ids, looking for vanilla maps, wouldn't it be faster to start at 'Options.FORCED_OFFSET' rather than 0, since when getting a new, free map id you start searching at that offset:

MapManager/src/org/inventivetalent/mapmanager/DefaultMapManager.java

Line 124 in 3b8bec1

int largest = Options.FORCED_OFFSET;

showInHand or showInInventory not working

What steps will reproduce the problem?

1. I run wrapper.getController().showInHand(p, true);
2. The user get's an empty image

What were you expecting to happen? What happened instead?

A good image is shown

What version of the plugin are you using? Type /version <Plugin Name>

1.7.5-SNAPTSHOT

What Spigot version are you using? Type /version

1.14.4-R0.1-SNAPSHOT [PaperSpigot build 237]

What plugins are you using? Type /plugins

The image (ArrayImage) is okay.

But it's not shown in the inventory, and it says "Unkown map"

Spigot 1.8.8 Startup Error

When does this error occur? Startup of Spigot 1.8.8, latest version.

What effects does it have? It completely disables the plugin.

What's the error? The error can be viewed on this pastebin.

Do you have all dependencies installed? Yes. I have PacketListenerAPI installed.

Comman /mm is main command for MythicMobs

Please create the different alias for this command, your plugin is way not so used
as a MythicMobs . This is really not good fo me, i have a RPG server and this plugin is needed for animated frames .

Add html-javadoc

As Haxalicious said, the old docs aren't available anymore. As PRs can not include new branches, I'll leave this patch here for a setup like the one you used for NickNamers docs using gh-pages.

Client Crash when sending map

What steps will reproduce the problem?

1. Run server
2. Send map

What were you expecting to happen? What happened instead?

I was expecting map render but i'm getting crashed client.

What version of the plugin are you using? Type /version <Plugin Name>

As i said on discord, i been using latest, 1.4.1 and 1.7.3

What Spigot version are you using? Type /version

git-Paper-1618 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

i tried too on 1.12.2 latest spigot, not working too

What plugins ae you using? Type /plugins

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

Not working on any of version

Latest Map Manager does not work on 1.17

Describe the bug
After I updated it and PacketListenerAPI to the latest, the latter now loads fine, but MapManager errors.

To Reproduce
Steps to reproduce the behavior: Run the latest MapManager and PacketListenerAPI on Paper 1.17.

Expected behavior
I expected it to load without issues.

Screenshots
None.

Additional context
Stack trace of the error:

[17:23:43] [Server thread/INFO]: [MapManager] Enabling MapManager v1.8.3-SNAPSHOT
--
[17:23:43]  [Server thread/INFO]: [ReflectionHelper/MinecraftVersion] I am loaded  from package org.inventivetalent.reflection.minecraft
[17:23:43] [Server thread/INFO]: [ReflectionHelper/MinecraftVersion] Version is v1_17_R1 (11701)
[17:23:43] [Server thread/ERROR]: Error occurred while enabling MapManager v1.8.3-SNAPSHOT (Is it up to date?)
java.lang.ExceptionInInitializerError: null
at org.inventivetalent.mapmanager.MapManagerPlugin.onEnable(MapManagerPlugin.java:70) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:370) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:500) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.craftbukkit.v1_17_R1.CraftServer.enablePlugin(CraftServer.java:518) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.craftbukkit.v1_17_R1.CraftServer.enablePlugins(CraftServer.java:432) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at net.minecraft.server.MinecraftServer.loadWorld(MinecraftServer.java:643) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at net.minecraft.server.dedicated.DedicatedServer.init(DedicatedServer.java:303) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1118) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:320) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at java.lang.Thread.run(Thread.java:831) [?:?]
Caused by: java.lang.IllegalArgumentException: class cannot be null
at org.inventivetalent.reflection.resolver.MemberResolver.<init>(MemberResolver.java:20) ~[?:?]
at org.inventivetalent.reflection.resolver.FieldResolver.<init>(FieldResolver.java:15) ~[?:?]
at org.inventivetalent.mapmanager.PacketListener.<clinit>(PacketListener.java:24) ~[?:?]
... 11 more
[17:23:43] [Server thread/INFO]: [MapManager] Disabling MapManager v1.8.3-SNAPSHOT
[17:23:43] [Server thread/ERROR]: Error occurred while disabling MapManager v1.8.3-SNAPSHOT (Is it up to date?)
java.lang.NullPointerException:  Cannot invoke "org.inventivetalent.mapmanager.PacketListener.disable()"  because "this.packetListener" is null
at org.inventivetalent.mapmanager.MapManagerPlugin.onDisable(MapManagerPlugin.java:126) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:265) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:405) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:533) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:374) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:500) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.craftbukkit.v1_17_R1.CraftServer.enablePlugin(CraftServer.java:518) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at org.bukkit.craftbukkit.v1_17_R1.CraftServer.enablePlugins(CraftServer.java:432) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at net.minecraft.server.MinecraftServer.loadWorld(MinecraftServer.java:643) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at net.minecraft.server.dedicated.DedicatedServer.init(DedicatedServer.java:303) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1118) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:320) ~[patched_1.17.jar:git-Paper-"15e4b30"]
at java.lang.Thread.run(Thread.java:831) [?:?]

Not reconizing?

What steps will reproduce the problem?

What were you expecting to happen? What happened instead?

I expected it to work, this is error https://hastebin.com/fepazuzele.md

What version of the plugin are you using? Type /version <Plugin Name>

AnimatedFrames: 4.4.1-SNAPSHOT
MapManager: 1.3.3-SNAPSHOT
PacketListenerAPI: 3.5.1-SNAPSHOT

What Spigot version are you using? Type /version

"This server is running CraftBukkit version git-Spigot-c3c767f-33d5de3 (MC: 1.8)"

What plugins ae you using? Type /plugins

WorldEdit,Essentials, Protocolib, PacketlistenerAPI,AnimatedFrames,WorldGuard,PacketWrapper

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log https://hastebin.com/fepazuzele.md

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

no

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

no

MapManager Spam 1.12.2

What steps will reproduce the problem?

1. Start server
2. Spam

What were you expecting to happen? What happened instead?

Just the console spam

What version of the plugin are you using? Type /version <Plugin Name>

1.4.0-SNAPSHOT

What Spigot version are you using? Type /version

1.12.2

What plugins ae you using? Type /plugins

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

https://pastebin.com/dYvN2ykZ

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

no

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency org.inventivetalent.spiget-update:bukkit to v1.4.6-SNAPSHOT
• Update dependency org.inventivetalent:reflectionhelper to v1.18.11-SNAPSHOT
• Update dependency io.papermc.paper:paper-api to v1.20-R0.1-SNAPSHOT
• Update dependency org.apache.maven.plugins:maven-compiler-plugin to v3.11.0
• Update dependency org.apache.maven.plugins:maven-shade-plugin to v3.4.1
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

maven

pom.xml

• org.apache.maven.plugins:maven-compiler-plugin 3.8.1
• org.apache.maven.plugins:maven-shade-plugin 3.3.0-SNAPSHOT
• io.papermc.paper:paper-api 1.17.1-R0.1-SNAPSHOT
• org.inventivetalent.packetlistenerapi:api 3.9.10-SNAPSHOT
• org.inventivetalent:reflectionhelper 1.18.10-SNAPSHOT
• org.inventivetalent.spiget-update:bukkit 1.4.2-SNAPSHOT

---

• Check this box to trigger a request for Renovate to run again on this repository

Console spammed by error, resulted in maps no loading

What steps will reproduce the problem?

1. I have no clue

What were you expecting to happen? What happened instead?

maps to load and no console spam

I am being spammed the following several times a second, I cannot find the initial error as if right now
https://pastebin.com/JvrV5hnt

What version of the plugin are you using? Type /version <Plugin Name>

What Spigot version are you using? Type /version

What plugins are you using? Type /plugins

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

I cant upload the whole log due to the spam making the file 200mb in size

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

no client crash

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

no bungeecord, i have not previously noticed this issue

java.lang.IllegalArgumentException: Invalid map dimension: 11

When the plugin starts, a large number of messages are displayed like:
[MapManager] Adding new Map # 154 to occupied IDs.
[MapManager] Adding new Map # 155 to occupied IDs.
...
[MapManager] Adding new Map # 245 to occupied IDs.
[MapManager] Found 227 occupied IDs.

Some maps throw exceptions: https://pastebin.com/raw/1VqPQ3Wu
A total of about 18-19 errors (245 - 227)

Perhaps the problem is that today the server upgraded from version 1.13.2 to version 1.14.4, and then immediately to 1.15.2

It would be great:
a) To fix loading errors
b) To get rid of spam in the console

Versions:

about PacketListenerAPI
PacketListenerApi version 3.7.5-SNAPSHOT
Author: inventivetalent

about MapManager
MapManager version 1.7.7-SNAPSHOT
Author: inventivetalent

about AnimatedFrames
AnimatedFrames version 4.11.4-SNAPSHOT
Author: inventivetalent

about
This server is running Paper version git-Paper-79 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)
Checking version, please wait...
Previous version: git-Paper-243 (MC: 1.14.4)
You are running the latest version

Error on server start

What steps will reproduce the problem?

1. Start server

What were you expecting to happen? What happened instead?

This error occured on server start

[22:37:55 WARN]: [MapManager] Task #1731 for MapManager v1.7.8-SNAPSHOT generated an exception java.util.ConcurrentModificationException: null at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901) ~[?:1.8.0_112] at java.util.ArrayList$Itr.next(ArrayList.java:851) ~[?:1.8.0_112] at org.inventivetalent.mapmanager.MapSender.sendMap(MapSender.java:71) ~[?:?] at org.inventivetalent.mapmanager.MapSender$1.run(MapSender.java:57) ~[?:?] at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.15.2.jar:git-Paper-333] at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:461) ~[patched_1.15.2.jar:git-Paper-333] at net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1256) ~[patched_1.15.2.jar:git-Paper-333] at net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:430) ~[patched_1.15.2.jar:git-Paper-333] at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1173) ~[patched_1.15.2.jar:git-Paper-333] at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:962) ~[patched_1.15.2.jar:git-Paper-333] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]

What version of the plugin are you using?

1.7.8-SNAPSHOT

What Spigot version are you using?

Latest build of Paper 1.15.2

Did your client crash?

No

I have some problems.

latest.log

It does not work properly in PaperSpigot 1.13.2.

Attempted configuration does not work
Config.yml
PaperSpigot: true

PaperSpigot Error 1.12.2

What steps will reproduce the problem?

1. Add the latest versions of the plugins in the server.
2. Run /afcreate
3. Get the error

What were you expecting to happen? What happened instead?

The frames to start, but I've got an error.

What version of the plugin are you using? Type /version <Plugin Name>

1.7.7-SNAPSHOT

What Spigot version are you using? Type /version

git-Paper-1618 (MC 1.12.2)

What plugins ae you using? Type /plugins

A lot of plugins. I can send it if needed.

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

https://pastebin.com/NFU9kXhJ

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

No

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

I'm using Bungeecord, but that's unrelated.

MapManager not loading on 1.12.2

What steps will reproduce the problem?

1. Download MapManager v1.7.8-SNAPSHOT
2. Drag it into your plugins folder
3. Boot the server

What were you expecting to happen? What happened instead?

I didn't expect 2 stacktraces on startup.

What version of the plugin are you using? Type /version <Plugin Name>

MapManager version 1.7.8-SNAPSHOT

What Spigot version are you using? Type /version

git-Paper-1618 (MC: 1.12.2)

What plugins ae you using? Type /plugins

MapManager, PacketListenerAPI

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

http://haste.athion.net/zayujanahi.css

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

No

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

MapManager_v1.4.0-SNAPSHOT works fine.

AnimatedFrames

What steps will reproduce the problem?

1. starting the server

What were you expecting to happen? What happened instead?

animatedframes to show pics, but only item frames were shown

What version of the plugin are you using? Type /version <Plugin Name>

v1.2 Mapmanager

What Spigot version are you using? Type /version

1.8.8

What plugins ae you using? Type /plugins

AnimatedFrames [1.8 | 1.9 | 1.10] 4.3.3, PacketListenerAPI [1.7 | 1.8 | 1.9 | 1.10] 3.4.4

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

http://pastebin.com/gNYvjv6s

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

No

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

Thank you for your time

java.lang.NullPointerException: Cannot invoke "java.lang.reflect.Field.get(Object)"

Describe the bug
A lot of exceptions: https://pastebin.com/raw/yvF7qmLF
I suspect it might be related to using Java 16

To Reproduce
I am at a loss to answer. Most likely, it is enough just to move around the world.

Additional context
OpenJDK Runtime Environment (build 16.0.1+9-24)
Paper version git-Paper-693 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)
PacketListenerApi version 3.9.0-SNAPSHOT
MapManager version 1.8.0-SNAPSHOT

Error occurred while enabling MapManager v1.7.2-SNAPSHOT

[14:54:41 INFO]: [MapManager] Vanilla Maps are allowed. Trying to discover occupied Map IDs... [14:54:44 INFO]: [MapManager] Found 1192 occupied IDs. [14:54:44 ERROR]: Error occurred while enabling MapManager v1.7.2-SNAPSHOT (Is it up to date?) java.lang.NoSuchFieldError: SEM_VER_SNAPSHOT at org.inventivetalent.mapmanager.MapManagerPlugin.onEnable(MapManagerPlugin.java:101) ~[?:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:254) ~[patched_1.13.2.jar:git-Paper-495] at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:326) ~[patched_1.13.2.jar:git-Paper-495] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) ~[patched_1.13.2.jar:git-Paper-495] at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugin(CraftServer.java:441) ~[patched_1.13.2.jar:git-Paper-495] at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugins(CraftServer.java:355) ~[patched_1.13.2.jar:git-Paper-495] at net.minecraft.server.v1_13_R2.MinecraftServer.l(MinecraftServer.java:608) ~[patched_1.13.2.jar:git-Paper-495] at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:570) ~[patched_1.13.2.jar:git-Paper-495] at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:431) ~[patched_1.13.2.jar:git-Paper-495] at net.minecraft.server.v1_13_R2.DedicatedServer.init(DedicatedServer.java:316) ~[patched_1.13.2.jar:git-Paper-495] at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:786) ~[patched_1.13.2.jar:git-Paper-495] at java.lang.Thread.run(Unknown Source) [?:1.8.0_181] [14:54:44 INFO]: [MapManager] Disabling MapManager v1.7.2-SNAPSHOT

Is unwrapImage(MapWrapper wrapper); needed?

What version of the plugin are you using? Type /version <Plugin Name>

1.4.0-SNAPSHOT

What Spigot version are you using? Type /version

1.8.8 R0.1 SNAPSHOT

What plugins are you using? Type /plugins

MapManager, ProtocolLib, My own Plugin

My Issue

• I had some updating issues (long loading times) when there are many players online
• I got some OutOfMemory and GC overhead limit exceeded errors (not 100% sure if they are related to mapmanager)
• I have an issue when players reconnect, the Frames are not reassigned properly in the right order or are not displayed to the user at all

So I thought that a possible cause for that may be that old data gets stacked and leads to the issues explained above as I make a lot of map updates and basically just overwrite the old data. I searched through the API and found the

MapManager/src/org/inventivetalent/mapmanager/manager/MapManager.java

Line 55 in bb9f177

void unwrapImage(MapWrapper wrapper);

method and wanted to ask what exactly this method does and when/if it should be called? Also, do you know anything else that may solve my issues from above?

adding new maps

What steps will reproduce the problem?

1. when i join map manager starts to add new maps when i erase them
2. is there a way to stop mm to re adding these maps ?

What were you expecting to happen? What happened instead?

What version of the plugin are you using? latest version

What Spigot version are you using? 1.11.2

What plugins ae you using? Pixelator

Do you have an error log? Use pastebin.com. no bugs

Did your client crash? No client did not crash

Additional information? No bungee

Loosing connection: Internal Exception: java.lang.NoSuchFieldError: v1_14_R1

What steps will reproduce the problem?

1. Spawn a PlayerNPC using packets
2. Right-click the NPC

What were you expecting to happen? What happened instead?

The client is being disconnected without any information. The server just disconects him.
The server console prints: Sprax2013 lost connection: Internal Exception: java.lang.NoSuchFieldError: v1_14_R1

What version of the plugin are you using? Type /version <Plugin Name>

MapManager: 1.7.3-SNAPSHOT
PacketListenerApi: 3.7.3-SNAPSHOT
AdvancedDevUtils-Spigot: 0.7.5-DEV (Contains the code to spawn the NPC)

What Spigot version are you using? Type /version

CraftBukkit version git-Spigot-21fe707-e1ebe52 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)

What plugins ae you using? Type /plugins

Plugins (21): AdvancedDevUtils-CBN, AdvancedDevUtils-Spigot, AntiLaby, BetterChairs, BossBarAPI, CherryEssentials, EmptyWorldGenerator, ErrorSink, LobbySystem, LuckPerms, MapManager, NoteBlockAPI, PacketListenerApi, Plan, ProtocolLib, ScreenBox, ServerHolograms, ServerSigns, TeleportAreas, ViaVersion, WorldBorder

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

https://pastebin.com/tU1pPNkt

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

No crash and no error inside the client logs

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

I use BungeeCord and never noticed it until now. A player messaged me about it.

I first thought this was a bug in ViaVersion but after removing plugins one by one it only started to happen when MapManager has been enabled. I currently don't have any Maps in use.

ADU-Spigot: For the project I have not used a Maven ... You can find the repository at https://gitlab.sprax2013.de/Sprax2013/advanceddevutils-spigot. Everything about the PlayerNPC can be found at de.sprax2013.advanced_dev_utils.spigot.npc.

Finished .jar: https://tempfiles.cherrybread.net/uploaded/1/ADU-Spigot.jar
Example code for the PlayerNPC: https://pastebin.com/cLSf5ZMd

MapManager Error with Animated Frames

What steps will reproduce the problem?

1. Just starting the Server
2. Got MapManager Error
3. When i use /afcreate Test url, 2nd error

What were you expecting to happen? What happened instead?

What version of the plugin are you using? Type /version <Plugin Name>

1.3.3 Snapshot MapManager
4.3.3 AnimatedFrames
3.4.4 PacketListenerAPI

What Spigot version are you using? Type /version

Spigot-4741400-a1d3777 (MC:1.11.2)

What plugins ae you using? Type /plugins

Coreprotect, CratesPlus,BlockParticles,Worldedit,MapManager,Votifier,WorldGuard,FastMaps,Autosaveworld,Mythicdrops,ImageOnMap,React,Changegamemode,PermissonsEX,JoinMessageChanger, MotdManager-Reloaded,SimpleVoteListiner,Vault,MyCommand,MassivCore,MysqlEcoBridge,Essentials,CreativeControl,AnimatedFrames,CreativeGates,bChatManager,MobLoot,ActionHealth,TreasureChest,Citizens,CommandNPC,Bossshop,WorldGuardExtraFlags,TitleManager,MyPet

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

MapManager http://pastebin.com/QYeeUMLM

AnimatedFrames:
Picture: http://fs5.directupload.net/images/170202/t2yymd6h.png
LOG: http://pastebin.com/m5wEKmA7

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

no

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

I dont use anything else

lang.ArrayIndexOutOfBoundsException when loading image

What steps will reproduce the problem?

1. Download image: http://puu.sh/vyRuH/aba24f8734.png
2. Code: https://pastebin.com/GCv4y7Ph
3. Enter a value in the method, should cut out the image at the index of the block provided and put it on the map.

What were you expecting to happen? What happened instead?

I am trying to get part of an image and display that on a map, received an error

What version of the plugin are you using? Type /version <Plugin Name>

1.3.4-SNAPSHOT

What Spigot version are you using? Type /version

version 1.10-R0.1-SNAPSHOT

What plugins ae you using? Type /plugins

Custom plugins, no official ones

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

https://pastebin.com/tkb45uUD

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

No.

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

No previous versions or bungeecord, just plain Spigot with the version above.

Error occurs and spams console in Spigot 1.12

What steps will reproduce the problem?

1. Load pplugin on server running Spigot 1.12
2. Server gets spammed with error from plugin

What were you expecting to happen? What happened instead?

Console would not get spammed with error and plugin would work with 1.12

What version of the plugin are you using? Type /version <Plugin Name>

1.3.4-SNAPSHOT

What Spigot version are you using? Type /version

1.12

What plugins ae you using? Type /plugins

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

[12:50:01] [Craft Scheduler Thread - 114/WARN]: java.lang.NoSuchMethodException: net.minecraft.server.v1_12_R1.PacketPlayOutMap.<init>(int, [B) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at java.lang.Class.getConstructor0(Class.java:3082) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at java.lang.Class.getConstructor(Class.java:1825) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at org.inventivetalent.mapmanager.MapSender.constructPacket_1_7(MapSender.java:168) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at org.inventivetalent.mapmanager.MapSender.access$100(MapSender.java:19) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at org.inventivetalent.mapmanager.MapSender$2.run(MapSender.java:104) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:71) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [12:50:01] [Craft Scheduler Thread - 114/WARN]: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

no

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

java.util.ConcurrentModificationException: null

Describe the bug
I get an error when I try to load a map.

To Reproduce

1. Load a map.
2. See the error.

Expected behavior
It should just work.

Additional context

[13:15:53 WARN]: [MapManager] Task #2047 for MapManager v1.8.2-SNAPSHOT generated an exception
java.util.ConcurrentModificationException: null
        at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043) ~[?:?]
        at java.util.ArrayList$Itr.next(ArrayList.java:997) ~[?:?]
        at org.inventivetalent.mapmanager.MapSender.sendMap(MapSender.java:72) ~[?:?]
        at org.inventivetalent.mapmanager.MapSender$1.run(MapSender.java:58) ~[?:?]
        at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:100) ~[patched_1.16.5.jar:git-Paper-742]
        at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:468) ~[patched_1.16.5.jar:git-Paper-742]
        at net.minecraft.server.v1_16_R3.MinecraftServer.b(MinecraftServer.java:1427) ~[patched_1.16.5.jar:git-Paper-742]
        at net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:436) ~[patched_1.16.5.jar:git-Paper-742]
        at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1342) ~[patched_1.16.5.jar:git-Paper-742]
        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1130) ~[patched_1.16.5.jar:git-Paper-742]
        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:291) ~[patched_1.16.5.jar:git-Paper-742]
        at java.lang.Thread.run(Thread.java:834) [?:?]

(This is an issue since v1.8.2, in v1.8.1 it works fine)

What to do when you get MapLimitExceededException?

What steps will reproduce the problem?

1. Create a new map
2. Get the MapLimitExceededException

What to do? Can you just remove some maps from the data, or is there a better/safer way?

Update Method is a bit slow // Fluent animations

What steps will reproduce the problem?

I'm setting up a MultiMapWrapper/Controller and then try to update the image every two ticks.
But instead of having a delay of 0.05 sec I'm having a delay of around 0.25 sec which is caused by the

MapManager/src/org/inventivetalent/mapmanager/MultiMapWrapper.java

Line 87 in 1a01eb1

public void update(BufferedImage content) {

Method

Is there any other way to update a map faster? As the Nyan-Cat example on the AnimatedFrames Spigot page seems to be a lot more fluent. Also, I'm not able to use a GIF file because the updates are dynamic.

Thanks for reading and any help in advance :)

What version of the plugin are you using? Type /version <Plugin Name>

MapManager -> 1.4.0-SNAPSHOT

What Spigot version are you using? Type /version

Spigot 1.8.6 R0.1 SNAPSHOT

What plugins are you using? Type /plugins

MapManager, PacketListenerAPI, My Plugin

java.lang.IllegalArgumentException: Invalid map dimension: 15

Each time the server is restarted, the MapManager plugin generates a large number of errors: https://pastebin.com/pqGKa9Ry

Namely, the server is currently running under Spigot 1.15.2, when we changed version, we had reset the plugin to zero (config and images removed).

We use the latest available version of the plugin(1.7.8).

JavaDoc

JavaDoc site not response