GithubHelp home page GithubHelp logo

php-openssl-cryptor's Issues

Hashing the key

Why the key hashed with php::openssl_digest()? As far as I understand, real strong encryption relies on the initial vector, the key's hash doesn't matter here.. I read the manual about php::openssl_encrypt(), explored examples and comments there, read openssl enc wiki. I saw the comment about password/key subtitution, but I think, yours intention was in something else. So, what the point?

Storing encrypted data in database

Before storing in a database I dump the values of encrypted and then decrypted:
string(32) "6ZoQPJRUhhPM6mKOaOaLQ3Kq0/Jrjw=="
string(6) "qwerty"

Then on retrieving from the database I get:
string(32) "6ZoQPJRUhhPM6mKOaOaLQ3Kq0/Jrjw=="
string(6) "�@ ��>"

The encrypted string looks the same. Why does it not decrypt properly after getting from the database?

I've tried using VARCHAR, VARBINARY and BINARY fields to store the encrypted data.

$iv should not be const/static

According to the documentation, $iv (A non-null initialization vector) in openssl_encrypt as well in openssl_decrypt should be random in every environment. However, currently, it is static for the PHP package. For AES-256-CTR it should be 16 bytes.

$this->iv_num_bytes = openssl_cipher_iv_length($cipher_algo);

can't decrypt on new server

Hi,

I use this simple class on one of my projects.
I use it only with custom key:
Cryptor::Encrypt('[email protected]', $kkey);
on this server, all works ok.

But I need to go to a new one .. after code transfer and get data from DB I can't decrypt encrypted data..
I get some utf string like - ί�]�͇�a���Mٗ�����6����

If I re-encrypt string and decrypt it all is working fine again .. what I miss?
How to use it to be able to future data transfer to a new server?

P.S. I use the same PHP version on same ubuntu servers
PHP Version 7.2.24-0ubuntu0.18.04.4

Changing the Initialization vector?

I made a pull request to remove the call to mcrypt that's still in the file. It can be replaced with an openSSL call, your code will still work.

   // Build an initialisation vector	
   // Replacing all mcrypt calls
    // $iv = mcrypt_create_iv($this->iv_num_bytes, MCRYPT_DEV_URANDOM);
   
    // Build an initialisation vector
    $iv = openssl_random_pseudo_bytes($this->iv_num_bytes, $isStrongCrypto);
    if (!$isStrongCrypto) {
        throw new \Exception("Not a strong key");
    }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.