Comments (5)
Thanks for raising the issue @joewoodhouse!
The issue here is that the custom component is registered before the main Stencil application got registered. The defineCustomElements
returns a promise as it is implemented as follows:
const defineCustomElements = async (win, options) => {
if (typeof window === 'undefined') return undefined;
await globalScripts$1();
return bootstrapLazy([["jeep-sqlite",[[...]], options);
};
With the patch introduced in 4.12.2 (8a129ce) we now ensure that bootstrapLazy
for the custom component is loaded before the main application. You can work around this by doing this in your global script:
--- a/src/global/app.ts
+++ b/src/global/app.ts
@@ -1,11 +1,3 @@
import 'jeep-sqlite';
import { defineCustomElements } from 'jeep-sqlite/loader';
-
-export default async () => {
- /**
- * The code to be executed should be placed within a default function that is
- * exported by the global script. Ensure all of the code in the global script
- * is wrapped in the function() that is exported.
- */
- await defineCustomElements(window);
-};
+setTimeout(() => defineCustomElements(window))
I will ingest the issue into our backlog so we can address this.
from stencil.
For verifying the fix, let's also run the repro case in #5526 which seems to have the same root cause.
from stencil.
Let's also verify that the fix works in #5596
from stencil.
Hey @joewoodhouse 👋 I took another look into your issue again after evaluating the referenced issues and it seems that using the loader import approach does not work in this use case. You can get the jeep-sqlite
component working by just importing the package directly:
diff --git a/src/global/app.ts b/src/global/app.ts
index d8cd166..bfd3ef9 100644
--- a/src/global/app.ts
+++ b/src/global/app.ts
@@ -1,5 +1,4 @@
import 'jeep-sqlite';
-import { defineCustomElements } from 'jeep-sqlite/loader';
export default async () => {
/**
@@ -7,5 +6,4 @@ export default async () => {
* exported by the global script. Ensure all of the code in the global
script
* is wrapped in the function() that is exported.
*/
- await defineCustomElements(window);
};
I will check in with the team to see how we can improve the loader documentation to provide more information on when to use it and when not.
from stencil.
I will go ahead and close this. There is a broader underlying issue where Stencil may encounter issues if multiple runtimes are in play. We have created a ticket for this to address this in near future. This particular problem can be resolved with the instructions in my comment above.
from stencil.
Related Issues (20)
- bug: cannot get value of inherited custom CSS prop in a shadow DOM element via `E2EElement` APIs HOT 2
- cannot identified the prompts.js as a function?? HOT 17
- bug: generated filename is too long HOT 3
- bug: missing root element's scope id as classname in nested child HOT 4
- bug: Failing to load a nested component hides all parents HOT 1
- bug: child input element is receiving un-wanted props HOT 11
- bug: watchIgnoredRegex is not respected during `stencil build --watch`
- bug: puppeteer: piercing on level 1 breaks HOT 8
- bug: `autofocus` prop/attr is defined on other HTML attribute types instead of `HTMLAttributes` HOT 2
- bug: HOT 6
- bug: missing root element's scope id as classname in user provided children HOT 2
- Attribute ping is missing on AnchorHTMLAttributes HOT 3
- bug: Cannot read properties of undefined (reading 'isProxied') HOT 2
- bug: Stencil v4.18.1 breaks support for Jest v26 HOT 10
- bug: intermediate parents' scope ids are not reflected to the children elements HOT 1
- bug: Removing polyfills except for es5 builds breaks existing installs HOT 10
- bug: __mocks__ copied to output target HOT 3
- bug: Cannot access uninitialized variable, only in Safari, works with dev build HOT 3
- bug: Last version 4.18.2 breaks unit test in the proyect. HOT 4
- bug: Test files copied to output target HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stencil.