ionide / ionide-vscode-helpers

Common helpers for VS Code plugins

Ionide-Helpers

Helper library containing some common functionalities used by other ionide plugins for Visual Studio Code.

Contributing and copyright

The project is hosted on GitHub where you can report issues, fork the project and submit pull requests.

The library is available under MIT license, which allows modification and redistribution for both commercial and non-commercial purposes.

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.

Building

Building this project require a few things :

• A .Net 4 environment (Microsoft version on windows, Mono on mac/linux)
• .Net 5
• Node.js
• Yarn berry

With that installed the project should build using build.sh / build.cmd or when Ctrl+Shift+B is used in VSCode.

ionide-vscode-helpers's Issues

Process.exec and Process.spawn need quotes around location when isWin ?

I don't know where to start building all the ionide packages for vscode to test this & create a PR, but it seems like adding quotes around the value of location in Process.exec and spawn might fix ionide/ionide-vscode-fsharp#76
because it currently evaluates to (for example)
cmd.exe /s /c "C:\Users\mark lambert\.vscode\extensions\Ionide.Ionide-fsharp-1.9.1\bin_forge\Forge.exe list templates --no-prompt"
but (testing in cmd.exe)
cmd.exe /s /c ""C:\Users\mark lambert\.vscode\extensions\Ionide.Ionide-fsharp-1.9.1\bin_forge\Forge.exe" list templates --no-prompt"
(note the extra double-quotes) would work.

Reimplement process spawning

Describe the bug
ionide/ionide-vscode-fsharp#1565 describes the problem, but the gist is the current string-based process spawning API hides some issues with paths that contain spaces.

We should refactor that api to take arrays of string arguments, and additionally consider using cross-spawn to spawn processes in an xplat-compliant way. The readme on that repo has good points about why to use it instead of the bare spawn apis.

Update bindings for vscode-languageclient 8.0

Describe the bug

We need to update our bindings. There were some breaking changes in 8.0 .@chrissimon-au did some of that work over in dev-cycles/contextive@a3f7ed8

Can we publish this to Nuget instead of NPM?

I was looking into writing a VS Code Extension using F# and have found myself going down the wrong rabbit hole.

fable-compiler/fable-vscode-extension#1 (comment)

I have tried using Fable.Import.VSCode but got some error regarding missing PromiseLike in Fable.Core or something like that. Then I realized that that package is very old (2017) and only then have I found this repository where you are using a version from ionide/ionide-vscode-helpers NPM package. ../node_modules/ionide-vscode-helpers/src/Fable.Import.VSCode.fs.

If I am a developing an extension using F# and I want to use a F# package I tend to look on nuget.org not npmjs.org. It seems very strange to install a NPM package just to have to reference it by path in .fsproj file. Also, there is no versioning as much as I can find...

Can we publish this to Nuget and provide a version?

The old code is here and it is published on Nuget:

https://github.com/fable-compiler/fable-import/tree/master/VSCode
https://www.nuget.org/packages/Fable.Import.VSCode#versions-body-tab

Can we decide which version will go forward and make one deprecated?

On a side not I can't even find this package on npmjs.org so I have no idea from where am I getting this package.