ip2location / ip2proxy-matomo Goto Github PK

When running with Matomo 4.13.3, PHP 8.1 I get this deprecation warning:

WARNING: /plugins/IP2Proxy/Reports/GetProxyDetails.php(104): Deprecated - Creation of dynamic property Piwik\Plugins\IP2Proxy\Reports\GetProxyDetails::$columns is deprecated - Matomo 4.13.3 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: CoreAdminHome, Action: home, In CLI mode: false)

Having thousands of this lines in my logs:

and

/app/plugins/IP2Proxy/UserSettings.php(54): Deprecated - Creation of dynamic property Piwik\Plugins\IP2Proxy\UserSettings::$subscribedToEmailReport is deprecated - Matomo 4.15.1

WARNING: /plugins/IP2Proxy/lib/IP2Proxy.php(1549): Notice - Undefined offset: 10 - Matomo 4.14.2 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: IP2Proxy, Action: getProxyDetails, Method: IP2Proxy.getProxyDetails, In CLI mode: false)

Hi, there is again one new error with the new version:

/app/plugins/IP2Proxy/UserSettings.php(51): Deprecated - Creation of dynamic property Piwik\Plugins\IP2Proxy\UserSettings::$subscribedToEmailReport is deprecated - Matomo 4.15.1

Dear Matomo Plugin Author,
We are excited that Matomo 5.0.0 is on the horizon, and we would greatly appreciate your assistance in ensuring that your plugin remains compatible with this upcoming release. Maintaining compatibility will enable Matomo users to seamlessly use your plugin after they upgrade to Matomo 5. (If the plugin is not updated to be compatible with Matomo 5, then whenever a user will upgrade to Matomo 5, the plugin would be automatically disabled to prevent issues.)

Updating your plugin to be Matomo 5 compatible is a straightforward process and should not require a significant time investment. You can find more information about updating your plugin at: https://developer.matomo.org/guides/migrate-matomo-4-to-5

Thank you for your ongoing support and commitment to the Matomo community.
Your contribution is really appreciated!

The Matomo Team

PS: we’re also available to help if you have any question about making the plugin compatible.

This code simply doesn't work and is functionally broken. It will compare 8.0.0 to 7.4.0 and return FALSE when it should return TRUE.

I will work on a PR, but in the meantime as a workaround it is easier to just remove the use of this function from the code if you know you are running a PHP version >8.0.0

	/**
	 * A private methode to save the company details in the DB.
	 *
	 * @param mixed $version
	 *
	 * @return bool
	 */
	private function isPHPVersionMoreRecentThan($version)
	{
		$phpVersion = PHP_VERSION;
		$phpVersionParts = explode('.', $phpVersion);
		$phpMinVersionParts = explode('.', $version);

		if ((int) $phpVersionParts[0] < (int) $phpMinVersionParts[0]) {
			return false;
		} elseif ((int) $phpVersionParts[1] < (int) $phpMinVersionParts[1]) {
			return false;
		} elseif ((int) $phpVersionParts[2] < (int) $phpMinVersionParts[2]) {
			return false;
		}

		return true;
	}

Hello,

see also ip2location/ip2location-piwik#40

Lukas from Matomo team here. We are currently in the process of moving our translations from Transifex to Weblate (matomo-org/matomo#17907).
As Weblate makes it easier to add a git repository as a component and merge back updated translations via pull requests, I thought it would be great if more plugins in Matomo were available in the users languages if someone is interested in translating them.

If you are interested in adding your plugin, simply comment here, and I'll help you with the setup.